From 6098a1e4066549ea5b34b4d51586fe5182111487 Mon Sep 17 00:00:00 2001 From: dgp Date: Wed, 3 Dec 2008 07:08:44 +0000 Subject: * generic/tclFileName.c (DoGlob): One of the Tcl_FSMatchInDirectory() calls did not have its return code checked. This caused error messages returned by some Tcl_Filesystem drivers to be swallowed. --- ChangeLog | 7 +++++++ generic/tclFileName.c | 7 ++++--- 2 files changed, 11 insertions(+), 3 deletions(-) diff --git a/ChangeLog b/ChangeLog index 5d6d1ec..0b4f6cb 100644 --- a/ChangeLog +++ b/ChangeLog @@ -1,3 +1,10 @@ +2008-12-03 Don Porter + + * generic/tclFileName.c (DoGlob): One of the + Tcl_FSMatchInDirectory() calls did not have its return code checked. + This caused error messages returned by some Tcl_Filesystem drivers + to be swallowed. + 2008-12-02 Don Porter TIP #336 IMPLEMENTATION diff --git a/generic/tclFileName.c b/generic/tclFileName.c index cca1a9b..2d62414 100644 --- a/generic/tclFileName.c +++ b/generic/tclFileName.c @@ -10,7 +10,7 @@ * See the file "license.terms" for information on usage and redistribution of * this file, and for a DISCLAIMER OF ALL WARRANTIES. * - * RCS: @(#) $Id: tclFileName.c,v 1.94 2008/10/16 22:34:19 nijtmans Exp $ + * RCS: @(#) $Id: tclFileName.c,v 1.95 2008/12/03 07:08:44 dgp Exp $ */ #include "tclInt.h" @@ -2464,9 +2464,10 @@ DoGlob( } Tcl_IncrRefCount(joinedPtr); Tcl_DStringFree(&append); - Tcl_FSMatchInDirectory(interp, matchesObj, joinedPtr, NULL, types); + result = Tcl_FSMatchInDirectory(interp, matchesObj, joinedPtr, NULL, + types); Tcl_DecrRefCount(joinedPtr); - return TCL_OK; + return result; } /* -- cgit v0.12