From 03cf1c69bbf2cbf952abeef3db7bf2129756e53b Mon Sep 17 00:00:00 2001
From: sebres <sebres@users.sourceforge.net>
Date: Thu, 16 May 2024 08:56:01 +0000
Subject: code review: preserving r/w channels after all possible failures
 (don't need to release in error case)

---
 generic/tclIO.c | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/generic/tclIO.c b/generic/tclIO.c
index 31cb48f..80b646b 100644
--- a/generic/tclIO.c
+++ b/generic/tclIO.c
@@ -8638,9 +8638,6 @@ TclCopyChannel(
     CopyState *csPtr;
     int nonBlocking = (cmdPtr) ? CHANNEL_NONBLOCKING : 0;
 
-    TclChannelPreserve(inChan);
-    TclChannelPreserve(outChan);
-
     inStatePtr = inPtr->state;
     outStatePtr = outPtr->state;
 
@@ -8711,6 +8708,9 @@ TclCopyChannel(
     }
     csPtr->cmdPtr = cmdPtr;
 
+    TclChannelPreserve(inChan);
+    TclChannelPreserve(outChan);
+
     inStatePtr->csPtrR = csPtr;
     outStatePtr->csPtrW = csPtr;
 
-- 
cgit v0.12