From ef51b5aacdb05bb3e9120129f0c50ae3b31bf915 Mon Sep 17 00:00:00 2001 From: "jan.nijtmans" Date: Sat, 29 Apr 2023 14:56:13 +0000 Subject: Resolve a TODO --- generic/tclBasic.c | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/generic/tclBasic.c b/generic/tclBasic.c index 686cf62..1b4bca1 100644 --- a/generic/tclBasic.c +++ b/generic/tclBasic.c @@ -3298,7 +3298,11 @@ invokeObj2Command( Command *cmdPtr = (Command *) clientData; if (objc > INT_MAX) { - objc = TCL_INDEX_NONE; /* TODO - why? Should error, not truncate */ + /* Since TCL_INDEX_NONE is an invalid value for objc, + * calling cmdPtr->objProc or cmdPtr->nreProc will + * eventually result in a Tcl_WrongNumArgs() call. + * That's exactly what we want to happen. */ + objc = TCL_INDEX_NONE; } if (cmdPtr->objProc != NULL) { result = cmdPtr->objProc(cmdPtr->objClientData, interp, objc, objv); -- cgit v0.12