From 51043c29dbb3bb9538b0e3db5088b8ada1799b7b Mon Sep 17 00:00:00 2001 From: apnadkarni Date: Mon, 24 Apr 2023 17:16:58 +0000 Subject: Fix [c719fa8716] - binary encode base64 assertion failure --- generic/tclBinary.c | 8 ++++---- tests/bigdata.test | 2 +- 2 files changed, 5 insertions(+), 5 deletions(-) diff --git a/generic/tclBinary.c b/generic/tclBinary.c index e0bfd46..6f4fb06 100644 --- a/generic/tclBinary.c +++ b/generic/tclBinary.c @@ -2638,11 +2638,11 @@ BinaryEncode64( { Tcl_Obj *resultObj; unsigned char *data, *limit; - int maxlen = 0; + Tcl_Size maxlen = 0; const char *wrapchar = "\n"; Tcl_Size wrapcharlen = 1; - int i, index, size, outindex = 0, purewrap = 1; - Tcl_Size offset, count = 0; + int index, purewrap = 1; + Tcl_Size i, offset, size, outindex = 0, count = 0; enum { OPT_MAXLEN, OPT_WRAPCHAR }; static const char *const optStrings[] = { "-maxlen", "-wrapchar", NULL }; @@ -2658,7 +2658,7 @@ BinaryEncode64( } switch (index) { case OPT_MAXLEN: - if (Tcl_GetIntFromObj(interp, objv[i + 1], &maxlen) != TCL_OK) { + if (Tcl_GetSizeIntFromObj(interp, objv[i + 1], &maxlen) != TCL_OK) { return TCL_ERROR; } if (maxlen < 0) { diff --git a/tests/bigdata.test b/tests/bigdata.test index ab4335b..8b0c349 100644 --- a/tests/bigdata.test +++ b/tests/bigdata.test @@ -744,7 +744,7 @@ bigtestRO binary-encode/decode-base64-bigdata-1 "binary encode/decode base64" 1 set bin [bigBinary 4294967296] } -cleanup { bigClean -} -constraints bug-c719fa8716 +} # # binary encode / decode hex -- cgit v0.12