summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorculler <culler>2020-08-25 16:16:43 (GMT)
committerculler <culler>2020-08-25 16:16:43 (GMT)
commit4cb9d608b9e906a7ff8a3a67df94551dd0ce79ff (patch)
tree4f01f271f23168ba81613c16f7a78c53c11d5ddb
parent8de1dd53e5559e54b3456769fd305f2ee0dd27a9 (diff)
downloadtk-4cb9d608b9e906a7ff8a3a67df94551dd0ce79ff.zip
tk-4cb9d608b9e906a7ff8a3a67df94551dd0ce79ff.tar.gz
tk-4cb9d608b9e906a7ff8a3a67df94551dd0ce79ff.tar.bz2
Fix [08eb057dea]: remove two unused stub functions related to cursors and dating back to Carbon.
-rw-r--r--generic/tk.decls14
-rw-r--r--generic/tkInt.decls7
-rw-r--r--generic/tkIntPlatDecls.h8
-rw-r--r--generic/tkPlatDecls.h16
-rw-r--r--generic/tkStubInit.c6
-rw-r--r--macosx/tkMacOSXCursor.c46
6 files changed, 28 insertions, 69 deletions
diff --git a/generic/tk.decls b/generic/tk.decls
index ee1d97b..4261dec 100644
--- a/generic/tk.decls
+++ b/generic/tk.decls
@@ -1111,9 +1111,10 @@ declare 0 aqua {
declare 1 aqua {
void Tk_MacOSXTurnOffMenus(void)
}
-declare 2 aqua {
- void Tk_MacOSXTkOwnsCursor(int tkOwnsIt)
-}
+# Does not exist anymore.
+#declare 2 aqua {
+# void Tk_MacOSXTkOwnsCursor(int tkOwnsIt)
+#}
declare 3 aqua {
void TkMacOSXInitMenus(Tcl_Interp *interp)
}
@@ -1150,9 +1151,10 @@ declare 11 aqua {
declare 12 aqua {
void Tk_MacOSXTurnOffMenus_(void)
}
-declare 13 aqua {
- void Tk_MacOSXTkOwnsCursor_(int tkOwnsIt)
-}
+# Does not exist anymore
+#declare 13 aqua {
+# void Tk_MacOSXTkOwnsCursor_(int tkOwnsIt)
+#}
declare 14 aqua {
void TkMacOSXInitMenus_(Tcl_Interp *interp)
}
diff --git a/generic/tkInt.decls b/generic/tkInt.decls
index a160541..82e4f2e 100644
--- a/generic/tkInt.decls
+++ b/generic/tkInt.decls
@@ -912,9 +912,10 @@ declare 9 aqua {
declare 10 aqua {
int TkMacOSXDispatchMenuEvent(int menuID, int index)
}
-declare 11 aqua {
- void TkMacOSXInstallCursor(int resizeOverride)
-}
+# Now a static function
+# declare 11 aqua {
+# void TkMacOSXInstallCursor(int resizeOverride)
+# }
declare 12 aqua {
void TkMacOSXHandleTearoffMenu(void)
}
diff --git a/generic/tkIntPlatDecls.h b/generic/tkIntPlatDecls.h
index 8221d7a..f80a0c0 100644
--- a/generic/tkIntPlatDecls.h
+++ b/generic/tkIntPlatDecls.h
@@ -170,8 +170,7 @@ EXTERN unsigned int TkMacOSXButtonKeyState(void);
EXTERN void TkMacOSXClearMenubarActive(void);
/* 10 */
EXTERN int TkMacOSXDispatchMenuEvent(int menuID, int index);
-/* 11 */
-EXTERN void TkMacOSXInstallCursor(int resizeOverride);
+/* Slot 11 is reserved */
/* 12 */
EXTERN void TkMacOSXHandleTearoffMenu(void);
/* Slot 13 is reserved */
@@ -405,7 +404,7 @@ typedef struct TkIntPlatStubs {
unsigned int (*tkMacOSXButtonKeyState) (void); /* 8 */
void (*tkMacOSXClearMenubarActive) (void); /* 9 */
int (*tkMacOSXDispatchMenuEvent) (int menuID, int index); /* 10 */
- void (*tkMacOSXInstallCursor) (int resizeOverride); /* 11 */
+ void (*reserved11)(void);
void (*tkMacOSXHandleTearoffMenu) (void); /* 12 */
void (*reserved13)(void);
int (*tkMacOSXDoHLEvent) (void *theEvent); /* 14 */
@@ -631,8 +630,7 @@ extern const TkIntPlatStubs *tkIntPlatStubsPtr;
(tkIntPlatStubsPtr->tkMacOSXClearMenubarActive) /* 9 */
#define TkMacOSXDispatchMenuEvent \
(tkIntPlatStubsPtr->tkMacOSXDispatchMenuEvent) /* 10 */
-#define TkMacOSXInstallCursor \
- (tkIntPlatStubsPtr->tkMacOSXInstallCursor) /* 11 */
+/* Slot 11 is reserved */
#define TkMacOSXHandleTearoffMenu \
(tkIntPlatStubsPtr->tkMacOSXHandleTearoffMenu) /* 12 */
/* Slot 13 is reserved */
diff --git a/generic/tkPlatDecls.h b/generic/tkPlatDecls.h
index db9141c..70b3239 100644
--- a/generic/tkPlatDecls.h
+++ b/generic/tkPlatDecls.h
@@ -63,8 +63,7 @@ EXTERN void Tk_MacOSXSetEmbedHandler(
Tk_MacOSXEmbedGetOffsetInParentProc *getOffsetProc);
/* 1 */
EXTERN void Tk_MacOSXTurnOffMenus(void);
-/* 2 */
-EXTERN void Tk_MacOSXTkOwnsCursor(int tkOwnsIt);
+/* Slot 2 is reserved */
/* 3 */
EXTERN void TkMacOSXInitMenus(Tcl_Interp *interp);
/* 4 */
@@ -91,8 +90,7 @@ EXTERN void Tk_MacOSXSetEmbedHandler_(
Tk_MacOSXEmbedGetOffsetInParentProc *getOffsetProc);
/* 12 */
EXTERN void Tk_MacOSXTurnOffMenus_(void);
-/* 13 */
-EXTERN void Tk_MacOSXTkOwnsCursor_(int tkOwnsIt);
+/* Slot 13 is reserved */
/* 14 */
EXTERN void TkMacOSXInitMenus_(Tcl_Interp *interp);
/* 15 */
@@ -117,7 +115,7 @@ typedef struct TkPlatStubs {
#ifdef MAC_OSX_TK /* AQUA */
void (*tk_MacOSXSetEmbedHandler) (Tk_MacOSXEmbedRegisterWinProc *registerWinProcPtr, Tk_MacOSXEmbedGetGrafPortProc *getPortProcPtr, Tk_MacOSXEmbedMakeContainerExistProc *containerExistProcPtr, Tk_MacOSXEmbedGetClipProc *getClipProc, Tk_MacOSXEmbedGetOffsetInParentProc *getOffsetProc); /* 0 */
void (*tk_MacOSXTurnOffMenus) (void); /* 1 */
- void (*tk_MacOSXTkOwnsCursor) (int tkOwnsIt); /* 2 */
+ void (*reserved2)(void);
void (*tkMacOSXInitMenus) (Tcl_Interp *interp); /* 3 */
void (*tkMacOSXInitAppleEvents) (Tcl_Interp *interp); /* 4 */
void (*tkGenWMConfigureEvent) (Tk_Window tkwin, int x, int y, int width, int height, int flags); /* 5 */
@@ -128,7 +126,7 @@ typedef struct TkPlatStubs {
int (*tk_MacOSXIsAppInFront) (void); /* 10 */
void (*tk_MacOSXSetEmbedHandler_) (Tk_MacOSXEmbedRegisterWinProc *registerWinProcPtr, Tk_MacOSXEmbedGetGrafPortProc *getPortProcPtr, Tk_MacOSXEmbedMakeContainerExistProc *containerExistProcPtr, Tk_MacOSXEmbedGetClipProc *getClipProc, Tk_MacOSXEmbedGetOffsetInParentProc *getOffsetProc); /* 11 */
void (*tk_MacOSXTurnOffMenus_) (void); /* 12 */
- void (*tk_MacOSXTkOwnsCursor_) (int tkOwnsIt); /* 13 */
+ void (*reserved13)(void);
void (*tkMacOSXInitMenus_) (Tcl_Interp *interp); /* 14 */
void (*tkMacOSXInitAppleEvents_) (Tcl_Interp *interp); /* 15 */
void (*tkGenWMConfigureEvent_) (Tk_Window tkwin, int x, int y, int width, int height, int flags); /* 16 */
@@ -166,8 +164,7 @@ extern const TkPlatStubs *tkPlatStubsPtr;
(tkPlatStubsPtr->tk_MacOSXSetEmbedHandler) /* 0 */
#define Tk_MacOSXTurnOffMenus \
(tkPlatStubsPtr->tk_MacOSXTurnOffMenus) /* 1 */
-#define Tk_MacOSXTkOwnsCursor \
- (tkPlatStubsPtr->tk_MacOSXTkOwnsCursor) /* 2 */
+/* Slot 2 is reserved */
#define TkMacOSXInitMenus \
(tkPlatStubsPtr->tkMacOSXInitMenus) /* 3 */
#define TkMacOSXInitAppleEvents \
@@ -188,8 +185,7 @@ extern const TkPlatStubs *tkPlatStubsPtr;
(tkPlatStubsPtr->tk_MacOSXSetEmbedHandler_) /* 11 */
#define Tk_MacOSXTurnOffMenus_ \
(tkPlatStubsPtr->tk_MacOSXTurnOffMenus_) /* 12 */
-#define Tk_MacOSXTkOwnsCursor_ \
- (tkPlatStubsPtr->tk_MacOSXTkOwnsCursor_) /* 13 */
+/* Slot 13 is reserved */
#define TkMacOSXInitMenus_ \
(tkPlatStubsPtr->tkMacOSXInitMenus_) /* 14 */
#define TkMacOSXInitAppleEvents_ \
diff --git a/generic/tkStubInit.c b/generic/tkStubInit.c
index 0020fac..443d91a 100644
--- a/generic/tkStubInit.c
+++ b/generic/tkStubInit.c
@@ -572,7 +572,7 @@ static const TkIntPlatStubs tkIntPlatStubs = {
TkMacOSXButtonKeyState, /* 8 */
TkMacOSXClearMenubarActive, /* 9 */
TkMacOSXDispatchMenuEvent, /* 10 */
- TkMacOSXInstallCursor, /* 11 */
+ 0, /* 11 */
TkMacOSXHandleTearoffMenu, /* 12 */
0, /* 13 */
TkMacOSXDoHLEvent, /* 14 */
@@ -1009,7 +1009,7 @@ static const TkPlatStubs tkPlatStubs = {
#ifdef MAC_OSX_TK /* AQUA */
Tk_MacOSXSetEmbedHandler, /* 0 */
Tk_MacOSXTurnOffMenus, /* 1 */
- Tk_MacOSXTkOwnsCursor, /* 2 */
+ 0, /* 2 */
TkMacOSXInitMenus, /* 3 */
TkMacOSXInitAppleEvents, /* 4 */
TkGenWMConfigureEvent, /* 5 */
@@ -1020,7 +1020,7 @@ static const TkPlatStubs tkPlatStubs = {
Tk_MacOSXIsAppInFront, /* 10 */
Tk_MacOSXSetEmbedHandler_, /* 11 */
Tk_MacOSXTurnOffMenus_, /* 12 */
- Tk_MacOSXTkOwnsCursor_, /* 13 */
+ 0, /* 13 */
TkMacOSXInitMenus_, /* 14 */
TkMacOSXInitAppleEvents_, /* 15 */
TkGenWMConfigureEvent_, /* 16 */
diff --git a/macosx/tkMacOSXCursor.c b/macosx/tkMacOSXCursor.c
index 894a44d..49caf37 100644
--- a/macosx/tkMacOSXCursor.c
+++ b/macosx/tkMacOSXCursor.c
@@ -187,15 +187,6 @@ static const struct CursorName cursorNames[] = {
static TkMacOSXCursor *gCurrentCursor = NULL;
/* A pointer to the current cursor. */
-static int gResizeOverride = false;
- /* A boolean indicating whether we should use
- * the resize cursor during installations. */
-static int gTkOwnsCursor = true;/* A boolean indicating whether Tk owns the
- * cursor. If not (for instance, in the case
- * where a Tk window is embedded in another
- * app's window, and the cursor is out of the
- * Tk window, we will not attempt to adjust
- * the cursor. */
/*
* Declarations of procedures local to this file
@@ -487,17 +478,15 @@ TkpFreeCursor(
*----------------------------------------------------------------------
*/
-void
+static void
TkMacOSXInstallCursor(
- int resizeOverride)
+ void)
{
TkMacOSXCursor *macCursorPtr = gCurrentCursor;
static int cursorHidden = 0;
int cursorNone = 0;
- gResizeOverride = resizeOverride;
-
- if (resizeOverride || !macCursorPtr) {
+ if (!macCursorPtr) {
[[NSCursor arrowCursor] set];
} else {
switch (macCursorPtr->type) {
@@ -545,10 +534,6 @@ TkpSetCursor(
{
int cursorChanged = 1;
- if (!gTkOwnsCursor) {
- return;
- }
-
if (cursor == None) {
/*
* This is a little tricky. We can't really tell whether
@@ -567,34 +552,11 @@ TkpSetCursor(
}
if (Tk_MacOSXIsAppInFront() && cursorChanged) {
- TkMacOSXInstallCursor(gResizeOverride);
+ TkMacOSXInstallCursor();
}
}
/*
- *----------------------------------------------------------------------
- *
- * Tk_MacOSXTkOwnsCursor --
- *
- * Sets whether Tk has the right to adjust the cursor.
- *
- * Results:
- * None.
- *
- * Side effects:
- * May keep Tk from changing the cursor.
- *
- *----------------------------------------------------------------------
- */
-
-void
-Tk_MacOSXTkOwnsCursor(
- int tkOwnsIt)
-{
- gTkOwnsCursor = tkOwnsIt;
-}
-
-/*
* Local Variables:
* mode: objc
* c-basic-offset: 4