diff options
| author | dgp <dgp@users.sourceforge.net> | 2014-11-07 14:22:05 (GMT) |
|---|---|---|
| committer | dgp <dgp@users.sourceforge.net> | 2014-11-07 14:22:05 (GMT) |
| commit | 054420d1e3b71ea9d657396bb42d92472b0d7e88 (patch) | |
| tree | 2b4547b0fdbf3c85aef0cfcb1be9c36279417c24 | |
| parent | 1d9e044ef59c5a3e36e20c161ecd5b8e4b09ad3c (diff) | |
| parent | fcc39af8d8691cdcc0ce49efe09ad61b94da9ba0 (diff) | |
| download | tk-054420d1e3b71ea9d657396bb42d92472b0d7e88.zip tk-054420d1e3b71ea9d657396bb42d92472b0d7e88.tar.gz tk-054420d1e3b71ea9d657396bb42d92472b0d7e88.tar.bz2 | |
[3529885] [scale] handle negative resolution properly.
| -rw-r--r-- | library/scale.tcl | 8 | ||||
| -rw-r--r-- | tests/scale.test | 33 |
2 files changed, 40 insertions, 1 deletions
diff --git a/library/scale.tcl b/library/scale.tcl index d9e7d27..fb9b81b 100644 --- a/library/scale.tcl +++ b/library/scale.tcl @@ -223,7 +223,13 @@ proc ::tk::ScaleIncrement {w dir big repeat} { set inc [$w cget -resolution] } if {([$w cget -from] > [$w cget -to]) ^ ($dir eq "up")} { - set inc [expr {-$inc}] + if {$inc > 0} { + set inc [expr {-$inc}] + } + } else { + if {$inc < 0} { + set inc [expr {-$inc}] + } } $w set [expr {[$w get] + $inc}] diff --git a/tests/scale.test b/tests/scale.test index 1e072a0..32ce1ff 100644 --- a/tests/scale.test +++ b/tests/scale.test @@ -1362,6 +1362,39 @@ test scale-18.3 {Scale button 2 events [Bug 787065]} -setup { } -result {0 {}} +test scale-19 {Bug [3529885fff] - Click in through goes in wrong direction} \ + -setup { + catch {destroy .s} + catch {destroy .s1 .s2 .s3 .s4} + scale .s1 -from 0 -to 100 -resolution 1 -variable x1 -digits 4 -orient horizontal -length 100 + scale .s2 -from 0 -to 100 -resolution -1 -variable x2 -digits 4 -orient horizontal -length 100 + scale .s3 -from 100 -to 0 -resolution 1 -variable x3 -digits 4 -orient horizontal -length 100 + scale .s4 -from 100 -to 0 -resolution -1 -variable x4 -digits 4 -orient horizontal -length 100 + pack .s1 .s2 .s3 .s4 -side left + update + } \ + -body { + foreach {x y} [.s1 coord 50] {} + event generate .s1 <1> -x $x -y $y + event generate .s1 <ButtonRelease-1> -x $x -y $y + foreach {x y} [.s2 coord 50] {} + event generate .s2 <1> -x $x -y $y + event generate .s2 <ButtonRelease-1> -x $x -y $y + foreach {x y} [.s3 coord 50] {} + event generate .s3 <1> -x $x -y $y + event generate .s3 <ButtonRelease-1> -x $x -y $y + foreach {x y} [.s4 coord 50] {} + event generate .s4 <1> -x $x -y $y + event generate .s4 <ButtonRelease-1> -x $x -y $y + update + list $x1 $x2 $x3 $x4 + } \ + -cleanup { + unset x1 x2 x3 x4 x y + destroy .s1 .s2 .s3 .s4 + } \ + -result {1.0 1.0 1.0 1.0} + option clear # cleanup |