summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorjan.nijtmans <nijtmans@users.sourceforge.net>2012-07-08 08:19:37 (GMT)
committerjan.nijtmans <nijtmans@users.sourceforge.net>2012-07-08 08:19:37 (GMT)
commitfd30222557d14ec07608457f8dbd41a6b2e2b0d8 (patch)
tree3a2b5be7f844bde40f0e5c58f501e6f85974607a
parent319fea781804534c94a5d3a52f05d04dcb6042e5 (diff)
parentd0a3f3b5288cf9564bade2efdf74599e1ac24a1b (diff)
downloadtk-fd30222557d14ec07608457f8dbd41a6b2e2b0d8.zip
tk-fd30222557d14ec07608457f8dbd41a6b2e2b0d8.tar.gz
tk-fd30222557d14ec07608457f8dbd41a6b2e2b0d8.tar.bz2
[Bug 3532186]: pkgIndex.tcl file complexity that's unwarranted: Test for ::argv variable before trying to use it
-rw-r--r--unix/Makefile.in4
-rw-r--r--win/Makefile.in4
2 files changed, 4 insertions, 4 deletions
diff --git a/unix/Makefile.in b/unix/Makefile.in
index fbe7b97..08192b9 100644
--- a/unix/Makefile.in
+++ b/unix/Makefile.in
@@ -726,8 +726,8 @@ install-binaries: $(TK_LIB_FILE) $(TK_STUB_LIB_FILE) ${WISH_EXE}
if test "x$(DLL_INSTALL_DIR)" != "x$(BIN_INSTALL_DIR)"; then \
echo "package ifneeded Tk $(MAJOR_VERSION).$(MINOR_VERSION)$(PATCH_LEVEL) [list load [file join \$$dir $${relative}$(TK_LIB_FILE)] Tk]";\
else \
- echo "if {(\$$::tcl_platform(platform) eq \"unix\")";\
- echo " && ([info exists ::env(DISPLAY)] || [lsearch -exact \$$::argv -display] > -1)} {";\
+ echo "if {(\$$::tcl_platform(platform) eq \"unix\") && ([info exists ::env(DISPLAY)]";\
+ echo " || ([info exists ::argv] && [lsearch -exact \$$::argv -display] > -1))} {";\
echo " package ifneeded Tk $(MAJOR_VERSION).$(MINOR_VERSION)$(PATCH_LEVEL) [list load [file join \$$dir $${relative}.. bin $(TK_LIB_FILE)] Tk]";\
echo "} else {";\
echo " package ifneeded Tk $(MAJOR_VERSION).$(MINOR_VERSION)$(PATCH_LEVEL) [list load [file join \$$dir $${relative}.. bin tk${MAJOR_VERSION}${MINOR_VERSION}.dll] Tk]";\
diff --git a/win/Makefile.in b/win/Makefile.in
index 799e5ee..1f92ebb 100644
--- a/win/Makefile.in
+++ b/win/Makefile.in
@@ -478,8 +478,8 @@ install-binaries: binaries
@$(RM) $(PKG_INDEX);
@(\
echo "if {[catch {package present Tcl 8.5.0}]} { return }";\
- echo "if {(\$$::tcl_platform(platform) eq \"unix\")";\
- echo " && ([info exists ::env(DISPLAY)] || [lsearch -exact \$$::argv -display] > -1)} {";\
+ echo "if {(\$$::tcl_platform(platform) eq \"unix\") && ([info exists ::env(DISPLAY)]";\
+ echo " || ([info exists ::argv] && [lsearch -exact \$$::argv -display] > -1))} {";\
echo " package ifneeded Tk $(VERSION)$(PATCH_LEVEL) [list load [file join \$$dir .. .. bin libtk$(VERSION).dll] Tk]";\
echo "} else {";\
echo " package ifneeded Tk $(VERSION)$(PATCH_LEVEL) [list load [file join \$$dir .. .. bin $(TK_DLL_FILE)] Tk]";\