summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authordas <das>2008-06-12 17:08:59 (GMT)
committerdas <das>2008-06-12 17:08:59 (GMT)
commitf12c70da2d6208293f2afb3d2181b40adb47ec67 (patch)
treee8274ebca07d7ba94dd574e24b4c05d5fc7307cf
parent69c551e2161854eacae84b96ebaee955178bad80 (diff)
downloadtk-f12c70da2d6208293f2afb3d2181b40adb47ec67.zip
tk-f12c70da2d6208293f2afb3d2181b40adb47ec67.tar.gz
tk-f12c70da2d6208293f2afb3d2181b40adb47ec67.tar.bz2
* generic/tkPointer.c (Tk_UpdatePointer): fix failure to restore a
global grab capture and to release the restrict window capture when releasing a button grab. Fixes segfault due to dangling reference to restrict window inside TkpSetCapture() implementation. [Bug 1991932]
-rw-r--r--ChangeLog5
-rw-r--r--generic/tkPointer.c10
2 files changed, 9 insertions, 6 deletions
diff --git a/ChangeLog b/ChangeLog
index c1733f8..309884e 100644
--- a/ChangeLog
+++ b/ChangeLog
@@ -1,5 +1,10 @@
2008-06-12 Daniel Steffen <das@users.sourceforge.net>
+ * generic/tkPointer.c (Tk_UpdatePointer): fix failure to restore a
+ global grab capture and to release the restrict window capture when
+ releasing a button grab. Fixes segfault due to dangling reference to
+ restrict window inside TkpSetCapture() implementation. [Bug 1991932]
+
* generic/ttk/ttkTreeview.c: fix warning.
* unix/tcl.m4 (SunOS-5.11): fix 64bit amd64 support with gcc & Sun cc.
diff --git a/generic/tkPointer.c b/generic/tkPointer.c
index 3b38cbe..99b61b7 100644
--- a/generic/tkPointer.c
+++ b/generic/tkPointer.c
@@ -11,7 +11,7 @@
* See the file "license.terms" for information on usage and redistribution of
* this file, and for a DISCLAIMER OF ALL WARRANTIES.
*
- * RCS: @(#) $Id: tkPointer.c,v 1.10 2005/11/15 15:18:22 dkf Exp $
+ * RCS: @(#) $Id: tkPointer.c,v 1.11 2008/06/12 17:08:59 das Exp $
*/
#include "tkInt.h"
@@ -309,14 +309,12 @@ Tk_UpdatePointer(
/*
* ButtonRelease - Release the mouse capture and clear the
- * restrict window when the last button is released and we
- * aren't in a global grab.
+ * restrict window when the last button is released. If we
+ * are in a global grab, restore the grab window capture.
*/
if ((tsdPtr->lastState & ALL_BUTTONS) == mask) {
- if (!tsdPtr->grabWinPtr) {
- TkpSetCapture(NULL);
- }
+ TkpSetCapture(tsdPtr->grabWinPtr);
}
/*