summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorjan.nijtmans <nijtmans@users.sourceforge.net>2022-09-23 09:33:23 (GMT)
committerjan.nijtmans <nijtmans@users.sourceforge.net>2022-09-23 09:33:23 (GMT)
commitb4cd4a1bb5b919fb2feb328ca361dfd0dc1cb1bf (patch)
treef54af83759617e1a32a02544ca53c58e3df5f17f
parent82caf6d6c436099f4b39035766d63ce017ade6b1 (diff)
downloadtk-b4cd4a1bb5b919fb2feb328ca361dfd0dc1cb1bf.zip
tk-b4cd4a1bb5b919fb2feb328ca361dfd0dc1cb1bf.tar.gz
tk-b4cd4a1bb5b919fb2feb328ca361dfd0dc1cb1bf.tar.bz2
Minor code cleanup (more use of TCL_UNUSED, eol-spacing)
-rw-r--r--macosx/tkMacOSXColor.c10
-rw-r--r--macosx/tkMacOSXDialog.c2
-rw-r--r--macosx/tkMacOSXMenu.c27
-rw-r--r--macosx/tkMacOSXPrivate.h11
-rw-r--r--macosx/tkMacOSXXStubs.c4
5 files changed, 27 insertions, 27 deletions
diff --git a/macosx/tkMacOSXColor.c b/macosx/tkMacOSXColor.c
index 268c33d..dde9df2 100644
--- a/macosx/tkMacOSXColor.c
+++ b/macosx/tkMacOSXColor.c
@@ -7,7 +7,7 @@
*
* Copyright (c) 1990-1994 The Regents of the University of California.
* Copyright (c) 1994-1996 Sun Microsystems, Inc.
- * Copyright 2001-2009, Apple Inc.
+ * Copyright (c) 2001-2009 Apple Inc.
* Copyright (c) 2006-2009 Daniel A. Steffen <das@users.sourceforge.net>
* Copyright (c) 2020 Marc Culler
*
@@ -462,6 +462,8 @@ TkMacOSXInDarkMode(Tk_Window tkwin)
}
return (name == NSAppearanceNameDarkAqua);
}
+#else
+ (void) tkwin;
#endif
return false;
}
@@ -519,7 +521,7 @@ TkSetMacColor(
NSColor*
TkMacOSXGetNSColor(
- GC gc,
+ TCL_UNUSED(GC),
unsigned long pixel) /* Pixel value to convert. */
{
CGColorRef cgColor = NULL;
@@ -555,7 +557,7 @@ TkMacOSXGetNSColor(
void
TkMacOSXSetColorInContext(
- GC gc,
+ TCL_UNUSED(GC),
unsigned long pixel,
CGContextRef context)
{
@@ -677,7 +679,7 @@ TkpGetColor(
colormap = lightColormap;
}
if (@available(macOS 11.0, *)) {
- CGFloat *rgbaPtr = rgba;
+ CGFloat *rgbaPtr = rgba;
[windowAppearance performAsCurrentDrawingAppearance:^{
GetRGBA(entry, p.ulong, rgbaPtr);
}];
diff --git a/macosx/tkMacOSXDialog.c b/macosx/tkMacOSXDialog.c
index 8af298b..5170545 100644
--- a/macosx/tkMacOSXDialog.c
+++ b/macosx/tkMacOSXDialog.c
@@ -48,7 +48,7 @@ static void setAllowedFileTypes(
}
#else
[panel setAllowedFileTypes:extensions];
-#endif
+#endif
}
/*
diff --git a/macosx/tkMacOSXMenu.c b/macosx/tkMacOSXMenu.c
index b9607d5..7e8b854 100644
--- a/macosx/tkMacOSXMenu.c
+++ b/macosx/tkMacOSXMenu.c
@@ -364,20 +364,17 @@ static Bool runMenuCommand = true;
TkMenuEntry *mePtr = (TkMenuEntry *) [menuItem tag];
if (menuPtr && mePtr) {
- Tcl_Interp *interp = menuPtr->interp;
-
- Tcl_Preserve(interp);
- Tcl_Preserve(menuPtr);
-
- int result = TkInvokeMenu(interp, menuPtr, mePtr->index);
-
- if (result != TCL_OK && result != TCL_CONTINUE &&
- result != TCL_BREAK) {
- Tcl_AddErrorInfo(interp, "\n (menu invoke)");
- Tcl_BackgroundException(interp, result);
- }
- Tcl_Release(menuPtr);
- Tcl_Release(interp);
+ Tcl_Interp *interp = menuPtr->interp;
+ Tcl_Preserve(interp);
+ Tcl_Preserve(menuPtr);
+ int result = TkInvokeMenu(interp, menuPtr, mePtr->index);
+ if (result != TCL_OK && result != TCL_CONTINUE &&
+ result != TCL_BREAK) {
+ Tcl_AddErrorInfo(interp, "\n (menu invoke)");
+ Tcl_BackgroundException(interp, result);
+ }
+ Tcl_Release(menuPtr);
+ Tcl_Release(interp);
}
}
}
@@ -517,7 +514,7 @@ static Bool runMenuCommand = true;
* Make sure that we can run commands when actually using a menu.
* See [412b80fcaf].
*/
-
+
runMenuCommand = true;
}
diff --git a/macosx/tkMacOSXPrivate.h b/macosx/tkMacOSXPrivate.h
index ad3e006..f51397d 100644
--- a/macosx/tkMacOSXPrivate.h
+++ b/macosx/tkMacOSXPrivate.h
@@ -124,9 +124,10 @@
* Macro abstracting use of TkMacOSXGetNamedSymbol to init named symbols.
*/
+#define UNINITIALISED_SYMBOL ((void*)(-1L))
#define TkMacOSXInitNamedSymbol(module, ret, symbol, ...) \
- static ret (* symbol)(__VA_ARGS__) = (void*)(-1L); \
- if (symbol == (void*)(-1L)) { \
+ static ret (* symbol)(__VA_ARGS__) = UNINITIALISED_SYMBOL; \
+ if (symbol == UNINITIALISED_SYMBOL) { \
symbol = TkMacOSXGetNamedSymbol(STRINGIFY(module), \
STRINGIFY(symbol)); \
}
@@ -256,13 +257,13 @@ MODULE_SCOPE void TkMacOSXRestoreDrawingContext(
MODULE_SCOPE void TkMacOSXSetColorInContext(GC gc, unsigned long pixel,
CGContextRef context);
#define TkMacOSXGetTkWindow(window) ((TkWindow *)Tk_MacOSXGetTkWindow(window))
-#define TkMacOSXGetNSWindowForDrawable(drawable) ((NSWindow*)TkMacOSXDrawable(drawable))
+#define TkMacOSXGetNSWindowForDrawable(drawable) ((NSWindow *)TkMacOSXDrawable(drawable))
#define TkMacOSXGetNSViewForDrawable(macWin) ((NSView *)Tk_MacOSXGetNSViewForDrawable((Drawable)(macWin)))
+MODULE_SCOPE CGContextRef TkMacOSXGetCGContextForDrawable(Drawable drawable);
MODULE_SCOPE void TkMacOSXWinCGBounds(TkWindow *winPtr, CGRect *bounds);
MODULE_SCOPE HIShapeRef TkMacOSXGetClipRgn(Drawable drawable);
MODULE_SCOPE void TkMacOSXInvalidateViewRegion(NSView *view,
HIShapeRef rgn);
-MODULE_SCOPE CGContextRef TkMacOSXGetCGContextForDrawable(Drawable drawable);
MODULE_SCOPE NSImage* TkMacOSXGetNSImageFromTkImage(Display *display,
Tk_Image image, int width, int height);
MODULE_SCOPE NSImage* TkMacOSXGetNSImageFromBitmap(Display *display,
@@ -293,7 +294,7 @@ MODULE_SCOPE void TkMacOSXDrawAllViews(ClientData clientData);
MODULE_SCOPE unsigned long TkMacOSXClearPixel(void);
MODULE_SCOPE NSString* TkMacOSXOSTypeToUTI(OSType ostype);
MODULE_SCOPE NSImage* TkMacOSXIconForFileType(NSString *filetype);
-
+
#pragma mark Private Objective-C Classes
#define VISIBILITY_HIDDEN __attribute__((visibility("hidden")))
diff --git a/macosx/tkMacOSXXStubs.c b/macosx/tkMacOSXXStubs.c
index 31eba39..a860bda 100644
--- a/macosx/tkMacOSXXStubs.c
+++ b/macosx/tkMacOSXXStubs.c
@@ -710,7 +710,7 @@ XSync(
* which would then get processed. Apparently this process stabilizes on
* X11, leaving the window manager in a state where all events have been
* generated and no additional events can be genereated by updating widgets.
- *
+ *
* It is not clear what the Aqua port should do when XSync is called, but
* currently the best option seems to be to do nothing. (See ticket
* [da5f2266df].)
@@ -728,7 +728,7 @@ XSetClipRectangles(
int clip_y_origin,
XRectangle* rectangles,
int n,
- int ordering)
+ TCL_UNUSED(int))
{
TkRegion clipRgn = TkCreateRegion();