diff options
author | fvogel <fvogel@noemail.net> | 2016-05-30 18:36:48 (GMT) |
---|---|---|
committer | fvogel <fvogel@noemail.net> | 2016-05-30 18:36:48 (GMT) |
commit | 938999556890c0e4870fc3d43671486c960d0bd7 (patch) | |
tree | c03f283d8eb1c4cf5ca30ce5f4859c92849c691b | |
parent | 90bc5cb8ab0c35cef258452c6bf8027238c8753a (diff) | |
parent | eb9d9fd4106a0e6d16f0e5a5d13109ac8779a458 (diff) | |
download | tk-938999556890c0e4870fc3d43671486c960d0bd7.zip tk-938999556890c0e4870fc3d43671486c960d0bd7.tar.gz tk-938999556890c0e4870fc3d43671486c960d0bd7.tar.bz2 |
Merged TIP #446 accepted by TCT vote. This fixes [
FossilOrigin-Name: 5d3c589c1759b99de672cd1f7887e0a9fb63ff0c
-rw-r--r-- | generic/tkBind.c | 13 | ||||
-rw-r--r-- | tests/bind.test | 12 |
2 files changed, 23 insertions, 2 deletions
diff --git a/generic/tkBind.c b/generic/tkBind.c index c75f6a0..8ee5994 100644 --- a/generic/tkBind.c +++ b/generic/tkBind.c @@ -3535,8 +3535,17 @@ DoWarp( { TkDisplay *dispPtr = clientData; - TkpWarpPointer(dispPtr); - XForceScreenSaver(dispPtr->display, ScreenSaverReset); + /* + * DoWarp was scheduled only if the window was mapped. It needs to be + * still mapped at the time the present idle callback is executed. Also + * one needs to guard against window destruction in the meantime. + */ + + if (Tk_IsMapped(dispPtr->warpWindow) + && (Tk_WindowId(dispPtr->warpWindow) != None)) { + TkpWarpPointer(dispPtr); + XForceScreenSaver(dispPtr->display, ScreenSaverReset); + } dispPtr->flags &= ~TK_DISPLAY_IN_WARP; } diff --git a/tests/bind.test b/tests/bind.test index 0a4d114..9f0caa7 100644 --- a/tests/bind.test +++ b/tests/bind.test @@ -6157,6 +6157,18 @@ test bind-31.7 {virtual event user_data field - unshared, asynch} -setup { destroy .t.f } -result {{} {} {TestUserData >b<}} +test bind-32 {-warp, window was destroyed before the idle callback DoWarp} -setup { + frame .t.f + pack .t.f + focus -force .t.f + update +} -body { + event generate .t.f <Button-1> -warp 1 + destroy .t.f + update ; # shall simply not crash +} -cleanup { +} -result {} + # cleanup cleanupTests |