Getting more systematic about style

Also start removing _ANSI_ARGS_; the core's required ANSI C for a while now
Also fix [Bug 1252702]; size_t doesn't mix with Tcl_GetStringFromObj

1 files changed, 363 insertions, 412 deletions

diff --git a/generic/tkImage.c b/generic/tkImage.c
index 476662b..570d39f 100644
--- a/generic/tkImage.c
+++ b/generic/tkImage.c
@@ -1,17 +1,16 @@
-/* 
+/*
  * tkImage.c --
  *
- *	This module implements the image protocol, which allows lots
- *	of different kinds of images to be used in lots of different
- *	widgets.
+ *	This module implements the image protocol, which allows lots of
+ *	different kinds of images to be used in lots of different widgets.
  *
  * Copyright (c) 1994 The Regents of the University of California.
  * Copyright (c) 1994-1997 Sun Microsystems, Inc.
  *
- * See the file "license.terms" for information on usage and redistribution
- * of this file, and for a DISCLAIMER OF ALL WARRANTIES.
+ * See the file "license.terms" for information on usage and redistribution of
+ * this file, and for a DISCLAIMER OF ALL WARRANTIES.
  *
- * RCS: @(#) $Id: tkImage.c,v 1.22 2003/09/17 23:45:35 dgp Exp $
+ * RCS: @(#) $Id: tkImage.c,v 1.23 2005/08/10 22:02:22 dkf Exp $
  */
 
 #include "tkInt.h"
@@ -27,96 +26,93 @@ typedef struct Image {
     Tk_Window tkwin;		/* Window passed to Tk_GetImage (needed to
 				 * "re-get" the image later if the manager
 				 * changes). */
-    Display *display;		/* Display for tkwin.  Needed because when
-				 * the image is eventually freed tkwin may
-				 * not exist anymore. */
+    Display *display;		/* Display for tkwin. Needed because when the
+				 * image is eventually freed tkwin may not
+				 * exist anymore. */
     struct ImageMaster *masterPtr;
 				/* Master for this image (identifiers image
 				 * manager, for example). */
-    ClientData instanceData;
-				/* One word argument to pass to image manager
+    ClientData instanceData;	/* One word argument to pass to image manager
 				 * when dealing with this image instance. */
     Tk_ImageChangedProc *changeProc;
 				/* Code in widget to call when image changes
 				 * in a way that affects redisplay. */
-    ClientData widgetClientData;
-				/* Argument to pass to changeProc. */
+    ClientData widgetClientData;/* Argument to pass to changeProc. */
     struct Image *nextPtr;	/* Next in list of all image instances
 				 * associated with the same name. */
-
 } Image;
 
 /*
- * For each image master there is one of the following structures,
- * which represents a name in the image table and all of the images
- * instantiated from it.  Entries in mainPtr->imageTable point to
- * these structures.
+ * For each image master there is one of the following structures, which
+ * represents a name in the image table and all of the images instantiated
+ * from it. Entries in mainPtr->imageTable point to these structures.
  */
 
 typedef struct ImageMaster {
-    Tk_ImageType *typePtr;	/* Information about image type.  NULL means
-				 * that no image manager owns this image:  the
+    Tk_ImageType *typePtr;	/* Information about image type. NULL means
+				 * that no image manager owns this image: the
 				 * image was deleted. */
-    ClientData masterData;	/* One-word argument to pass to image mgr
-				 * when dealing with the master, as opposed
-				 * to instances. */
+    ClientData masterData;	/* One-word argument to pass to image mgr when
+				 * dealing with the master, as opposed to
+				 * instances. */
     int width, height;		/* Last known dimensions for image. */
-    Tcl_HashTable *tablePtr;	/* Pointer to hash table containing image
-				 * (the imageTable field in some TkMainInfo
+    Tcl_HashTable *tablePtr;	/* Pointer to hash table containing image (the
+				 * imageTable field in some TkMainInfo
 				 * structure). */
-    Tcl_HashEntry *hPtr;	/* Hash entry in mainPtr->imageTable for
-				 * this structure (used to delete the hash
+    Tcl_HashEntry *hPtr;	/* Hash entry in mainPtr->imageTable for this
+				 * structure (used to delete the hash
 				 * entry). */
     Image *instancePtr;		/* Pointer to first in list of instances
 				 * derived from this name. */
     int deleted;		/* Flag set when image is being deleted. */
-    TkWindow *winPtr;		/* Main window of interpreter (used to
-				 * detect when the world is falling apart.) */
+    TkWindow *winPtr;		/* Main window of interpreter (used to detect
+				 * when the world is falling apart.) */
 } ImageMaster;
 
 typedef struct ThreadSpecificData {
-    Tk_ImageType *imageTypeList;/* First in a list of all known image 
-				 * types. */  
-    Tk_ImageType *oldImageTypeList;/* First in a list of all known old-style image 
-				 * types. */  
-} ThreadSpecificData;           
+    Tk_ImageType *imageTypeList;/* First in a list of all known image
+				 * types. */
+    Tk_ImageType *oldImageTypeList;
+				/* First in a list of all known old-style
+				 * image types. */
+} ThreadSpecificData;
 static Tcl_ThreadDataKey dataKey;
 
 /*
- * Prototypes for local procedures:
+ * Prototypes for local functions:
  */
 
-static void	DeleteImage _ANSI_ARGS_((ImageMaster *masterPtr));
-static void	EventuallyDeleteImage _ANSI_ARGS_((ImageMaster *masterPtr,
-				int forgetImageHashNow));
+static void		DeleteImage(ImageMaster *masterPtr);
+static void		EventuallyDeleteImage(ImageMaster *masterPtr,
+			    int forgetImageHashNow);
 
 /*
  *----------------------------------------------------------------------
  *
  * Tk_CreateOldImageType, Tk_CreateImageType --
  *
- *	This procedure is invoked by an image manager to tell Tk about
- *	a new kind of image and the procedures that manage the new type.
- *	The procedure is typically invoked during Tcl_AppInit.
+ *	This function is invoked by an image manager to tell Tk about a new
+ *	kind of image and the functions that manage the new type. The function
+ *	is typically invoked during Tcl_AppInit.
  *
  * Results:
  *	None.
  *
  * Side effects:
- *	The new image type is entered into a table used in the "image
- *	create" command.
+ *	The new image type is entered into a table used in the "image create"
+ *	command.
  *
  *----------------------------------------------------------------------
  */
 
 void
 Tk_CreateOldImageType(typePtr)
-    Tk_ImageType *typePtr;	/* Structure describing the type.  All of
-				 * the fields except "nextPtr" must be filled
-				 * in by caller.  Must not have been passed
-				 * to Tk_CreateImageType previously. */
+    Tk_ImageType *typePtr;	/* Structure describing the type. All of the
+				 * fields except "nextPtr" must be filled in
+				 * by caller. Must not have been passed to
+				 * Tk_CreateImageType previously. */
 {
-    ThreadSpecificData *tsdPtr = (ThreadSpecificData *) 
+    ThreadSpecificData *tsdPtr = (ThreadSpecificData *)
             Tcl_GetThreadData(&dataKey, sizeof(ThreadSpecificData));
 
     typePtr->nextPtr = tsdPtr->oldImageTypeList;
@@ -125,12 +121,12 @@ Tk_CreateOldImageType(typePtr)
 
 void
 Tk_CreateImageType(typePtr)
-    Tk_ImageType *typePtr;	/* Structure describing the type.  All of
-				 * the fields except "nextPtr" must be filled
-				 * in by caller.  Must not have been passed
-				 * to Tk_CreateImageType previously. */
+    Tk_ImageType *typePtr;	/* Structure describing the type. All of the
+				 * fields except "nextPtr" must be filled in
+				 * by caller. Must not have been passed to
+				 * Tk_CreateImageType previously. */
 {
-    ThreadSpecificData *tsdPtr = (ThreadSpecificData *) 
+    ThreadSpecificData *tsdPtr = (ThreadSpecificData *)
             Tcl_GetThreadData(&dataKey, sizeof(ThreadSpecificData));
 
     typePtr->nextPtr = tsdPtr->imageTypeList;
@@ -142,8 +138,8 @@ Tk_CreateImageType(typePtr)
  *
  * Tk_ImageObjCmd --
  *
- *	This procedure is invoked to process the "image" Tcl command.
- *	See the user documentation for details on what it does.
+ *	This function is invoked to process the "image" Tcl command. See the
+ *	user documentation for details on what it does.
  *
  * Results:
  *	A standard Tcl result.
@@ -163,7 +159,7 @@ Tk_ImageObjCmd(clientData, interp, objc, objv)
 {
     static CONST char *imageOptions[] = {
 	"create", "delete", "height", "inuse", "names", "type", "types",
-	    "width", (char *) NULL
+	"width", (char *) NULL
     };
     enum options {
 	IMAGE_CREATE, IMAGE_DELETE, IMAGE_HEIGHT, IMAGE_INUSE, IMAGE_NAMES,
@@ -178,7 +174,8 @@ Tk_ImageObjCmd(clientData, interp, objc, objv)
     Tcl_HashSearch search;
     char idString[16 + TCL_INTEGER_SPACE], *name;
     TkDisplay *dispPtr = winPtr->dispPtr;
-    ThreadSpecificData *tsdPtr = (ThreadSpecificData *) 
+    CONST char *arg;
+    ThreadSpecificData *tsdPtr = (ThreadSpecificData *)
             Tcl_GetThreadData(&dataKey, sizeof(ThreadSpecificData));
 
     if (objc < 2) {
@@ -191,302 +188,254 @@ Tk_ImageObjCmd(clientData, interp, objc, objv)
 	return TCL_ERROR;
     }
     switch ((enum options) index) {
-	case IMAGE_CREATE: {
-	    char *arg;
-	    Tcl_Obj **args;
-	    int oldimage = 0;
-	    if (objc < 3) {
-		Tcl_WrongNumArgs(interp, 2, objv, "type ?name? ?options?");
-		return TCL_ERROR;
-	    }
+    case IMAGE_CREATE: {
+	Tcl_Obj **args;
+	int oldimage = 0;
+	if (objc < 3) {
+	    Tcl_WrongNumArgs(interp, 2, objv, "type ?name? ?options?");
+	    return TCL_ERROR;
+	}
 
-	    /*
-	     * Look up the image type.
-	     */
+	/*
+	 * Look up the image type.
+	 */
 
-	    arg = Tcl_GetString(objv[2]);
-	    for (typePtr = tsdPtr->imageTypeList; typePtr != NULL;
-		 typePtr = typePtr->nextPtr) {
+	arg = Tcl_GetString(objv[2]);
+	for (typePtr = tsdPtr->imageTypeList; typePtr != NULL;
+		typePtr = typePtr->nextPtr) {
+	    if ((*arg == typePtr->name[0])
+		    && (strcmp(arg, typePtr->name) == 0)) {
+		break;
+	    }
+	}
+	if (typePtr == NULL) {
+	    oldimage = 1;
+	    for (typePtr = tsdPtr->oldImageTypeList; typePtr != NULL;
+		    typePtr = typePtr->nextPtr) {
 		if ((*arg == typePtr->name[0])
 			&& (strcmp(arg, typePtr->name) == 0)) {
 		    break;
 		}
 	    }
-	    if (typePtr == NULL) {
-		oldimage = 1;
-		for (typePtr = tsdPtr->oldImageTypeList; typePtr != NULL;
-		     typePtr = typePtr->nextPtr) {
-		    if ((*arg == typePtr->name[0])
-			    && (strcmp(arg, typePtr->name) == 0)) {
-			break;
-		    }
-		}
-	    }
-	    if (typePtr == NULL) {
-		Tcl_AppendResult(interp, "image type \"", arg,
-			"\" doesn't exist", (char *) NULL);
-		return TCL_ERROR;
-	    }
+	}
+	if (typePtr == NULL) {
+	    Tcl_AppendResult(interp, "image type \"", arg, "\" doesn't exist",
+		    (char *) NULL);
+	    return TCL_ERROR;
+	}
 
-	    /*
-	     * Figure out a name to use for the new image.
-	     */
+	/*
+	 * Figure out a name to use for the new image.
+	 */
 
-	    if ((objc == 3) || (*(arg = Tcl_GetString(objv[3])) == '-')) {
-                Tcl_CmdInfo dummy;
-                do {
-		    dispPtr->imageId++;
-		    sprintf(idString, "image%d", dispPtr->imageId);
-		    name = idString;
-                } while (Tcl_GetCommandInfo(interp, name, &dummy) != 0);
-		firstOption = 3;
-	    } else {
-		TkWindow *topWin;
-
-		name = arg;
-		firstOption = 4;
-		/*
-		 * Need to check if the _command_ that we are about to
-		 * create is the name of the current master widget
-		 * command (normally "." but could have been renamed)
-		 * and fail in that case before a really nasty and
-		 * hard to stop crash happens.
-		 */
-		topWin = (TkWindow *) TkToplevelWindowForCommand(interp, name);
-		if (topWin != NULL && winPtr->mainPtr->winPtr == topWin) {
-		    Tcl_AppendResult(interp, "images may not be named the ",
-			    "same as the main window", (char *) NULL);
-		    return TCL_ERROR;
-		}
-	    }
+	if ((objc == 3) || (*(arg = Tcl_GetString(objv[3])) == '-')) {
+	    Tcl_CmdInfo dummy;
+	    do {
+		dispPtr->imageId++;
+		sprintf(idString, "image%d", dispPtr->imageId);
+		name = idString;
+	    } while (Tcl_GetCommandInfo(interp, name, &dummy) != 0);
+	    firstOption = 3;
+	} else {
+	    TkWindow *topWin;
+
+	    name = arg;
+	    firstOption = 4;
 
 	    /*
-	     * Create the data structure for the new image.
+	     * Need to check if the _command_ that we are about to create is
+	     * the name of the current master widget command (normally "." but
+	     * could have been renamed) and fail in that case before a really
+	     * nasty and hard to stop crash happens.
 	     */
 
-	    hPtr = Tcl_CreateHashEntry(&winPtr->mainPtr->imageTable,
-		    name, &new);
-	    if (new) {
-		masterPtr = (ImageMaster *) ckalloc(sizeof(ImageMaster));
-		masterPtr->typePtr = NULL;
-		masterPtr->masterData = NULL;
-		masterPtr->width = masterPtr->height = 1;
-		masterPtr->tablePtr = &winPtr->mainPtr->imageTable;
-		masterPtr->hPtr = hPtr;
-		masterPtr->instancePtr = NULL;
-		masterPtr->deleted = 0;
-		masterPtr->winPtr = winPtr->mainPtr->winPtr;
-		Tcl_Preserve((ClientData) masterPtr->winPtr);
-		Tcl_SetHashValue(hPtr, masterPtr);
-	    } else {
-		/*
-		 * An image already exists by this name.  Disconnect the
-		 * instances from the master.
-		 */
-
-		masterPtr = (ImageMaster *) Tcl_GetHashValue(hPtr);
-		if (masterPtr->typePtr != NULL) {
-		    for (imagePtr = masterPtr->instancePtr; imagePtr != NULL;
-			 imagePtr = imagePtr->nextPtr) {
-			(*masterPtr->typePtr->freeProc)(
-			    imagePtr->instanceData, imagePtr->display);
-			(*imagePtr->changeProc)(imagePtr->widgetClientData,
-				0, 0, masterPtr->width, masterPtr->height,
-				masterPtr->width, masterPtr->height);
-		    }
-		    (*masterPtr->typePtr->deleteProc)(masterPtr->masterData);
-		    masterPtr->typePtr = NULL;
-		}
-		masterPtr->deleted = 0;
+	    topWin = (TkWindow *) TkToplevelWindowForCommand(interp, name);
+	    if (topWin != NULL && winPtr->mainPtr->winPtr == topWin) {
+		Tcl_AppendResult(interp, "images may not be named the ",
+			"same as the main window", (char *) NULL);
+		return TCL_ERROR;
 	    }
+	}
 
+	/*
+	 * Create the data structure for the new image.
+	 */
+
+	hPtr = Tcl_CreateHashEntry(&winPtr->mainPtr->imageTable, name, &new);
+	if (new) {
+	    masterPtr = (ImageMaster *) ckalloc(sizeof(ImageMaster));
+	    masterPtr->typePtr = NULL;
+	    masterPtr->masterData = NULL;
+	    masterPtr->width = masterPtr->height = 1;
+	    masterPtr->tablePtr = &winPtr->mainPtr->imageTable;
+	    masterPtr->hPtr = hPtr;
+	    masterPtr->instancePtr = NULL;
+	    masterPtr->deleted = 0;
+	    masterPtr->winPtr = winPtr->mainPtr->winPtr;
+	    Tcl_Preserve((ClientData) masterPtr->winPtr);
+	    Tcl_SetHashValue(hPtr, masterPtr);
+	} else {
 	    /*
-	     * Call the image type manager so that it can perform its own
-	     * initialization, then re-"get" for any existing instances of
-	     * the image.
+	     * An image already exists by this name. Disconnect the instances
+	     * from the master.
 	     */
 
-	    objv += firstOption;
-	    objc -= firstOption;
-	    args = (Tcl_Obj **) objv;
-	    if (oldimage) {
-		int i;
-		args = (Tcl_Obj **) ckalloc((objc+1) * sizeof(char *));
-		for (i = 0; i < objc; i++) {
-		    args[i] = (Tcl_Obj *) Tcl_GetString(objv[i]);
+	    masterPtr = (ImageMaster *) Tcl_GetHashValue(hPtr);
+	    if (masterPtr->typePtr != NULL) {
+		for (imagePtr = masterPtr->instancePtr; imagePtr != NULL;
+			imagePtr = imagePtr->nextPtr) {
+		    (*masterPtr->typePtr->freeProc)(imagePtr->instanceData,
+			    imagePtr->display);
+		    (*imagePtr->changeProc)(imagePtr->widgetClientData,
+			    0, 0, masterPtr->width, masterPtr->height,
+			    masterPtr->width, masterPtr->height);
 		}
-		args[objc] = NULL;
+		(*masterPtr->typePtr->deleteProc)(masterPtr->masterData);
+		masterPtr->typePtr = NULL;
 	    }
-	    Tcl_Preserve((ClientData) masterPtr);
-	    if ((*typePtr->createProc)(interp, name, objc,
-		    args, typePtr, (Tk_ImageMaster) masterPtr,
-		    &masterPtr->masterData) != TCL_OK) {
-		EventuallyDeleteImage(masterPtr, 0);
-		Tcl_Release((ClientData) masterPtr);
-		if (oldimage) {
-		    ckfree((char *) args);
-		}
-		return TCL_ERROR;
+	    masterPtr->deleted = 0;
+	}
+
+	/*
+	 * Call the image type manager so that it can perform its own
+	 * initialization, then re-"get" for any existing instances of the
+	 * image.
+	 */
+
+	objv += firstOption;
+	objc -= firstOption;
+	args = (Tcl_Obj **) objv;
+	if (oldimage) {
+	    int i;
+
+	    args = (Tcl_Obj **) ckalloc((objc+1) * sizeof(char *));
+	    for (i = 0; i < objc; i++) {
+		args[i] = (Tcl_Obj *) Tcl_GetString(objv[i]);
 	    }
+	    args[objc] = NULL;
+	}
+	Tcl_Preserve((ClientData) masterPtr);
+	if ((*typePtr->createProc)(interp, name, objc, args, typePtr,
+		(Tk_ImageMaster)masterPtr, &masterPtr->masterData) != TCL_OK) {
+	    EventuallyDeleteImage(masterPtr, 0);
 	    Tcl_Release((ClientData) masterPtr);
 	    if (oldimage) {
 		ckfree((char *) args);
 	    }
-	    masterPtr->typePtr = typePtr;
-	    for (imagePtr = masterPtr->instancePtr; imagePtr != NULL;
-		 imagePtr = imagePtr->nextPtr) {
-		imagePtr->instanceData = (*typePtr->getProc)(
-		    imagePtr->tkwin, masterPtr->masterData);
-	    }
-	    Tcl_SetResult(interp,
-		    Tcl_GetHashKey(&winPtr->mainPtr->imageTable, hPtr),
-		    TCL_STATIC);
-	    break;
+	    return TCL_ERROR;
 	}
-	case IMAGE_DELETE: {
-	    for (i = 2; i < objc; i++) {
-		char *arg = Tcl_GetString(objv[i]);
-		hPtr = Tcl_FindHashEntry(&winPtr->mainPtr->imageTable, arg);
-		if (hPtr == NULL) {
-		  deleteAlreadyDeleted:
-		    Tcl_AppendResult(interp, "image \"", arg,
-			    "\" doesn't exist", (char *) NULL);
-		    return TCL_ERROR;
-		}
-		masterPtr = (ImageMaster *) Tcl_GetHashValue(hPtr);
-		if (masterPtr->deleted) {
-		    goto deleteAlreadyDeleted;
-		}
-		DeleteImage(masterPtr);
-	    }
-	    break;
+	Tcl_Release((ClientData) masterPtr);
+	if (oldimage) {
+	    ckfree((char *) args);
 	}
-	case IMAGE_HEIGHT: {	
-	    char *arg;
-	    if (objc != 3) {
-		Tcl_WrongNumArgs(interp, 2, objv, "name");
-		return TCL_ERROR;
-	    }
-	    arg = Tcl_GetString(objv[2]);
+	masterPtr->typePtr = typePtr;
+	for (imagePtr = masterPtr->instancePtr; imagePtr != NULL;
+		imagePtr = imagePtr->nextPtr) {
+	    imagePtr->instanceData = (*typePtr->getProc)(imagePtr->tkwin,
+		    masterPtr->masterData);
+	}
+	Tcl_SetResult(interp,
+		Tcl_GetHashKey(&winPtr->mainPtr->imageTable, hPtr),
+		TCL_STATIC);
+	break;
+    }
+    case IMAGE_DELETE:
+	for (i = 2; i < objc; i++) {
+	    arg = Tcl_GetString(objv[i]);
 	    hPtr = Tcl_FindHashEntry(&winPtr->mainPtr->imageTable, arg);
 	    if (hPtr == NULL) {
-	      heightAlreadyDeleted:
-		Tcl_AppendResult(interp, "image \"", arg,
-			"\" doesn't exist", (char *) NULL);
-		return TCL_ERROR;
+		goto alreadyDeleted;
 	    }
 	    masterPtr = (ImageMaster *) Tcl_GetHashValue(hPtr);
 	    if (masterPtr->deleted) {
-		goto heightAlreadyDeleted;
+		goto alreadyDeleted;
 	    }
-	    Tcl_SetIntObj(Tcl_GetObjResult(interp), masterPtr->height);
-	    break;
+	    DeleteImage(masterPtr);
 	}
-
-	case IMAGE_INUSE: {
-	    int count = 0;
-	    char *arg;
-	    if (objc != 3) {
-		Tcl_WrongNumArgs(interp, 2, objv, "name");
-		return TCL_ERROR;
-	    }
-	    arg = Tcl_GetString(objv[2]);
-	    hPtr = Tcl_FindHashEntry(&winPtr->mainPtr->imageTable, arg);
-	    if (hPtr == NULL) {
-	      inuseAlreadyDeleted:
-		Tcl_AppendResult(interp, "image \"", arg,
-			"\" doesn't exist", (char *) NULL);
-		return TCL_ERROR;
-	    }
+	break;
+    case IMAGE_NAMES:
+	if (objc != 2) {
+	    Tcl_WrongNumArgs(interp, 2, objv, NULL);
+	    return TCL_ERROR;
+	}
+	hPtr = Tcl_FirstHashEntry(&winPtr->mainPtr->imageTable, &search);
+	for ( ; hPtr != NULL; hPtr = Tcl_NextHashEntry(&search)) {
 	    masterPtr = (ImageMaster *) Tcl_GetHashValue(hPtr);
 	    if (masterPtr->deleted) {
-		goto inuseAlreadyDeleted;
+		continue;
 	    }
-	    if (masterPtr->typePtr != NULL && masterPtr->instancePtr != NULL) {
-		count = 1;
-	    }
-	    Tcl_SetBooleanObj(Tcl_GetObjResult(interp), count);
-	    break;
+	    Tcl_AppendElement(interp, Tcl_GetHashKey(
+		    &winPtr->mainPtr->imageTable, hPtr));
+	}
+	break;
+    case IMAGE_TYPES:
+	if (objc != 2) {
+	    Tcl_WrongNumArgs(interp, 2, objv, NULL);
+	    return TCL_ERROR;
+	}
+	for (typePtr = tsdPtr->imageTypeList; typePtr != NULL;
+		typePtr = typePtr->nextPtr) {
+	    Tcl_AppendElement(interp, typePtr->name);
+	}
+	for (typePtr = tsdPtr->oldImageTypeList; typePtr != NULL;
+		typePtr = typePtr->nextPtr) {
+	    Tcl_AppendElement(interp, typePtr->name);
 	}
+	break;
 
-	case IMAGE_NAMES: {
-	    if (objc != 2) {
-		Tcl_WrongNumArgs(interp, 2, objv, NULL);
-		return TCL_ERROR;
-	    }
-	    hPtr = Tcl_FirstHashEntry(&winPtr->mainPtr->imageTable, &search);
-	    for ( ; hPtr != NULL; hPtr = Tcl_NextHashEntry(&search)) {
-		masterPtr = (ImageMaster *) Tcl_GetHashValue(hPtr);
-		if (masterPtr->deleted) {
-		    continue;
-		}
-		Tcl_AppendElement(interp, Tcl_GetHashKey(
-		    &winPtr->mainPtr->imageTable, hPtr));
-	    }
-	    break;
+    case IMAGE_HEIGHT:
+    case IMAGE_INUSE:
+    case IMAGE_TYPE:
+    case IMAGE_WIDTH:
+	/*
+	 * These operations all parse virtually identically. First check to
+	 * see if three args are given. Then get a non-deleted master from the
+	 * third arg.
+	 */
+
+	if (objc != 3) {
+	    Tcl_WrongNumArgs(interp, 2, objv, "name");
+	    return TCL_ERROR;
 	}
-	
-	case IMAGE_TYPE: {
-	    char *arg;
-	    if (objc != 3) {
-		Tcl_WrongNumArgs(interp, 2, objv, "name");
-		return TCL_ERROR;
-	    }
-	    arg = Tcl_GetString(objv[2]);
-	    hPtr = Tcl_FindHashEntry(&winPtr->mainPtr->imageTable, arg);
-	    if (hPtr == NULL) {
-	      typeAlreadyDeleted:
-		Tcl_AppendResult(interp, "image \"", arg,
-			"\" doesn't exist", (char *) NULL);
-		return TCL_ERROR;
-	    }
-	    masterPtr = (ImageMaster *) Tcl_GetHashValue(hPtr);
-	    if (masterPtr->deleted) {
-		goto typeAlreadyDeleted;
-	    }
+
+	arg = Tcl_GetString(objv[2]);
+	hPtr = Tcl_FindHashEntry(&winPtr->mainPtr->imageTable, arg);
+	if (hPtr == NULL) {
+	    goto alreadyDeleted;
+	}
+	masterPtr = (ImageMaster *) Tcl_GetHashValue(hPtr);
+	if (masterPtr->deleted) {
+	    goto alreadyDeleted;
+	}
+
+	/*
+	 * Now we read off the specific piece of data we were asked for.
+	 */
+
+	switch ((enum options) index) {
+	case IMAGE_HEIGHT:
+	    Tcl_SetIntObj(Tcl_GetObjResult(interp), masterPtr->height);
+	    break;
+	case IMAGE_INUSE:
+	    Tcl_SetBooleanObj(Tcl_GetObjResult(interp),
+		    masterPtr->typePtr!=NULL && masterPtr->instancePtr!=NULL);
+	    break;
+	case IMAGE_TYPE:
 	    if (masterPtr->typePtr != NULL) {
 		Tcl_SetResult(interp, masterPtr->typePtr->name, TCL_STATIC);
 	    }
 	    break;
-	}
-	case IMAGE_TYPES: {
-	    if (objc != 2) {
-		Tcl_WrongNumArgs(interp, 2, objv, NULL);
-		return TCL_ERROR;
-	    }
-	    for (typePtr = tsdPtr->imageTypeList; typePtr != NULL;
-		 typePtr = typePtr->nextPtr) {
-		Tcl_AppendElement(interp, typePtr->name);
-	    }
-	    for (typePtr = tsdPtr->oldImageTypeList; typePtr != NULL;
-		 typePtr = typePtr->nextPtr) {
-		Tcl_AppendElement(interp, typePtr->name);
-	    }
-	    break;
-	}
-	case IMAGE_WIDTH: {
-	    char *arg;
-	    if (objc != 3) {
-		Tcl_WrongNumArgs(interp, 2, objv, "name");
-		return TCL_ERROR;
-	    }
-	    arg = Tcl_GetString(objv[2]);
-	    hPtr = Tcl_FindHashEntry(&winPtr->mainPtr->imageTable, arg);
-	    if (hPtr == NULL) {
-	      widthAlreadyDeleted:
-		Tcl_AppendResult(interp, "image \"", arg,
-			"\" doesn't exist", (char *) NULL);
-		return TCL_ERROR;
-	    }
-	    masterPtr = (ImageMaster *) Tcl_GetHashValue(hPtr);
-	    if (masterPtr->deleted) {
-		goto widthAlreadyDeleted;
-	    }
+	case IMAGE_WIDTH:
 	    Tcl_SetIntObj(Tcl_GetObjResult(interp), masterPtr->width);
 	    break;
 	}
+	break;
     }
     return TCL_OK;
+
+  alreadyDeleted:
+    Tcl_AppendResult(interp, "image \"",arg,"\" doesn't exist", (char *) NULL);
+    return TCL_ERROR;
 }
 
 /*
@@ -494,32 +443,30 @@ Tk_ImageObjCmd(clientData, interp, objc, objv)
  *
  * Tk_ImageChanged --
  *
- *	This procedure is called by an image manager whenever something
- *	has happened that requires the image to be redrawn (some of its
- *	pixels have changed, or its size has changed).
+ *	This function is called by an image manager whenever something has
+ *	happened that requires the image to be redrawn (some of its pixels
+ *	have changed, or its size has changed).
  *
  * Results:
  *	None.
  *
  * Side effects:
- *	Any widgets that display the image are notified so that they
- *	can redisplay themselves as appropriate.
+ *	Any widgets that display the image are notified so that they can
+ *	redisplay themselves as appropriate.
  *
  *----------------------------------------------------------------------
  */
 
 void
-Tk_ImageChanged(imageMaster, x, y, width, height, imageWidth,
-	imageHeight)
+Tk_ImageChanged(imageMaster, x, y, width, height, imageWidth, imageHeight)
     Tk_ImageMaster imageMaster;	/* Image that needs redisplay. */
-    int x, y;			/* Coordinates of upper-left pixel of
-				 * region of image that needs to be
-				 * redrawn. */
-    int width, height;		/* Dimensions (in pixels) of region of
-				 * image to redraw.  If either dimension
-				 * is zero then the image doesn't need to
-				 * be redrawn (perhaps all that happened is
-				 * that its size changed). */
+    int x, y;			/* Coordinates of upper-left pixel of region
+				 * of image that needs to be redrawn. */
+    int width, height;		/* Dimensions (in pixels) of region of image
+				 * to redraw. If either dimension is zero then
+				 * the image doesn't need to be redrawn
+				 * (perhaps all that happened is that its size
+				 * changed). */
     int imageWidth, imageHeight;/* New dimensions of image. */
 {
     ImageMaster *masterPtr = (ImageMaster *) imageMaster;
@@ -528,7 +475,7 @@ Tk_ImageChanged(imageMaster, x, y, width, height, imageWidth,
     masterPtr->width = imageWidth;
     masterPtr->height = imageHeight;
     for (imagePtr = masterPtr->instancePtr; imagePtr != NULL;
-	 imagePtr = imagePtr->nextPtr) {
+	    imagePtr = imagePtr->nextPtr) {
 	(*imagePtr->changeProc)(imagePtr->widgetClientData, x, y,
 		width, height, imageWidth, imageHeight);
     }
@@ -539,8 +486,8 @@ Tk_ImageChanged(imageMaster, x, y, width, height, imageWidth,
  *
  * Tk_NameOfImage --
  *
- *	Given a token for an image master, this procedure returns
- *	the name of the image.
+ *	Given a token for an image master, this function returns the name of
+ *	the image.
  *
  * Results:
  *	The return value is the string name for imageMaster.
@@ -553,7 +500,7 @@ Tk_ImageChanged(imageMaster, x, y, width, height, imageWidth,
 
 CONST char *
 Tk_NameOfImage(imageMaster)
-    Tk_ImageMaster imageMaster;		/* Token for image. */
+    Tk_ImageMaster imageMaster;	/* Token for image. */
 {
     ImageMaster *masterPtr = (ImageMaster *) imageMaster;
 
@@ -568,35 +515,33 @@ Tk_NameOfImage(imageMaster)
  *
  * Tk_GetImage --
  *
- *	This procedure is invoked by a widget when it wants to use
- *	a particular image in a particular window.
+ *	This function is invoked by a widget when it wants to use a particular
+ *	image in a particular window.
  *
  * Results:
- *	The return value is a token for the image.  If there is no image
- *	by the given name, then NULL is returned and an error message is
- *	left in the interp's result.
+ *	The return value is a token for the image. If there is no image by the
+ *	given name, then NULL is returned and an error message is left in the
+ *	interp's result.
  *
  * Side effects:
- *	Tk records the fact that the widget is using the image, and
- *	it will invoke changeProc later if the widget needs redisplay
- *	(i.e. its size changes or some of its pixels change).  The
- *	caller must eventually invoke Tk_FreeImage when it no longer
- *	needs the image.
+ *	Tk records the fact that the widget is using the image, and it will
+ *	invoke changeProc later if the widget needs redisplay (i.e. its size
+ *	changes or some of its pixels change). The caller must eventually
+ *	invoke Tk_FreeImage when it no longer needs the image.
  *
  *----------------------------------------------------------------------
  */
 
 Tk_Image
 Tk_GetImage(interp, tkwin, name, changeProc, clientData)
-    Tcl_Interp *interp;		/* Place to leave error message if image
-				 * can't be found. */
-    Tk_Window tkwin;		/* Token for window in which image will
-				 * be used. */
+    Tcl_Interp *interp;		/* Place to leave error message if image can't
+				 * be found. */
+    Tk_Window tkwin;		/* Token for window in which image will be
+				 * used. */
     CONST char *name;		/* Name of desired image. */
     Tk_ImageChangedProc *changeProc;
-				/* Procedure to invoke when redisplay is
-				 * needed because image's pixels or size
-				 * changed. */
+				/* Function to invoke when redisplay is needed
+				 * because image's pixels or size changed. */
     ClientData clientData;	/* One-word argument to pass to damageProc. */
 {
     Tcl_HashEntry *hPtr;
@@ -626,7 +571,7 @@ Tk_GetImage(interp, tkwin, name, changeProc, clientData)
     masterPtr->instancePtr = imagePtr;
     return (Tk_Image) imagePtr;
 
-    noSuchImage:
+  noSuchImage:
     Tcl_AppendResult(interp, "image \"", name, "\" doesn't exist",
 	    (char *) NULL);
     return NULL;
@@ -637,9 +582,9 @@ Tk_GetImage(interp, tkwin, name, changeProc, clientData)
  *
  * Tk_FreeImage --
  *
- *	This procedure is invoked by a widget when it no longer needs
- *	an image acquired by a previous call to Tk_GetImage.  For each
- *	call to Tk_GetImage there must be exactly one call to Tk_FreeImage.
+ *	This function is invoked by a widget when it no longer needs an image
+ *	acquired by a previous call to Tk_GetImage. For each call to
+ *	Tk_GetImage there must be exactly one call to Tk_FreeImage.
  *
  * Results:
  *	None.
@@ -652,8 +597,8 @@ Tk_GetImage(interp, tkwin, name, changeProc, clientData)
 
 void
 Tk_FreeImage(image)
-    Tk_Image image;		/* Token for image that is no longer
-				 * needed by a widget. */
+    Tk_Image image;		/* Token for image that is no longer needed by
+				 * a widget. */
 {
     Image *imagePtr = (Image *) image;
     ImageMaster *masterPtr = imagePtr->masterPtr;
@@ -678,9 +623,9 @@ Tk_FreeImage(image)
     }
     ckfree((char *) imagePtr);
 
-    /* 
-     * If there are no more instances left for the master, and if the
-     * master image has been deleted, then delete the master too.
+    /*
+     * If there are no more instances left for the master, and if the master
+     * image has been deleted, then delete the master too.
      */
 
     if ((masterPtr->typePtr == NULL) && (masterPtr->instancePtr == NULL)) {
@@ -697,15 +642,15 @@ Tk_FreeImage(image)
  *
  * Tk_PostscriptImage --
  *
- *	This procedure is called by widgets that contain images in order
- *	to redisplay an image on the screen or an off-screen pixmap.
+ *	This function is called by widgets that contain images in order to
+ *	redisplay an image on the screen or an off-screen pixmap.
  *
  * Results:
  *	None.
  *
  * Side effects:
- *	The image's manager is notified, and it redraws the desired
- *	portion of the image before returning.
+ *	The image's manager is notified, and it redraws the desired portion of
+ *	the image before returning.
  *
  *----------------------------------------------------------------------
  */
@@ -732,12 +677,13 @@ Tk_PostscriptImage(image, interp, tkwin, psinfo, x, y, width, height, prepass)
 	/*
 	 * No master for image, so nothing to display on postscript.
 	 */
+
 	return TCL_OK;
     }
 
     /*
-     * Check if an image specific postscript-generation function
-     * exists; otherwise go on with generic code.
+     * Check if an image specific postscript-generation function exists;
+     * otherwise go on with generic code.
      */
 
     if (imagePtr->masterPtr->typePtr->postscriptProc != NULL) {
@@ -752,12 +698,12 @@ Tk_PostscriptImage(image, interp, tkwin, psinfo, x, y, width, height, prepass)
 
     /*
      * Create a Pixmap, tell the image to redraw itself there, and then
-     * generate an XImage from the Pixmap.  We can then read pixel 
-     * values out of the XImage.
+     * generate an XImage from the Pixmap. We can then read pixel values out
+     * of the XImage.
      */
 
-    pmap = Tk_GetPixmap(Tk_Display(tkwin), Tk_WindowId(tkwin),
-                        width, height, Tk_Depth(tkwin));
+    pmap = Tk_GetPixmap(Tk_Display(tkwin), Tk_WindowId(tkwin), width, height,
+	    Tk_Depth(tkwin));
 
     gcValues.foreground = WhitePixelOfScreen(Tk_Screen(tkwin));
     newGC = Tk_GetGC(tkwin, GCForeground, &gcValues);
@@ -773,11 +719,13 @@ Tk_PostscriptImage(image, interp, tkwin, psinfo, x, y, width, height, prepass)
 	    (unsigned int)width, (unsigned int)height, AllPlanes, ZPixmap);
 
     Tk_FreePixmap(Tk_Display(tkwin), pmap);
-    
+
     if (ximage == NULL) {
-	/* The XGetImage() function is apparently not
-	 * implemented on this system. Just ignore it.
+	/*
+	 * The XGetImage() function is apparently not implemented on this
+	 * system. Just ignore it.
 	 */
+
 	return TCL_OK;
     }
     result = TkPostscriptImage(interp, tkwin, psinfo, ximage, x, y,
@@ -792,15 +740,15 @@ Tk_PostscriptImage(image, interp, tkwin, psinfo, x, y, width, height, prepass)
  *
  * Tk_RedrawImage --
  *
- *	This procedure is called by widgets that contain images in order
- *	to redisplay an image on the screen or an off-screen pixmap.
+ *	This function is called by widgets that contain images in order to
+ *	redisplay an image on the screen or an off-screen pixmap.
  *
  * Results:
  *	None.
  *
  * Side effects:
- *	The image's manager is notified, and it redraws the desired
- *	portion of the image before returning.
+ *	The image's manager is notified, and it redraws the desired portion of
+ *	the image before returning.
  *
  *----------------------------------------------------------------------
  */
@@ -812,13 +760,12 @@ Tk_RedrawImage(image, imageX, imageY, width, height, drawable,
     int imageX, imageY;		/* Upper-left pixel of region in image that
 				 * needs to be redisplayed. */
     int width, height;		/* Dimensions of region to redraw. */
-    Drawable drawable;		/* Drawable in which to display image
-				 * (window or pixmap).  If this is a pixmap,
-				 * it must have the same depth as the window
-				 * used in the Tk_GetImage call for the
-				 * image. */
-    int drawableX, drawableY;	/* Coordinates in drawable that correspond
-				 * to imageX and imageY. */
+    Drawable drawable;		/* Drawable in which to display image (window
+				 * or pixmap). If this is a pixmap, it must
+				 * have the same depth as the window used in
+				 * the Tk_GetImage call for the image. */
+    int drawableX, drawableY;	/* Coordinates in drawable that correspond to
+				 * imageX and imageY. */
 {
     Image *imagePtr = (Image *) image;
 
@@ -860,11 +807,11 @@ Tk_RedrawImage(image, imageX, imageY, width, height, drawable,
  *
  * Tk_SizeOfImage --
  *
- *	This procedure returns the current dimensions of an image.
+ *	This function returns the current dimensions of an image.
  *
  * Results:
- *	The width and height of the image are returned in *widthPtr
- *	and *heightPtr.
+ *	The width and height of the image are returned in *widthPtr and
+ *	*heightPtr.
  *
  * Side effects:
  *	None.
@@ -889,16 +836,14 @@ Tk_SizeOfImage(image, widthPtr, heightPtr)
  *
  * Tk_DeleteImage --
  *
- *	Given the name of an image, this procedure destroys the
- *	image.
+ *	Given the name of an image, this function destroys the image.
  *
  * Results:
  *	None.
  *
  * Side effects:
- *	The image is destroyed; existing instances will display as
- *	blank areas.  If no such image exists then the procedure does
- *	nothing.
+ *	The image is destroyed; existing instances will display as blank
+ *	areas. If no such image exists then the function does nothing.
  *
  *----------------------------------------------------------------------
  */
@@ -928,15 +873,15 @@ Tk_DeleteImage(interp, name)
  *
  * DeleteImage --
  *
- *	This procedure is responsible for deleting an image.
+ *	This function is responsible for deleting an image.
  *
  * Results:
  *	None.
  *
  * Side effects:
- *	The connection is dropped between instances of this image and
- *	an image master.  Image instances will redisplay themselves
- *	as empty areas, but existing instances will not be deleted.
+ *	The connection is dropped between instances of this image and an image
+ *	master. Image instances will redisplay themselves as empty areas, but
+ *	existing instances will not be deleted.
  *
  *----------------------------------------------------------------------
  */
@@ -983,9 +928,9 @@ DeleteImage(masterPtr)
  *	None.
  *
  * Side effects:
- *	Image will get freed, though not until it is no longer
- *	Tcl_Preserve()d by anything.  May be called multiple times on
- *	the same image without ill effects.
+ *	Image will get freed, though not until it is no longer Tcl_Preserve()d
+ *	by anything. May be called multiple times on the same image without
+ *	ill effects.
  *
  *----------------------------------------------------------------------
  */
@@ -993,8 +938,8 @@ DeleteImage(masterPtr)
 static void
 EventuallyDeleteImage(masterPtr, forgetImageHashNow)
     ImageMaster *masterPtr;	/* Pointer to main data structure for image. */
-    int forgetImageHashNow;	/* Flag to say whether the hash table is
-				 * about to vanish. */
+    int forgetImageHashNow;	/* Flag to say whether the hash table is about
+				 * to vanish. */
 {
     if (forgetImageHashNow) {
 	masterPtr->hPtr = NULL;
@@ -1011,10 +956,9 @@ EventuallyDeleteImage(masterPtr, forgetImageHashNow)
  *
  * TkDeleteAllImages --
  *
- *	This procedure is called when an application is deleted.  It
- *	calls back all of the managers for all images so that they
- *	can cleanup, then it deletes all of Tk's internal information
- *	about images.
+ *	This function is called when an application is deleted. It calls back
+ *	all of the managers for all images so that they can cleanup, then it
+ *	deletes all of Tk's internal information about images.
  *
  * Results:
  *	None.
@@ -1045,15 +989,14 @@ TkDeleteAllImages(mainPtr)
  *
  * Tk_GetImageMasterData --
  *
- *	Given the name of an image, this procedure returns the type
- *	of the image and the clientData associated with its master.
+ *	Given the name of an image, this function returns the type of the
+ *	image and the clientData associated with its master.
  *
  * Results:
- *	If there is no image by the given name, then NULL is returned
- *	and a NULL value is stored at *typePtrPtr.  Otherwise the return
- *	value is the clientData returned by the createProc when the
- *	image was created and a pointer to the type structure for the
- *	image is stored at *typePtrPtr.
+ *	If there is no image by the given name, then NULL is returned and a
+ *	NULL value is stored at *typePtrPtr. Otherwise the return value is the
+ *	clientData returned by the createProc when the image was created and a
+ *	pointer to the type structure for the image is stored at *typePtrPtr.
  *
  * Side effects:
  *	None.
@@ -1066,8 +1009,8 @@ Tk_GetImageMasterData(interp, name, typePtrPtr)
     Tcl_Interp *interp;		/* Interpreter in which the image was
 				 * created. */
     CONST char *name;		/* Name of image. */
-    Tk_ImageType **typePtrPtr;	/* Points to location to fill in with
-				 * pointer to type information for image. */
+    Tk_ImageType **typePtrPtr;	/* Points to location to fill in with pointer
+				 * to type information for image. */
 {
     Tcl_HashEntry *hPtr;
     TkWindow *winPtr;
@@ -1093,21 +1036,22 @@ Tk_GetImageMasterData(interp, name, typePtrPtr)
  *
  * Tk_SetTSOrigin --
  *
- *	Set the pattern origin of the tile to a common point (i.e. the
- *	origin (0,0) of the top level window) so that tiles from two
- *	different widgets will match up.  This done by setting the
- *	GCTileStipOrigin field is set to the translated origin of the
- *	toplevel window in the hierarchy.
+ *	Set the pattern origin of the tile to a common point (i.e. the origin
+ *	(0,0) of the top level window) so that tiles from two different
+ *	widgets will match up. This done by setting the GCTileStipOrigin field
+ *	is set to the translated origin of the toplevel window in the
+ *	hierarchy.
  *
  * Results:
  *	None.
  *
  * Side Effects:
- *	The GCTileStipOrigin is reset in the GC.  This will cause the
- *	tile origin to change when the GC is used for drawing.
+ *	The GCTileStipOrigin is reset in the GC. This will cause the tile
+ *	origin to change when the GC is used for drawing.
  *
  *----------------------------------------------------------------------
  */
+
 /*ARGSUSED*/
 void
 Tk_SetTSOrigin(tkwin, gc, x, y)
@@ -1122,4 +1066,11 @@ Tk_SetTSOrigin(tkwin, gc, x, y)
     }
     XSetTSOrigin(Tk_Display(tkwin), gc, x, y);
 }
-
+
+/*
+ * Local Variables:
+ * mode: c
+ * c-basic-offset: 4
+ * fill-column: 78
+ * End:
+ */