diff options
| author | georgeps <georgeps> | 2008-08-19 15:52:11 (GMT) |
|---|---|---|
| committer | georgeps <georgeps> | 2008-08-19 15:52:11 (GMT) |
| commit | 65721df535d2aea9213fc2c357a9c4c256b2cec6 (patch) | |
| tree | c84b392e06fb0dd9d69a9a13c3f46b8a56267704 /generic/tkWindow.c | |
| parent | 03d77dae7c7add838a4b5a9e29dd3561899decc5 (diff) | |
| download | tk-65721df535d2aea9213fc2c357a9c4c256b2cec6.zip tk-65721df535d2aea9213fc2c357a9c4c256b2cec6.tar.gz tk-65721df535d2aea9213fc2c357a9c4c256b2cec6.tar.bz2 | |
After some discussion with Joe English and subsequently the
X.org developers (Keith Packard in particular), it was discovered
that Tk is doing management of XIDs that it shouldn't need to do.
The very common XC-MISC extension which has come with every version
of X for the last 15 years is used with Xlib now, to retrieve the
information about the used/unused XIDs.
The public Tk_FreeXId is now a no-op.
Joe English reviewed the patch, and said "please commit."
The patch is associated with the bug tracker id: 2039720
generic/tkError.c: Remove the usage of TkpWindowWasRecentlyDeleted.
generic/tkInt.decls: Update the declarations for the now unused
internalstubs.
generic/tkIntDecls.h: Regenerated based on tkInt.decls.
generic/tkIntPlatDecls.h: Regenerated based on tkInt.decls.
generic/tkStubInit.c
generic/tkWindow.c: Remove the calls to TkInitXId, and TkFreeWindowId.
macosx/tkMaxOSXPort.h: Remove TkFreeWindowId and TkInitXId macro
definitions.
macosx/tkMacOSXXStubs.c: Remove the no-op
TkpWindowWasRecentlyDeleted.
unix/tkUnixEvent.c: Remove call to TkFreeXId.
unix/tkUnixXId.c: Remove a lot of unnecessary code (see above).
win/tkWinPort.h: Remove TkFreeWindowId and TkInitXId.
win/tkWinWindow.c: Remove TkpWindowWasRecentlyDeleted.
Diffstat (limited to 'generic/tkWindow.c')
| -rw-r--r-- | generic/tkWindow.c | 5 |
1 files changed, 1 insertions, 4 deletions
diff --git a/generic/tkWindow.c b/generic/tkWindow.c index 8820c73..7e947cf 100644 --- a/generic/tkWindow.c +++ b/generic/tkWindow.c @@ -11,7 +11,7 @@ * See the file "license.terms" for information on usage and redistribution of * this file, and for a DISCLAIMER OF ALL WARRANTIES. * - * RCS: @(#) $Id: tkWindow.c,v 1.95 2008/04/27 22:38:58 dkf Exp $ + * RCS: @(#) $Id: tkWindow.c,v 1.96 2008/08/19 15:52:12 georgeps Exp $ */ #include "tkInt.h" @@ -521,8 +521,6 @@ GetScreen( dispPtr->name = (char *) ckalloc((unsigned) (length+1)); strncpy(dispPtr->name, screenName, length); dispPtr->name[length] = '\0'; - - TkInitXId(dispPtr); break; } if ((strncmp(dispPtr->name, screenName, length) == 0) @@ -1461,7 +1459,6 @@ Tk_DestroyWindow( XDestroyWindow(winPtr->display, winPtr->window); } #endif - TkFreeWindowId(dispPtr, winPtr->window); Tcl_DeleteHashEntry(Tcl_FindHashEntry(&dispPtr->winTable, (char *) winPtr->window)); winPtr->window = None; |