summaryrefslogtreecommitdiffstats
path: root/library/bgerror.tcl
diff options
context:
space:
mode:
authorericm <ericm@noemail.net>2000-04-18 02:18:32 (GMT)
committerericm <ericm@noemail.net>2000-04-18 02:18:32 (GMT)
commit23420802e3f855a012e9031cd4952fa826b99e28 (patch)
tree1a5b1bcdfcedcc57a982da47be2f49a3aba66103 /library/bgerror.tcl
parent57630e191444466eb9fbb8238eddfb79fee9b940 (diff)
downloadtk-23420802e3f855a012e9031cd4952fa826b99e28.zip
tk-23420802e3f855a012e9031cd4952fa826b99e28.tar.gz
tk-23420802e3f855a012e9031cd4952fa826b99e28.tar.bz2
* win/tkWinDialog.c: Added checks for visibility of parent window
before creating MessageBox and ChooseColor dialogs; this prevents the application from locking when the parent is withdrawn and the message box is created. In these cases, the window will be created without a parent. * unix/mkLinks: Added WinViewable.3. * tests/msgbox.test: Added tests for patch from [Bug: 4997]. * library/msgbox.tcl: * library/dialog.tcl: Applied patch from [Bug: 4997]; detaches dialog window from parent if parent is not viewable. * library/bgerror.tcl: Removed workaround from [Bug: 4370]; this is superceeded by patches to dialog.tcl. * generic/tkCmds.c: Changed WinfoObjCmd to use Tk_IsViewable function to determine visibility of windows instead of inlining the code. * generic/tkStubInit.c: * generic/tkDecls.h: * generic/tk.decls: Added Tk_IsViewable declaration. FossilOrigin-Name: a39bc3c5994e6804227b828aa86f058d123d81d4
Diffstat (limited to 'library/bgerror.tcl')
-rw-r--r--library/bgerror.tcl17
1 files changed, 1 insertions, 16 deletions
diff --git a/library/bgerror.tcl b/library/bgerror.tcl
index f9dc8d8..398e140 100644
--- a/library/bgerror.tcl
+++ b/library/bgerror.tcl
@@ -4,7 +4,7 @@
# posts a dialog box with the error message and gives the user a chance
# to see a more detailed stack trace.
#
-# RCS: @(#) $Id: bgerror.tcl,v 1.7 2000/04/11 18:19:06 ericm Exp $
+# RCS: @(#) $Id: bgerror.tcl,v 1.8 2000/04/18 02:18:33 ericm Exp $
#
# Copyright (c) 1992-1994 The Regents of the University of California.
# Copyright (c) 1994-1996 Sun Microsystems, Inc.
@@ -40,21 +40,6 @@ proc bgerror err {
set ret [catch {tkerror $err} msg];
if {$ret != 1} {return -code $ret $msg}
- # Normally, the bgerror dialog is made transient with respect to "." (due
- # to the implementation of tk_dialog). On some systems (like Windows),
- # when a window is withdraw or iconified, it's transient windows go with
- # it. Unfortunately, there is also a grab on the dialog (again because of
- # the implementation of tk_dialog). So if "." is withdrawn or iconified
- # and the user gets a bgerror, the app will hang, for no apparent reason.
- #
- # One (somewhat hacky) way to address this is to un-transient the dialog
- # if "." is withdrawn or iconified.
- after idle {
- if { ![winfo viewable .bgerrorDialog] } {
- wm transient .bgerrorDialog {}
- }
- }
-
# Ok the application's tkerror either failed or was not found
# we use the default dialog then :
if {$tcl_platform(platform) == "macintosh"} {