* macosx/tkMacOSXDraw.c: replace all (internal) use of QD region

	* macosx/tkMacOSXSubwindows.c:	API by HIShape API, with conversion to
	* macosx/tkMacOSXWindowEvent.c	QD regions only when required by legacy
	* macosx/tkMacOSXPrivate.h:	Carbon or Tk API.
	* macosx/tkMacOSXRegion.c:
	* macosx/tkMacOSXDebug.c:
	* macosx/tkMacOSXDebug.h:

	* macosx/tkMacOSXInt.h:		replace MacDrawable's QD RgnHandles
	* macosx/tkMacOSXEmbed.c:	clipRgn, aboveClipRgn & drawRgn by
	* macosx/tkMacOSXMenu.c:	HIShapeRefs visRgn & aboveVisRgn and
	* macosx/tkMacOSXSubwindows.c:	CGRect drawRect.

	* macosx/tkMacOSXWindowEvent.c:	remove use of QD port vis rgn in window
	* macosx/tkMacOSXSubwindows.c:	update rgn calculation, manually excise
	* macosx/tkMacOSXWm.c:		growbox from toplevel clip rgn instead.

	* macosx/tkMacOSXDraw.c:	replace use of QD port clip rgn by new
	* macosx/tkMacOSXPrivate.h:	clipRgn fld in TkMacOSXDrawingContext;
					handle QD/CG drawing mismatches in
					XCopyArea, XCopyPlane and TkPutImage;
					cleanup/speedup CGContext setup in
					TkMacOSXSetupDrawingContext().

	* macosx/tkMacOSXDraw.c:	change TkMacOSXSetupDrawingContext() to
	* macosx/tkMacOSXEntry.c:	return boolean indicating whether
	* macosx/tkMacOSXFont.c:	drawing is allowed (and was setup) or
	* macosx/tkMacOSXMenu.c:	not (e.g. when clipRgn is empty).
	* macosx/ttkMacOSXTheme.c:

	* macosx/tkMacOSXSubwindows.c:	signal that drawable is a pixmap via
	* macosx/tkMacOSXInt.h:		new explicit TK_IS_PIXMAP flag instead
					of a NULL cligRgn field.

	* macosx/tkMacOSXRegion.c:	add wrappers for missing/buggy HIShape
	* macosx/tkMacOSXPrivate.h:	API, and private helpers to operate on
					HIShapeRefs & convert to/from TkRegion.

	* macosx/tkMacOSXRegion.c:	add Tkp{Retain,Release}Region() API for
	* macosx/tkMacOSXInt.h:		TkRegion.

1 files changed, 378 insertions, 30 deletions

diff --git a/macosx/tkMacOSXRegion.c b/macosx/tkMacOSXRegion.c
index e2252da..f839a15 100644
--- a/macosx/tkMacOSXRegion.c
+++ b/macosx/tkMacOSXRegion.c
@@ -10,7 +10,7 @@
  * See the file "license.terms" for information on usage and redistribution
  * of this file, and for a DISCLAIMER OF ALL WARRANTIES.
  *
- * RCS: @(#) $Id: tkMacOSXRegion.c,v 1.9 2007/06/29 03:20:02 das Exp $
+ * RCS: @(#) $Id: tkMacOSXRegion.c,v 1.10 2007/10/12 03:14:48 das Exp $
  */
 
 #include "tkMacOSXPrivate.h"
@@ -36,7 +36,7 @@
 TkRegion
 TkCreateRegion(void)
 {
-    return (TkRegion) NewRgn();
+    return (TkRegion) HIShapeCreateMutable();
 }
 
 /*
@@ -60,7 +60,9 @@ void
 TkDestroyRegion(
     TkRegion r)
 {
-    DisposeRgn((RgnHandle) r);
+    if (r) {
+	CFRelease(r);
+    }
 }
 
 /*
@@ -86,7 +88,8 @@ TkIntersectRegion(
     TkRegion srb,
     TkRegion dr_return)
 {
-    SectRgn((RgnHandle) sra, (RgnHandle) srb, (RgnHandle) dr_return);
+    ChkErr(HIShapeIntersect, (HIShapeRef) sra, (HIShapeRef) srb,
+	   (HIMutableShapeRef) dr_return);
 }
 
 /*
@@ -112,7 +115,8 @@ TkSubtractRegion(
     TkRegion srb,
     TkRegion dr_return)
 {
-    DiffRgn((RgnHandle) sra, (RgnHandle) srb, (RgnHandle) dr_return);
+    ChkErr(HIShapeDifference, (HIShapeRef) sra, (HIShapeRef) srb,
+	   (HIMutableShapeRef) dr_return);
 }
 
 /*
@@ -139,12 +143,19 @@ TkUnionRectWithRegion(
     TkRegion src_region,
     TkRegion dest_region_return)
 {
-    TkMacOSXCheckTmpQdRgnEmpty();
-    SetRectRgn(tkMacOSXtmpQdRgn, rectangle->x, rectangle->y,
-	    rectangle->x + rectangle->width, rectangle->y + rectangle->height);
-    UnionRgn((RgnHandle) src_region, tkMacOSXtmpQdRgn,
-	    (RgnHandle) dest_region_return);
-    SetEmptyRgn(tkMacOSXtmpQdRgn);
+    const CGRect r = CGRectMake(rectangle->x, rectangle->y,
+	    rectangle->width, rectangle->height);
+
+    if (src_region == dest_region_return) {
+	ChkErr(TkMacOSHIShapeUnionWithRect,
+		(HIMutableShapeRef) dest_region_return, &r);
+    } else {
+	HIShapeRef rectRgn = HIShapeCreateWithRect(&r);
+
+	ChkErr(TkMacOSHIShapeUnion, rectRgn, (HIShapeRef) src_region,
+		(HIMutableShapeRef) dest_region_return);
+	CFRelease(rectRgn);
+    }
 }
 
 /*
@@ -156,7 +167,8 @@ TkUnionRectWithRegion(
  *	XRectInRegion. See X window documentation for more details.
  *
  * Results:
- *	Returns one of: RectangleOut, RectangleIn, RectanglePart.
+ *	Returns RectanglePart or RectangleOut. Note that this is not a
+ *	complete implementation since it doesn't test for RectangleIn.
  *
  * Side effects:
  *	None.
@@ -173,18 +185,40 @@ TkRectInRegion(
     unsigned int height)
 {
     int result;
+    const CGRect r = CGRectMake(x, y, width, height);
 
-    TkMacOSXCheckTmpQdRgnEmpty();
-    SetRectRgn(tkMacOSXtmpQdRgn, x, y, x + width, y + height);
-    SectRgn((RgnHandle) region, tkMacOSXtmpQdRgn, tkMacOSXtmpQdRgn);
-    if (EmptyRgn(tkMacOSXtmpQdRgn)) {
-	result = RectangleOut;
-    } else if (EqualRgn((RgnHandle) region, tkMacOSXtmpQdRgn)) {
-	result = RectangleIn;
-    } else {
-	result = RectanglePart;
-    }
-    SetEmptyRgn(tkMacOSXtmpQdRgn);
+    TK_IF_MAC_OS_X_API (4, HIShapeIntersectsRect,
+	result = HIShapeIntersectsRect((HIShapeRef) region, &r) ?
+		RectanglePart : RectangleOut;
+    ) TK_ELSE_MAC_OS_X (4,
+	HIShapeRef rectRgn = HIShapeCreateWithRect(&r);
+	HIShapeRef sectRgn = HIShapeCreateIntersection((HIShapeRef) region,
+		rectRgn);
+
+#if 1
+	result = !HIShapeIsEmpty(sectRgn) ? RectanglePart : RectangleOut;
+#else
+	/*
+	 * More expensive full implementation that tests for RectangleIn,
+	 * unused by Tk at present.
+	 */
+
+	if (!HIShapeIsEmpty(sectRgn)) {
+	    HIShapeRef diffRgn = HIShapeCreateDifference(rectRgn, sectRgn);
+	 
+	    if (HIShapeIsEmpty(diffRgn)) {
+		result = RectangleIn;
+	    } else {
+		result = RectanglePart;
+	    }
+	    CFRelease(diffRgn);
+	} else {
+	    result = RectangleOut;
+	}
+#endif
+	CFRelease(sectRgn);
+	CFRelease(rectRgn);
+    ) TK_ENDIF
     return result;
 }
 
@@ -210,13 +244,13 @@ TkClipBox(
     TkRegion r,
     XRectangle* rect_return)
 {
-    Rect rect;
-
-    GetRegionBounds((RgnHandle) r,&rect);
-    rect_return->x = rect.left;
-    rect_return->y = rect.top;
-    rect_return->width = rect.right-rect.left;
-    rect_return->height = rect.bottom-rect.top;
+    CGRect rect;
+    
+    HIShapeGetBounds((HIShapeRef) r, &rect);
+    rect_return->x = rect.origin.x;
+    rect_return->y = rect.origin.y;
+    rect_return->width = rect.size.width;
+    rect_return->height = rect.size.height;
 }
 
 /*
@@ -278,3 +312,317 @@ TkpBuildRegionFromAlphaData(
 	dataPtr += lineStride;
     }
 }
+
+/*
+ *----------------------------------------------------------------------
+ *
+ * TkpRetainRegion --
+ *
+ *	Increases reference count of region.
+ *
+ * Results:
+ *	None.
+ *
+ * Side effects:
+ *	None.
+ *
+ *----------------------------------------------------------------------
+ */
+
+void
+TkpRetainRegion(
+    TkRegion r)
+{
+    CFRetain(r);
+}
+
+/*
+ *----------------------------------------------------------------------
+ *
+ * TkpReleaseRegion --
+ *
+ *	Decreases reference count of region.
+ *
+ * Results:
+ *	None.
+ *
+ * Side effects:
+ *	May free memory.
+ *
+ *----------------------------------------------------------------------
+ */
+
+void
+TkpReleaseRegion(
+    TkRegion r)
+{
+    CFRelease(r);
+}
+#if 0
+
+/*
+ *----------------------------------------------------------------------
+ *
+ * TkMacOSXEmtpyRegion --
+ *
+ *	Set region to emtpy.
+ *
+ * Results:
+ *	None.
+ *
+ * Side effects:
+ *	None.
+ *
+ *----------------------------------------------------------------------
+ */
+
+void
+TkMacOSXEmtpyRegion(
+    TkRegion r)
+{
+    ChkErr(HIShapeSetEmpty, (HIMutableShapeRef) r);
+}
+
+/*
+ *----------------------------------------------------------------------
+ *
+ * TkMacOSXIsEmptyRegion --
+ *
+ *	Return native region for given tk region.
+ *
+ * Results:
+ *	1 if empty, 0 otherwise.
+ *
+ * Side effects:
+ *	None.
+ *
+ *----------------------------------------------------------------------
+ */
+
+int
+TkMacOSXIsEmptyRegion(
+    TkRegion r)
+{
+    return HIShapeIsEmpty((HIMutableShapeRef) r) ? 1 : 0;
+}
+#endif
+
+/*
+ *----------------------------------------------------------------------
+ *
+ * TkMacOSXGetNativeRegion --
+ *
+ *	Return native region for given tk region.
+ *
+ * Results:
+ *	Native region, CFRelease when done.
+ *
+ * Side effects:
+ *	None.
+ *
+ *----------------------------------------------------------------------
+ */
+
+HIShapeRef
+TkMacOSXGetNativeRegion(
+    TkRegion r)
+{
+    return (HIShapeRef) CFRetain(r);
+}
+
+/*
+ *----------------------------------------------------------------------
+ *
+ * TkMacOSXSetWithNativeRegion --
+ *
+ *	Set region to the native region.
+ *
+ * Results:
+ *	None.
+ *
+ * Side effects:
+ *	None.
+ *
+ *----------------------------------------------------------------------
+ */
+
+void
+TkMacOSXSetWithNativeRegion(
+    TkRegion r,
+    HIShapeRef rgn)
+{
+    ChkErr(TkMacOSXHIShapeSetWithShape, (HIMutableShapeRef) r, rgn);
+}
+
+/*
+ *----------------------------------------------------------------------
+ *
+ * TkMacOSXOffsetRegion --
+ *
+ *	Offsets region by given distances.
+ *
+ * Results:
+ *	None.
+ *
+ * Side effects:
+ *	None.
+ *
+ *----------------------------------------------------------------------
+ */
+
+void
+TkMacOSXOffsetRegion(
+    TkRegion r,
+    short dx,
+    short dy)
+{
+    ChkErr(HIShapeOffset, (HIMutableShapeRef) r, dx, dy);
+}
+
+/*
+ *----------------------------------------------------------------------
+ *
+ * TkMacOSXHIShapeCreateEmpty, TkMacOSXHIShapeCreateMutableWithRect,
+ * TkMacOSXHIShapeSetWithShape, TkMacOSXHIShapeSetWithRect,
+ * TkMacOSHIShapeDifferenceWithRect, TkMacOSHIShapeUnionWithRect,
+ * TkMacOSHIShapeUnion --
+ *
+ *	Wrapper functions for missing/buggy HIShape API
+ *
+ *----------------------------------------------------------------------
+ */
+
+HIShapeRef
+TkMacOSXHIShapeCreateEmpty(void)
+{
+    HIShapeRef result;
+
+    TK_IF_MAC_OS_X_API (4, HIShapeCreateEmpty,
+	result = HIShapeCreateEmpty();
+    ) TK_ELSE_MAC_OS_X (4,
+	static HIShapeRef emptyRgn = NULL;
+	
+	if (!emptyRgn) {
+	    HIMutableShapeRef rgn = HIShapeCreateMutable();
+
+	    emptyRgn = HIShapeCreateCopy(rgn);
+	    CFRelease(rgn);
+	}
+	result = HIShapeCreateCopy(emptyRgn);
+    ) TK_ENDIF
+
+    return result;
+}
+
+HIMutableShapeRef
+TkMacOSXHIShapeCreateMutableWithRect(
+    const CGRect *inRect)
+{
+    HIMutableShapeRef result;
+
+    TK_IF_MAC_OS_X_API (5, HIShapeCreateMutableWithRect,
+	result = HIShapeCreateMutableWithRect(inRect);
+    ) TK_ELSE_MAC_OS_X (5,
+	HIShapeRef rgn = HIShapeCreateWithRect(inRect);
+
+	result = HIShapeCreateMutableCopy(rgn);
+	CFRelease(rgn);
+    ) TK_ENDIF
+
+    return result;
+}
+
+OSStatus
+TkMacOSXHIShapeSetWithShape(
+    HIMutableShapeRef inDestShape,
+    HIShapeRef inSrcShape)
+{
+    OSStatus result;
+
+    TK_IF_MAC_OS_X_API (5, HIShapeSetWithShape,
+	result = HIShapeSetWithShape(inDestShape, inSrcShape);
+    ) TK_ELSE_MAC_OS_X (5,
+	result = HIShapeSetEmpty(inDestShape);
+	if (result == noErr) {
+	    result = HIShapeDifference(inSrcShape, inDestShape, inDestShape);
+	}
+    ) TK_ENDIF
+
+    return result;
+}
+
+#if 0
+OSStatus
+TkMacOSXHIShapeSetWithRect(
+    HIMutableShapeRef inShape,
+    const CGRect *inRect)
+{
+    OSStatus result;
+    HIShapeRef rgn = HIShapeCreateWithRect(inRect);
+
+    result = TkMacOSXHIShapeSetWithShape(inShape, rgn);
+    CFRelease(rgn);
+
+    return result;
+}
+#endif
+
+OSStatus
+TkMacOSHIShapeDifferenceWithRect(
+    HIMutableShapeRef inShape,
+    const CGRect *inRect)
+{
+    OSStatus result;
+    HIShapeRef rgn = HIShapeCreateWithRect(inRect);
+
+    result = HIShapeDifference(inShape, rgn, inShape);
+    CFRelease(rgn);
+
+    return result;
+}
+
+OSStatus
+TkMacOSHIShapeUnionWithRect(
+    HIMutableShapeRef inShape,
+    const CGRect *inRect)
+{
+    OSStatus result;
+
+    TK_IF_MAC_OS_X_API (5, HIShapeUnionWithRect,
+	result = HIShapeUnionWithRect(inShape, inRect);
+    ) TK_ELSE_MAC_OS_X (5,
+	HIShapeRef rgn = HIShapeCreateWithRect(inRect);
+
+	result = TkMacOSHIShapeUnion(rgn, inShape, inShape);
+	CFRelease(rgn);
+    ) TK_ENDIF
+
+    return result;
+}
+
+OSStatus
+TkMacOSHIShapeUnion(
+    HIShapeRef inShape1,
+    HIShapeRef inShape2,
+    HIMutableShapeRef outResult)
+{
+    OSStatus result;
+
+    TK_IF_HI_TOOLBOX (4,
+	result = HIShapeUnion(inShape1, inShape2, outResult);
+    ) TK_ELSE_HI_TOOLBOX (4,
+	/* Workaround HIShapeUnion bug in 10.3 and earlier */
+	HIShapeRef rgn = HIShapeCreateCopy(outResult);
+
+	result = HIShapeUnion(inShape1, inShape2, (HIMutableShapeRef) rgn);
+	if (result == noErr) {
+	    result = HIShapeSetEmpty(outResult);
+	    if (result == noErr) {
+		result = HIShapeDifference(rgn, outResult, outResult);
+	    }
+	}
+	CFRelease(rgn);
+    ) TK_ENDIF
+
+    return result;
+}