Bug [f9eddb541a] (TkSetRegion(), XSetClipRectangles): Patch 6 from Christopher Chavez - Optimize XSetClipRectangles() by letting it set clip_mask->value.region directly, rather than creating a temporary region and relying on TkSetRegion() to copy it.

1 files changed, 4 insertions, 3 deletions

diff --git a/xlib/xgc.c b/xlib/xgc.c
index 1a5dd81..d897bed 100644
--- a/xlib/xgc.c
+++ b/xlib/xgc.c
@@ -490,7 +490,7 @@ XSetClipMask(
 
 int
 XSetClipRectangles(
-    Display* d,
+    TCL_UNUSED(Display*),
     GC gc,
     int clip_x_origin,
     int clip_y_origin,
@@ -499,6 +499,9 @@ XSetClipRectangles(
     TCL_UNUSED(int))
 {
     TkRegion clipRgn = TkCreateRegion();
+    TkpClipMask * clip_mask = AllocClipMask(gc);
+    clip_mask->type = TKP_CLIP_REGION;
+    clip_mask->value.region = clipRgn;
 
     while (n--) {
 	XRectangle rect = *rectangles;
@@ -508,8 +511,6 @@ XSetClipRectangles(
 	TkUnionRectWithRegion(&rect, clipRgn, clipRgn);
 	rectangles++;
     }
-    TkSetRegion(d, gc, clipRgn);
-    TkDestroyRegion(clipRgn);
     return 1;
 }