From 1b5c660e330eddb121d8400dafafffa917beeb46 Mon Sep 17 00:00:00 2001 From: patthoyts Date: Thu, 22 Sep 2016 13:42:38 +0000 Subject: Correct expansion of the spinbox textarea for the vista theme. The spinbox textarea should stretch to fill the widget and does so with all except the vista theme. Added a test to check for this expansion to avoid regression. Fix identified Kumba on StackOverflow ( https://stackoverflow.com/a/36393680/291641 ) --- library/ttk/vistaTheme.tcl | 2 +- tests/ttk/spinbox.test | 21 +++++++++++++++++++++ 2 files changed, 22 insertions(+), 1 deletion(-) diff --git a/library/ttk/vistaTheme.tcl b/library/ttk/vistaTheme.tcl index 99410cb..3f75f51 100644 --- a/library/ttk/vistaTheme.tcl +++ b/library/ttk/vistaTheme.tcl @@ -133,7 +133,7 @@ namespace eval ttk::theme::vista { Spinbox.background -sticky news -children { Spinbox.padding -sticky news -children { Spinbox.innerbg -sticky news -children { - Spinbox.textarea -expand 1 -sticky {} + Spinbox.textarea -expand 1 } } Spinbox.uparrow -side top -sticky ens diff --git a/tests/ttk/spinbox.test b/tests/ttk/spinbox.test index 32b77af..08f2bda 100644 --- a/tests/ttk/spinbox.test +++ b/tests/ttk/spinbox.test @@ -199,6 +199,27 @@ test spinbox-2.4 "current command -- value not in list" -constraints nyi -setup destroy .sb } -result -1 +test spinbox-3.0 "textarea should expand to fill widget" -setup { + set SBV 5 + set ::spinbox_test {} + ttk::spinbox .sb -from 0 -to 10 -textvariable SBV +} -body { + grid .sb -sticky ew + grid columnconfigure . 0 -weight 1 + bind . { + after idle { + wm geometry . "210x80" + after 100 {set ::spinbox_test [.sb identify element 5 5]} + } + bind . {} + } + after 500 {set ::spinbox_wait 1} ; vwait ::spinbox_wait + set ::spinbox_test +} -cleanup { + destroy .sb + unset -nocomplain ::spinbox_test SBV +} -result {textarea} + # nostomp: NB intentional difference between ttk::spinbox and tk::spinbox; # see also #1439266 # -- cgit v0.12