From 6a561001729624c0015b6963beb29eb97658a30d Mon Sep 17 00:00:00 2001 From: dkf Date: Fri, 18 Aug 2006 10:24:40 +0000 Subject: Style cleanup Split older changelog entries into separate file --- ChangeLog | 4228 ++++--------------------------------------------------- ChangeLog.2004 | 3653 +++++++++++++++++++++++++++++++++++++++++++++++ generic/tk.h | 973 +++++++------ generic/tkInt.h | 163 ++- 4 files changed, 4497 insertions(+), 4520 deletions(-) create mode 100644 ChangeLog.2004 diff --git a/ChangeLog b/ChangeLog index d5e1126..f0a274d 100644 --- a/ChangeLog +++ b/ChangeLog @@ -1,11 +1,15 @@ +2006-08-18 Donal K. Fellows + + * generic/tk.h, generic/tkInt.h: Stylistic improvements. No API change. + 2006-08-18 Daniel Steffen * unix/tcl.m4 (Darwin): add support for --enable-64bit on x86_64, for universal builds including x86_64, for 64-bit CoreFoundation on Leopard - and for use of -mmacosx-version-min instead of MACOSX_DEPLOYMENT_TARGET. + and for use of -mmacosx-version-min instead of MACOSX_DEPLOYMENT_TARGET * unix/configure.in (Darwin): remove 64-bit arch flags from CFLAGS for - combined 32-bit and 64-bit universal builds, as neither TkAqua nor TkX11 - can be built for 64-bit at present. + combined 32-bit and 64-bit universal builds, as neither TkAqua nor + TkX11 can be built for 64-bit at present. * unix/configure: autoconf-2.59 * unix/tkConfig.h.in: autoheader-2.59 @@ -14,20 +18,21 @@ * macosx/README: updates for x86_64 and Xcode 2.3. * macosx/tkMacOSXInit.c (TkpInit): when available, use public - TransformProcessType() API instead of CPSEnableForegroundOperation() SPI - to notify the window server that we are a GUI application. + TransformProcessType() API instead of CPSEnableForegroundOperation() + SPI to notify the window server that we are a GUI application. - * macosx/tkMacOSXWm.c (WmAttrGetTitlePath): use HIWindow API on >=Tiger. + * macosx/tkMacOSXWm.c (WmAttrGetTitlePath): use HIWindow API on >=Tiger * macosx/tkMacOSXMouseEvent.c (GenerateToolbarButtonEvent): * macosx/tkMacOSXMenus.c (GenerateEditEvent): - * macosx/tkMacOSXMenu.c (MenuSelectEvent): bzero XVirtualEvent structure - before use to ensure all fields are initialized. [Bug 1542205] + * macosx/tkMacOSXMenu.c (MenuSelectEvent): bzero() the XVirtualEvent + structure before use to ensure all fields are initialized. [Bug + 1542205] 2006-08-16 Jeff Hobbs - * macosx/tkMacOSXWm.c (WmAttributesCmd): correct OS X result for - [wm attributes $top]. + * macosx/tkMacOSXWm.c (WmAttributesCmd): correct OS X result for [wm + attributes $top]. 2006-07-25 Daniel Steffen @@ -39,14 +44,16 @@ * macosx/tkMacOSXWm.c (TkWmMapWindow): fix incorrect values of wmInfo parentWidth/Height for toplevels by recalculating them once the window - is mapped (i.e once the window&structure sizes are known). [Bug 1358663] + is mapped (i.e once the window&structure sizes are known). [Bug + 1358663] (ParseGeometry): sync with ParseGeometry in tkUnixWm.c/tkWinWm.c. 2006-07-21 Daniel Steffen * generic/tkBind.c (TkBindInit): for REDO_KEYSYM_LOOKUP, change - keysym-to-string mapping hash to use first name in ks_names.h instead of - last (if there are multiple possibilities), e.g. "F11" instead of "L1". + keysym-to-string mapping hash to use first name in ks_names.h instead + of last (if there are multiple possibilities), e.g. "F11" instead of + "L1". * macosx/tkMacOSXKeyboard.c (TkpGetKeySym): correct keysyms for pure modifier key presses [Bugs 700311, 1525905]; correct keysym for Enter @@ -65,7 +72,7 @@ * unix/tcl.m4: flag and weak-link libXss if possible as it is not available before OSX 10.4; enforce requirement of OSX 10.2 for TkAqua; move Darwin specific checks & defines that are only relevant to the tcl - build out of tcl.m4; restrict framework option to Darwin; cleanup + build out of tcl.m4; restrict framework option to Darwin; clean up quoting and help messages. * unix/configure: autoconf-2.59 * unix/tkConfig.h.in: autoheader-2.59 @@ -92,10 +99,9 @@ 2006-07-14 Andreas Kupries - * generic/tkWindow.c (Initialize): Modify change of 2006-05-25 - (jeffh). Release mutex a bit earlier, to prevent lock when OS X - creates its console windows (recursively enters Tk_Init). Patch - by JeffH. + * generic/tkWindow.c (Initialize): Modify change of 2006-05-25 (jeffh). + Release mutex a bit earlier, to prevent lock when OS X creates its + console windows (recursively enters Tk_Init). Patch by JeffH. 2006-07-06 Jeff Hobbs @@ -103,20 +109,20 @@ 2006-06-21 Jeff Hobbs - * library/bgerror.tcl (::tk::dialog::error::bgerror): remove a - couple of unnecessary hardcoded options + * library/bgerror.tcl (::tk::dialog::error::bgerror): remove a couple + of unnecessary hardcoded options 2006-06-14 Don Porter - * generic/tkScale.c: Revised variable writing logic to account - for [scale]'s design that it deals with its value as a formatted - string, and not as a double. [Bug 891141]. + * generic/tkScale.c: Revised variable writing logic to account for + [scale]'s design that it deals with its value as a formatted string, + and not as a double. [Bug 891141]. 2006-06-14 Daniel Steffen - * macosx/tkMacOSXSubwindows.c (TkMacOSXInvalidateWindow): ensure invalid - clip regions are recreated via TkMacOSXUpdateClipRgn() before they are - used; correct call order of TkMacOSXInvalidateWindow() and + * macosx/tkMacOSXSubwindows.c (TkMacOSXInvalidateWindow): ensure + invalid clip regions are recreated via TkMacOSXUpdateClipRgn() before + they are used; correct call order of TkMacOSXInvalidateWindow() and TkMacOSXInvalClipRgns() throughout. [Bug 1501922] * macosx/tkMacOSXDraw.c (TkPutImage): implement drawing of very wide @@ -125,50 +131,49 @@ 2006-06-09 Don Porter - * generic/tkMain.c: Added Tcl_Preserve() call on the master - interp as crash protection against any Tcl_DeleteInterp() call - that might happen. + * generic/tkMain.c: Added Tcl_Preserve() call on the master interp + as crash protection against any Tcl_DeleteInterp() call that might + happen. 2006-06-01 Don Porter - * generic/tkConsole.c: Added Tcl_RegisterChannel() calls to bump - the refcount of channels passed to Tcl_SetStdChannel(). This prevents - early free-ing of the channels that leads to crashes. [Bug 912571]. + * generic/tkConsole.c: Added Tcl_RegisterChannel() calls to bump the + refcount of channels passed to Tcl_SetStdChannel(). This prevents early + free-ing of the channels that leads to crashes. [Bug 912571] 2006-05-29 Jeff Hobbs - * win/tkWinEmbed.c (TkpGetOtherWindow): [Bug 1212056] do not panic - * unix/tkUnixEmbed.c (TkpGetOtherWindow): if no window is found - - * unix/tkUnixWm.c (Tk_CoordsToWindow, UpdateGeometryInfo): handle it - in the caller + * win/tkWinEmbed.c (TkpGetOtherWindow): [Bug 1212056] Do not panic if + * unix/tkUnixEmbed.c (TkpGetOtherWindow): no window is found; handle it + * unix/tkUnixWm.c (Tk_CoordsToWindow, UpdateGeometryInfo): in caller. * tests/entry.test (entry-22.1): * tests/listbox.test (listbox-6.15): * generic/tkListbox.c (ListboxInsertSubCmd, ListboxDeleteSubCmd): - Ignore Tcl_SetVar2Ex failure of listVarName, similar to entry - widget handling. [Bug 1424513] + Ignore Tcl_SetVar2Ex failure of listVarName, similar to entry widget + handling. [Bug 1424513] 2006-05-26 Jeff Hobbs - * macosx/tkMacOSXButton.c (TkMacOSXDrawControl): correct redraw - for direct transition from disabled to active state. [Bug 706446] + * macosx/tkMacOSXButton.c (TkMacOSXDrawControl): correct redraw for + direct transition from disabled to active state. [Bug 706446] 2006-05-25 Jeff Hobbs - * win/tkWinMenu.c (TkWinMenuKeyObjCmd): get eventPtr after we know - the window is still alive. [AS bug 45987] [Bug 1236306] + * win/tkWinMenu.c (TkWinMenuKeyObjCmd): get eventPtr after we know the + window is still alive. [AS bug 45987] [Bug 1236306] - * generic/tkMenu.c (DeleteMenuCloneEntries): Modify entry index - changes to work around VC6 optimization bug. [Bug 1224330] + * generic/tkMenu.c (DeleteMenuCloneEntries): Modify entry index changes + to work around VC6 optimization bug. [Bug 1224330] * generic/tkMessage.c (MessageWidgetObjCmd): Correct msgPtr preserve/release pairing. [Bug 1485750] (afredd) - * generic/tkWindow.c (Initialize): Correct mutex (un)lock - pairing. [Bug 1479587] (loewis) + * generic/tkWindow.c (Initialize): Correct mutex (un)lock pairing. [Bug + 1479587] (loewis) - * generic/tkBind.c (Tk_BindEvent, TkCopyAndGlobalEval): use - Tcl_EvalEx instead of Tcl_GlobalEval. + * generic/tkBind.c (Tk_BindEvent, TkCopyAndGlobalEval): use Tcl_EvalEx + instead of Tcl_GlobalEval. 2006-05-16 Daniel Steffen @@ -186,30 +191,31 @@ 2006-05-12 Jeff Hobbs - * generic/tkImgPhoto.c (Tk_PhotoPutBlock, Tk_PhotoPutZoomedBlock): - Fix opt added 2006-03 that caused slowdown for some common cases. - [Bug 1409140] + * generic/tkImgPhoto.c (Tk_PhotoPutBlock, Tk_PhotoPutZoomedBlock): Fix + opt added 2006-03 that caused slowdown for some common cases. [Bug + 1409140] 2006-05-13 Daniel Steffen * generic/tkCanvWind.c (DisplayWinItem, WinItemRequestProc): ensure canvas window items are unmapped when canvas is unmapped. [Bug 940117] - * macosx/tkMacOSXSubwindows.c (TkMacOSXUpdateClipRgn): empty clip region - of unmapped windows to prevent any drawing into them or into their - children from becoming visible. [Bug 940117] + * macosx/tkMacOSXSubwindows.c (TkMacOSXUpdateClipRgn): empty clip + region of unmapped windows to prevent any drawing into them or into + their children from becoming visible. [Bug 940117] * macosx/tkMacOSXInt.h: revert Jim's attempt of 2005-03-14 to * macosx/tkMacOSXSubwindows.c: fix Bug 940117 as it disables Map/Unmap - event propagation to children. [Bug 1480105] + event propagation to children. [Bug 1480105] - * macosx/tkMacOSXDraw.c (TkPutImage): handle tkPictureIsOpen flag, fixes - incorrect positioning of images with complex alpha on native buttons; - actual alpha blending is still broken in this situation. [Bug 1155596] + * macosx/tkMacOSXDraw.c (TkPutImage): handle tkPictureIsOpen flag, + fixes incorrect positioning of images with complex alpha on native + buttons; actual alpha blending is still broken in this situation. [Bug + 1155596] * macosx/tkMacOSXEvent.c (TkMacOSXProcessCommandEvent): - * macosx/tkMacOSXMenus.c (TkMacOSXInitMenus): workaround carbon bug with - key shortcut for 'Preferences' app menu item. [Bug 1481503] + * macosx/tkMacOSXMenus.c (TkMacOSXInitMenus): workaround carbon bug + with key shortcut for 'Preferences' app menu item. [Bug 1481503] * macosx/tkMacOSXKeyEvent.c (TkMacOSXProcessKeyboardEvent): only check for HICommand menu item shortcuts in the application menu. @@ -248,9 +254,9 @@ window-local pointer position. * macosx/tkMacOSXInt.h: use improvements above to avoid calls to - * macosx/tkMacOSXKeyEvent.c: GlobalToLocal() when the current port might - * macosx/tkMacOSXMenu.c: not be set correctly. May fix [Bug 1243318] - * macosx/tkMacOSXMenus.c: + * macosx/tkMacOSXKeyEvent.c: GlobalToLocal() when the current port + * macosx/tkMacOSXMenu.c: might not be set correctly. May fix [Bug + * macosx/tkMacOSXMenus.c: 1243318] * macosx/tkMacOSXScale.c: * macosx/tkMacOSXScrlbr.c: @@ -287,8 +293,8 @@ 2006-04-11 Peter Spjuth * generic/tkWindow.c (Tk_NameToWindow): Allow NULL interp to - Tk_NameToWindow. This fixes TkGetWindowFromObj which promises to - handle NULL but didn't. + Tk_NameToWindow. This fixes TkGetWindowFromObj which promises to handle + NULL but didn't. * generic/tkGrid.c: Fixed handling of out of bounds row or column. * tests/grid.test: [Bug 1432666] @@ -296,8 +302,8 @@ 2006-04-11 Don Porter * unix/Makefile.in: Updated `make dist` target to be sure the - message catalogs for the widget demo get packaged into the source - code distribution. [Bug 1466509] + message catalogs for the widget demo get packaged into the source code + distribution. [Bug 1466509] 2006-04-11 Daniel Steffen @@ -313,14 +319,14 @@ * macosx/tkMacOSXHLEvents.c: call ::tk::mac::* procs for all * macosx/tkMacOSXWindowEvent.c: registered appleevents [FR 1105284], - implement print applevent handling, style/whitespace cleanup. + implement print applevent handling, style/whitespace cleanup. * macosx/tkMacOSXDraw.c (TkMacOSXInitCGDrawing): prevent multiple init. * macosx/tkMacOSXFont.c: remove #ifdef'd text measuring codepaths now * macosx/tkMacOSXInit.c: known to be incorrect, cleanup obsolete text - * macosx/README: antialiasing control code, document ATSUI - text antialiasing changes. + * macosx/README: antialiasing control code, document ATSUI text + antialiasing changes. * macosx/tkMacOSXInt.h: Implemented 'zoomed' window state * macosx/tkMacOSXWindowEvent.c: handling for TkAqua, via titlebar @@ -330,16 +336,16 @@ 2006-04-10 Donal K. Fellows * library/tkfbox.tcl (::tk::IconList_Goto): Fix prefix searching so - that the start location is reasonable, and the prefix matching is - using the correct Tcl command for this. [Bug 1467938] + that the start location is reasonable, and the prefix matching is using + the correct Tcl command for this. [Bug 1467938] 2006-04-10 Benjamin Riefenstahl * macosx/tkMacOSXFont.c (MeasureStringWidth): Use implementation based on ATSUGetGlyphBounds (TK_MAC_USE_GETGLYPHBOUNDS), so we can use - kATSUseFractionalOrigins. This in turn corrects [Bug 1461650]. + kATSUseFractionalOrigins. This in turn corrects [Bug 1461650]. (InitFont): Use "." and "W" instead of "i" and "w" to determine the - "-fixed" attribute. This prevents "Apple Chancery" from being + "-fixed" attribute. This prevents "Apple Chancery" from being classified as fixed. (InitFontFamilies): Only get the font families once. @@ -360,19 +366,19 @@ * macosx/tkMacOSXWm.c (TkMacOSXGrowToplevel): ensure QD port is set correctly before using API relying on it. - + 2006-04-06 Vince Darley - * macosx/tkMacOSXMouseEvent.c: now that [wm attributes -titlepath] - works correctly, add OS support for dragging proxy icons and - using the titlepath menu. + * macosx/tkMacOSXMouseEvent.c: Now that [wm attributes -titlepath] + works correctly, add OS support for dragging proxy icons and using the + titlepath menu. 2006-04-06 Daniel Steffen - * macosx/tkMacOSXWm.c (WmAttributesCmd, WmIconbitmapCmd): fix errors - in setting/removing window proxy icons via [wm attributes -titlepath] - and [wm iconbitmap], use HIWindow API on Tiger or later. [Bug 1455241] - + * macosx/tkMacOSXWm.c (WmAttributesCmd, WmIconbitmapCmd): fix errors in + setting/removing window proxy icons via [wm attributes -titlepath] and + [wm iconbitmap], use HIWindow API on Tiger or later. [Bug 1455241] + * unix/tcl.m4: remove TCL_IO_TRACK_OS_FOR_DRIVER_WITH_BAD_BLOCKING define on Darwin. [Tcl Bug 1457515] * unix/configure: autoconf-2.59 @@ -383,23 +389,23 @@ * generic/tkWindow.c (Initialize): remove impotent use of DeleteWindowsExitProc as a global exit handler. - * generic/tkMenu.c (TkSetWindowMenuBar): remove extra TkMenuInit - call that caused finalization panic. [Bug 1456851] - * win/tkWinMenu.c (FreeID, TkpNewMenu, MenuExitHandler) - (MenuThreadExitHandler, TkpMenuInit, TkpMenuThreadInit): rework - Windows menu init/finalization to better respect per-process and - per-thread boundaries. [Bug 1456851] - (TkWinMenuKeyObjCmd): Do not error when unknown window is passed - in. [Bug 1236306] + * generic/tkMenu.c (TkSetWindowMenuBar): remove extra TkMenuInit call + that caused finalization panic. [Bug 1456851] + * win/tkWinMenu.c (FreeID, TkpNewMenu, MenuExitHandler) + (MenuThreadExitHandler, TkpMenuInit, TkpMenuThreadInit): rework Windows + menu init/finalization to better respect per-process and per-thread + boundaries. [Bug 1456851] + (TkWinMenuKeyObjCmd): Do not error when unknown window is passed in. + [Bug 1236306] - * win/tkWinX.c (TkWinXInit): init default keyboard charset - correctly. [Bug 1374119] (pajas) + * win/tkWinX.c (TkWinXInit): init default keyboard charset correctly. + [Bug 1374119] (pajas) * win/tkWinWm.c (WmProc): pass WM_QUERYENDSESSION message to Tk as WM_SAVE_YOURSELF wm protocol callback. - * tests/textWind.test (textWind-10.6.1): prevent infinite update - loop in case of test failure + * tests/textWind.test (textWind-10.6.1): prevent infinite update loop + in case of test failure. * tests/wm.test (wm-attributes-1.2.4): correct expected result. @@ -408,14 +414,14 @@ 2006-04-05 Vince Darley - * generic/tkText.c: fix to crash caused on some platforms - by new tests introduced to check for [Bug 1414171], which - destroy the text widget in the dump callback script. + * generic/tkText.c: fix to crash caused on some platforms by new tests + introduced to check for [Bug 1414171], which destroy the text widget in + the dump callback script. 2006-03-29 Jeff Hobbs - * generic/tkOption.c (TkOptionDeadWindow): handle - OptionThreadExitProc being called before DeleteWindowsExitProc. + * generic/tkOption.c (TkOptionDeadWindow): handle OptionThreadExitProc + being called before DeleteWindowsExitProc. * win/Makefile.in: convert _NATIVE paths to use / to avoid ".\" path-as-escape issue. @@ -424,9 +430,9 @@ * changes: Updates for next RC - * unix/tkUnixDefault.h: Changed "Black" to "#000000" and "White" to + * unix/tkUnixDefault.h: Changed "Black" to "#000000" and "White" to "#ffffff" to work around the (broken?) X servers that do not accept - those color names. [Bug 917433] + those color names. [Bug 917433] 2006-03-28 Jeff Hobbs @@ -434,22 +440,22 @@ 2006-03-26 Vince Darley - * generic/tkText.c: - * tests/text.test: Fix for elaborations of [Bug 1414171] for - '$text dump -command