From 09e45d149fcc63d92f4bee4d5db56a420c67d8ad Mon Sep 17 00:00:00 2001 From: jenglish Date: Wed, 17 Feb 2010 20:58:32 +0000 Subject: generic/tkMenu.c: Defer TkMenuOptionTables cleanup to CallWhenDeleted() time, to ensure that the record doesn't get freed until after all widget instance commands have been deleted (Fixes [Bug#2952745]). --- ChangeLog | 7 +++++++ generic/tkMenu.c | 9 +++++---- 2 files changed, 12 insertions(+), 4 deletions(-) diff --git a/ChangeLog b/ChangeLog index 4e26c25..f65795f 100644 --- a/ChangeLog +++ b/ChangeLog @@ -1,3 +1,10 @@ +2010-02-17 Joe English + + * generic/tkMenu.c: Defer TkMenuOptionTables cleanup + to CallWhenDeleted() time, to ensure that the record + doesn't get freed until after all widget instance commands + have been deleted (Fixes [Bug#2952745]). + 2010-02-17 Jan Nijtmans * generic/tk.decls CONSTify everything related to Tk_ConfigSpec diff --git a/generic/tkMenu.c b/generic/tkMenu.c index 8da4cb7..f044370 100644 --- a/generic/tkMenu.c +++ b/generic/tkMenu.c @@ -12,7 +12,7 @@ * See the file "license.terms" for information on usage and redistribution of * this file, and for a DISCLAIMER OF ALL WARRANTIES. * - * RCS: @(#) $Id: tkMenu.c,v 1.58 2010/01/18 20:43:38 nijtmans Exp $ + * RCS: @(#) $Id: tkMenu.c,v 1.59 2010/02/17 20:58:32 jenglish Exp $ */ /* @@ -398,7 +398,8 @@ static const Tk_ClassProcs menuClass = { static void FreeOptionTables( - ClientData clientData) + ClientData clientData, + Tcl_Interp *interp) { ckfree(clientData); } @@ -426,8 +427,8 @@ TkCreateMenuCmd( optionTablesPtr->entryOptionTables[CHECK_BUTTON_ENTRY] = Tk_CreateOptionTable(interp, specsArray[CHECK_BUTTON_ENTRY]); - Tcl_CreateObjCommand(interp, "menu", MenuCmd, optionTablesPtr, - FreeOptionTables); + Tcl_CreateObjCommand(interp, "menu", MenuCmd, optionTablesPtr, 0); + Tcl_CallWhenDeleted(interp, FreeOptionTables, optionTablesPtr); if (Tcl_IsSafe(interp)) { Tcl_HideCommand(interp, "menu", "menu"); -- cgit v0.12