From f3a661b3ff891f2c6dc573d4e84abf1c78048c29 Mon Sep 17 00:00:00 2001 From: jenglish Date: Sun, 4 Nov 2007 23:59:59 +0000 Subject: + Use null "treearea" element for treeview owner-draw area instead of "client", to avoid nameclash with Notebook.client element. This was causing sizing anomalies in XP theme, and introduced extraneous padding. + "alt" theme Treeitem.indicator element needs left margin now. --- ChangeLog | 10 ++++++++++ generic/ttk/ttkDefaultTheme.c | 4 ++-- generic/ttk/ttkTreeview.c | 7 ++++--- 3 files changed, 16 insertions(+), 5 deletions(-) diff --git a/ChangeLog b/ChangeLog index 70b6473..77d6671 100644 --- a/ChangeLog +++ b/ChangeLog @@ -1,3 +1,13 @@ +2007-11-04 Joe English + + * generic/ttk/ttkTreeview.c: Use null "treearea" element for + treeview owner-draw area instead of "client", to avoid + nameclash with Notebook.client element (this was causing + sizing anomalies in XP theme, and introduced extraneous + padding). + * generic/ttk/ttkDefaultTheme.c: Treeitem.indicator element + needs left margin now. + 2007-11-04 Daniel Steffen * macosx/tkMacOSXMenus.c: add "Run Widget Demo" menu item to the diff --git a/generic/ttk/ttkDefaultTheme.c b/generic/ttk/ttkDefaultTheme.c index f73abd8..0e8c35d 100644 --- a/generic/ttk/ttkDefaultTheme.c +++ b/generic/ttk/ttkDefaultTheme.c @@ -1,4 +1,4 @@ -/* $Id: ttkDefaultTheme.c,v 1.8 2007/10/25 07:08:26 jenglish Exp $ +/* $Id: ttkDefaultTheme.c,v 1.9 2007/11/05 00:00:00 jenglish Exp $ * * Copyright (c) 2003, Joe English * @@ -1048,7 +1048,7 @@ static Ttk_ElementOptionSpec TreeitemIndicatorOptions[] = { "-diameter", TK_OPTION_PIXELS, Tk_Offset(TreeitemIndicator,diameterObj), "9" }, { "-indicatormargins", TK_OPTION_STRING, - Tk_Offset(TreeitemIndicator,marginObj), "0 2 4 2" }, + Tk_Offset(TreeitemIndicator,marginObj), "2 2 4 2" }, {NULL} }; diff --git a/generic/ttk/ttkTreeview.c b/generic/ttk/ttkTreeview.c index 9d03683..73928c5 100644 --- a/generic/ttk/ttkTreeview.c +++ b/generic/ttk/ttkTreeview.c @@ -1,4 +1,4 @@ -/* $Id: ttkTreeview.c,v 1.19 2007/10/25 07:08:26 jenglish Exp $ +/* $Id: ttkTreeview.c,v 1.20 2007/11/05 00:00:00 jenglish Exp $ * Copyright (c) 2004, Joe English * * ttk::treeview widget implementation. @@ -1470,7 +1470,7 @@ static Ttk_Layout TreeviewGetLayout( static void TreeviewDoLayout(void *clientData) { Treeview *tv = clientData; - Ttk_LayoutNode *clientNode = Ttk_LayoutFindNode(tv->core.layout, "client"); + Ttk_LayoutNode *clientNode = Ttk_LayoutFindNode(tv->core.layout,"treearea"); int visibleRows; /* ASSERT: SLACKINVARIANT */ @@ -3044,7 +3044,7 @@ static WidgetSpec TreeviewWidgetSpec = TTK_BEGIN_LAYOUT(TreeviewLayout) TTK_GROUP("Treeview.field", TTK_FILL_BOTH|TTK_BORDER, TTK_GROUP("Treeview.padding", TTK_FILL_BOTH, - TTK_NODE("Treeview.client", TTK_FILL_BOTH))) + TTK_NODE("Treeview.treearea", TTK_FILL_BOTH))) TTK_END_LAYOUT TTK_BEGIN_LAYOUT(ItemLayout) @@ -3197,6 +3197,7 @@ void TtkTreeview_Init(Tcl_Interp *interp) &TreeitemIndicatorElementSpec, 0); Ttk_RegisterElement(interp, theme, "Treeitem.row", &RowElementSpec, 0); Ttk_RegisterElement(interp, theme, "Treeheading.cell", &RowElementSpec, 0); + Ttk_RegisterElement(interp, theme, "treearea", &ttkNullElementSpec, 0); Ttk_RegisterLayout(theme, TreeviewWidgetSpec.className, TreeviewLayout); Ttk_RegisterLayout(theme, "Item", ItemLayout); -- cgit v0.12