From 90c1a43eb7a8a363aef33e43ff390646b70aff1f Mon Sep 17 00:00:00 2001 From: patthoyts Date: Thu, 21 May 2009 22:52:06 +0000 Subject: [Bug 2794778]: Calls to CallWindowProc can lead to other functions overwriting the event strucure. Therefore preserve a local copy of the XKeyEvent while looping over the key events. --- ChangeLog | 7 +++++++ win/tkWinMenu.c | 9 +++++---- 2 files changed, 12 insertions(+), 4 deletions(-) diff --git a/ChangeLog b/ChangeLog index f703fb0..5290800 100644 --- a/ChangeLog +++ b/ChangeLog @@ -1,3 +1,10 @@ +2009-05-21 Pat Thoyts + + * win/tkWinMenu.c: [Bug 2794778]: Calls to CallWindowProc can lead + to other functions overwriting the event strucure. Therefore + preserve a local copy of the XKeyEvent while looping over the key + events. + 2009-05-17 Joe English * generic/ttkNotebook.c: More flexible tab placement [Bug 1470246] diff --git a/win/tkWinMenu.c b/win/tkWinMenu.c index 1a54fd7..1909f34 100644 --- a/win/tkWinMenu.c +++ b/win/tkWinMenu.c @@ -10,7 +10,7 @@ * See the file "license.terms" for information on usage and redistribution of * this file, and for a DISCLAIMER OF ALL WARRANTIES. * - * RCS: @(#) $Id: tkWinMenu.c,v 1.66 2009/03/25 23:39:35 nijtmans Exp $ + * RCS: @(#) $Id: tkWinMenu.c,v 1.67 2009/05/21 22:52:06 patthoyts Exp $ */ #define OEMRESOURCE @@ -1982,14 +1982,15 @@ TkWinMenuKeyObjCmd( virtualKey = XKeysymToKeycode(winPtr->display, keySym); scanCode = MapVirtualKey(virtualKey, 0); if (0 != scanCode) { + XKeyEvent xkey = eventPtr->xkey; CallWindowProc(DefWindowProc, Tk_GetHWND(Tk_WindowId(tkwin)), WM_SYSKEYDOWN, virtualKey, (int) ((scanCode << 16) | (1 << 29))); - if (eventPtr->xkey.nbytes > 0) { - for (i = 0; i < eventPtr->xkey.nbytes; i++) { + if (xkey.nbytes > 0) { + for (i = 0; i < xkey.nbytes; i++) { CallWindowProc(DefWindowProc, Tk_GetHWND(Tk_WindowId(tkwin)), WM_SYSCHAR, - eventPtr->xkey.trans_chars[i], + xkey.trans_chars[i], (int) ((scanCode << 16) | (1 << 29))); } } -- cgit v0.12