diff options
| author | Rosen Penev <rosenp@gmail.com> | 2020-06-03 01:23:54 (GMT) |
|---|---|---|
| committer | Rosen Penev <rosenp@gmail.com> | 2020-12-05 23:47:18 (GMT) |
| commit | 7c36b8871ac0cd976461b19b8d302ba58121fbfd (patch) | |
| tree | 165f2b72579169b2fc54e2ac1450ff0b1be5a70d | |
| parent | 7cff4770b553e8a1a1eab9aefe093c6b95bdebb4 (diff) | |
| download | Ninja-7c36b8871ac0cd976461b19b8d302ba58121fbfd.zip Ninja-7c36b8871ac0cd976461b19b8d302ba58121fbfd.tar.gz Ninja-7c36b8871ac0cd976461b19b8d302ba58121fbfd.tar.bz2 | |
[clang-tidy] simplify boolean expression
Found with readability-simplify-boolean-expr
Signed-off-by: Rosen Penev <rosenp@gmail.com>
| -rw-r--r-- | .clang-tidy | 2 | ||||
| -rw-r--r-- | src/manifest_parser.cc | 5 |
2 files changed, 3 insertions, 4 deletions
diff --git a/.clang-tidy b/.clang-tidy index df4c1ed..54f579b 100644 --- a/.clang-tidy +++ b/.clang-tidy @@ -4,10 +4,12 @@ Checks: ' ,readability-non-const-parameter, ,readability-redundant-string-cstr, ,readability-redundant-string-init, + ,readability-simplify-boolean-expr, ' WarningsAsErrors: ' ,readability-avoid-const-params-in-decls, ,readability-non-const-parameter, ,readability-redundant-string-cstr, ,readability-redundant-string-init, + ,readability-simplify-boolean-expr, ' diff --git a/src/manifest_parser.cc b/src/manifest_parser.cc index 860a8fc..54ad3f4 100644 --- a/src/manifest_parser.cc +++ b/src/manifest_parser.cc @@ -202,10 +202,7 @@ bool ManifestParser::ParseDefault(string* err) { return false; } while (!eval.empty()); - if (!ExpectToken(Lexer::NEWLINE, err)) - return false; - - return true; + return ExpectToken(Lexer::NEWLINE, err); } bool ManifestParser::ParseEdge(string* err) { |