diff options
| author | William Deegan <bill@baddogconsulting.com> | 2022-06-03 17:30:20 (GMT) |
|---|---|---|
| committer | William Deegan <bill@baddogconsulting.com> | 2022-06-03 17:30:20 (GMT) |
| commit | b511d618966ff82b2200824123793301039cf579 (patch) | |
| tree | 1266a8bae5e90bc177f0efc688c8aa30b009a59e | |
| parent | 6a3f5a7b2d68b062e54269d50385da51e818a089 (diff) | |
| download | SCons-b511d618966ff82b2200824123793301039cf579.zip SCons-b511d618966ff82b2200824123793301039cf579.tar.gz SCons-b511d618966ff82b2200824123793301039cf579.tar.bz2 | |
[ci skip] Add note to handle processes not dying properly by raising exception and handling in calling function
| -rw-r--r-- | SCons/Tool/ninja/NinjaState.py | 2 | ||||
| -rw-r--r-- | SCons/Util.py | 1 |
2 files changed, 3 insertions, 0 deletions
diff --git a/SCons/Tool/ninja/NinjaState.py b/SCons/Tool/ninja/NinjaState.py index c9cacce..c168c7f 100644 --- a/SCons/Tool/ninja/NinjaState.py +++ b/SCons/Tool/ninja/NinjaState.py @@ -643,6 +643,8 @@ class NinjaState: pass # wait for the server process to fully killed + # TODO: update wait_for_process_to_die() to handle timeout and then catch exception + # here and do something smart. wait_for_process_to_die(pid) if os.path.exists(scons_daemon_dirty): diff --git a/SCons/Util.py b/SCons/Util.py index 0eeef2a..49a3a0f 100644 --- a/SCons/Util.py +++ b/SCons/Util.py @@ -2129,6 +2129,7 @@ def wait_for_process_to_die(pid): """ Wait for specified process to die, or alternatively kill it NOTE: This function operates best with psutil pypi package + TODO: Add timeout which raises exception """ # wait for the process to fully killed try: |