summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorSerhiy Storchaka <storchaka@gmail.com>2012-12-28 08:02:42 (GMT)
committerSerhiy Storchaka <storchaka@gmail.com>2012-12-28 08:02:42 (GMT)
commit00e284311565c2caeadd10faa75cbe261b71bdaf (patch)
tree7146794182c585f8cb1f0a12049f5074c8035503
parent28441e353cbe95e1b2e26eb08d7b1969ca26d261 (diff)
parent0b386d524765d875fd5f7b6150219e5e5cd69abf (diff)
downloadcpython-00e284311565c2caeadd10faa75cbe261b71bdaf.zip
cpython-00e284311565c2caeadd10faa75cbe261b71bdaf.tar.gz
cpython-00e284311565c2caeadd10faa75cbe261b71bdaf.tar.bz2
Issue #16761: Raise TypeError when int() called with base argument only.
-rw-r--r--Lib/test/test_int.py12
-rw-r--r--Misc/NEWS3
-rw-r--r--Objects/longobject.c10
3 files changed, 13 insertions, 12 deletions
diff --git a/Lib/test/test_int.py b/Lib/test/test_int.py
index 52705de..c35a42f 100644
--- a/Lib/test/test_int.py
+++ b/Lib/test/test_int.py
@@ -233,16 +233,8 @@ class IntTestCases(unittest.TestCase):
self.assertEqual(int(x=1.2), 1)
self.assertEqual(int('100', base=2), 4)
self.assertEqual(int(x='100', base=2), 4)
-
- # For example, PyPy 1.9.0 raised TypeError for these cases because it
- # expects x to be a string if base is given.
- @support.cpython_only
- def test_base_arg_with_no_x_arg(self):
- self.assertEqual(int(base=6), 0)
- # Even invalid bases don't raise an exception.
- self.assertEqual(int(base=1), 0)
- self.assertEqual(int(base=1000), 0)
- self.assertEqual(int(base='foo'), 0)
+ self.assertRaises(TypeError, int, base=10)
+ self.assertRaises(TypeError, int, base=0)
def test_non_numeric_input_types(self):
# Test possible non-numeric types for the argument x, including
diff --git a/Misc/NEWS b/Misc/NEWS
index 521f749..ce906a0 100644
--- a/Misc/NEWS
+++ b/Misc/NEWS
@@ -12,6 +12,9 @@ What's New in Python 3.3.1?
Core and Builtins
-----------------
+- Issue #16761: Calling ``int()`` with *base* argument only now raises
+ TypeError.
+
- Issue #16759: Support the full DWORD (unsigned long) range in Reg2Py
when retreiving a REG_DWORD value. This corrects functions like
winreg.QueryValueEx that may have been returning truncated values.
diff --git a/Objects/longobject.c b/Objects/longobject.c
index 87150a9..9535830 100644
--- a/Objects/longobject.c
+++ b/Objects/longobject.c
@@ -4267,8 +4267,14 @@ long_new(PyTypeObject *type, PyObject *args, PyObject *kwds)
if (!PyArg_ParseTupleAndKeywords(args, kwds, "|OO:int", kwlist,
&x, &obase))
return NULL;
- if (x == NULL)
+ if (x == NULL) {
+ if (obase != NULL) {
+ PyErr_SetString(PyExc_TypeError,
+ "int() missing string argument");
+ return NULL;
+ }
return PyLong_FromLong(0L);
+ }
if (obase == NULL)
return PyNumber_Long(x);
@@ -4277,7 +4283,7 @@ long_new(PyTypeObject *type, PyObject *args, PyObject *kwds)
return NULL;
if (overflow || (base != 0 && base < 2) || base > 36) {
PyErr_SetString(PyExc_ValueError,
- "int() arg 2 must be >= 2 and <= 36");
+ "int() base must be >= 2 and <= 36");
return NULL;
}