summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorBatuhan Taskaya <isidentical@gmail.com>2022-11-22 10:41:14 (GMT)
committerGitHub <noreply@github.com>2022-11-22 10:41:14 (GMT)
commit1acdfec359fdf3db936168480be0f4157273c200 (patch)
treeecc1f515cee2ebfe1e5f740af7b828775a8fd7e2
parentbc3a11d21ddef28047b18c0f6a5068fa9fb16da2 (diff)
downloadcpython-1acdfec359fdf3db936168480be0f4157273c200.zip
cpython-1acdfec359fdf3db936168480be0f4157273c200.tar.gz
cpython-1acdfec359fdf3db936168480be0f4157273c200.tar.bz2
gh-99341: Cover type ignore nodes when incrementing line numbers (GH-99422)
-rw-r--r--Lib/ast.py6
-rw-r--r--Lib/test/test_ast.py12
-rw-r--r--Misc/NEWS.d/next/Library/2022-11-13-02-06-56.gh-issue-99341.8-OlwB.rst2
3 files changed, 20 insertions, 0 deletions
diff --git a/Lib/ast.py b/Lib/ast.py
index 1a94e93..2cbc80a 100644
--- a/Lib/ast.py
+++ b/Lib/ast.py
@@ -237,6 +237,12 @@ def increment_lineno(node, n=1):
location in a file.
"""
for child in walk(node):
+ # TypeIgnore is a special case where lineno is not an attribute
+ # but rather a field of the node itself.
+ if isinstance(child, TypeIgnore):
+ child.lineno = getattr(child, 'lineno', 0) + n
+ continue
+
if 'lineno' in child._attributes:
child.lineno = getattr(child, 'lineno', 0) + n
if (
diff --git a/Lib/test/test_ast.py b/Lib/test/test_ast.py
index b346441..773fba8 100644
--- a/Lib/test/test_ast.py
+++ b/Lib/test/test_ast.py
@@ -1036,6 +1036,18 @@ Module(
self.assertEqual(ast.increment_lineno(src).lineno, 2)
self.assertIsNone(ast.increment_lineno(src).end_lineno)
+ def test_increment_lineno_on_module(self):
+ src = ast.parse(dedent("""\
+ a = 1
+ b = 2 # type: ignore
+ c = 3
+ d = 4 # type: ignore@tag
+ """), type_comments=True)
+ ast.increment_lineno(src, n=5)
+ self.assertEqual(src.type_ignores[0].lineno, 7)
+ self.assertEqual(src.type_ignores[1].lineno, 9)
+ self.assertEqual(src.type_ignores[1].tag, '@tag')
+
def test_iter_fields(self):
node = ast.parse('foo()', mode='eval')
d = dict(ast.iter_fields(node.body))
diff --git a/Misc/NEWS.d/next/Library/2022-11-13-02-06-56.gh-issue-99341.8-OlwB.rst b/Misc/NEWS.d/next/Library/2022-11-13-02-06-56.gh-issue-99341.8-OlwB.rst
new file mode 100644
index 0000000..451561c
--- /dev/null
+++ b/Misc/NEWS.d/next/Library/2022-11-13-02-06-56.gh-issue-99341.8-OlwB.rst
@@ -0,0 +1,2 @@
+Fix :func:`ast.increment_lineno` to also cover :class:`ast.TypeIgnore` when
+changing line numbers.