diff options
| author | Ned Deily <nad@python.org> | 2017-03-04 11:19:05 (GMT) |
|---|---|---|
| committer | GitHub <noreply@github.com> | 2017-03-04 11:19:05 (GMT) |
| commit | 1d391f926b37484b8d4b326003a72c0084db19ec (patch) | |
| tree | 6238a22e389ef3823e85be206cb7a7b2db99f290 | |
| parent | 343d48379c31f31cb0bcc843c537990c4283703d (diff) | |
| download | cpython-1d391f926b37484b8d4b326003a72c0084db19ec.zip cpython-1d391f926b37484b8d4b326003a72c0084db19ec.tar.gz cpython-1d391f926b37484b8d4b326003a72c0084db19ec.tar.bz2 | |
[3.6] bpo-28087: Skip test_asyncore and test_eintr poll failures on macOS (#463)
Skip some tests of select.poll when running on macOS due to unresolved
issues with the underlying system poll function on some macOS versions.
(cherry picked from commit de04644627f82d9dc48b3423def7ff5b4aa1926a)
| -rw-r--r-- | Lib/test/eintrdata/eintr_tester.py | 2 | ||||
| -rw-r--r-- | Lib/test/test_asyncore.py | 3 | ||||
| -rw-r--r-- | Misc/NEWS | 4 |
3 files changed, 9 insertions, 0 deletions
diff --git a/Lib/test/eintrdata/eintr_tester.py b/Lib/test/eintrdata/eintr_tester.py index d194e77..c619b3d 100644 --- a/Lib/test/eintrdata/eintr_tester.py +++ b/Lib/test/eintrdata/eintr_tester.py @@ -437,6 +437,8 @@ class SelectEINTRTest(EINTRBaseTest): self.stop_alarm() self.assertGreaterEqual(dt, self.sleep_time) + @unittest.skipIf(sys.platform == "darwin", + "poll may fail on macOS; see issue #28087") @unittest.skipUnless(hasattr(select, 'poll'), 'need select.poll') def test_poll(self): poller = select.poll() diff --git a/Lib/test/test_asyncore.py b/Lib/test/test_asyncore.py index 51c6573..d05462b 100644 --- a/Lib/test/test_asyncore.py +++ b/Lib/test/test_asyncore.py @@ -661,6 +661,9 @@ class BaseTestAPI: if HAS_UNIX_SOCKETS and self.family == socket.AF_UNIX: self.skipTest("Not applicable to AF_UNIX sockets.") + if sys.platform == "darwin" and self.use_poll: + self.skipTest("poll may fail on macOS; see issue #28087") + class TestClient(BaseClient): def handle_expt(self): self.socket.recv(1024, socket.MSG_OOB) @@ -261,6 +261,10 @@ Documentation Tests ----- +- bpo-28087: Skip test_asyncore and test_eintr poll failures on macOS. + Skip some tests of select.poll when running on macOS due to unresolved + issues with the underlying system poll function on some macOS versions. + - Issue #29571: to match the behaviour of the ``re.LOCALE`` flag, test_re.test_locale_flag now uses ``locale.getpreferredencoding(False)`` to determine the candidate encoding for the test regex (allowing it to correctly |