summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorEzio Melotti <ezio.melotti@gmail.com>2013-03-12 23:53:38 (GMT)
committerEzio Melotti <ezio.melotti@gmail.com>2013-03-12 23:53:38 (GMT)
commit220391fa6e08c79116522a9e00e1089e7ccaf963 (patch)
tree1e929abd36192434c559246d38b0b667a387b165
parent72cdb5c39e8221e04aa858a1e5f48b02014aa2b0 (diff)
parenta7d64a6f4c0307f9c58ea170705b1552580d93eb (diff)
downloadcpython-220391fa6e08c79116522a9e00e1089e7ccaf963.zip
cpython-220391fa6e08c79116522a9e00e1089e7ccaf963.tar.gz
cpython-220391fa6e08c79116522a9e00e1089e7ccaf963.tar.bz2
#17368: merge with 3.2.
-rw-r--r--Lib/json/decoder.py2
-rw-r--r--Lib/test/json_tests/test_decode.py14
-rw-r--r--Misc/NEWS4
3 files changed, 15 insertions, 5 deletions
diff --git a/Lib/json/decoder.py b/Lib/json/decoder.py
index 288686a..51c3aa7 100644
--- a/Lib/json/decoder.py
+++ b/Lib/json/decoder.py
@@ -166,7 +166,7 @@ def JSONObject(s_and_end, strict, scan_once, object_hook, object_pairs_hook,
if nextchar == '}':
if object_pairs_hook is not None:
result = object_pairs_hook(pairs)
- return result, end
+ return result, end + 1
pairs = {}
if object_hook is not None:
pairs = object_hook(pairs)
diff --git a/Lib/test/json_tests/test_decode.py b/Lib/test/json_tests/test_decode.py
index 0a55a33..15a427f 100644
--- a/Lib/test/json_tests/test_decode.py
+++ b/Lib/test/json_tests/test_decode.py
@@ -25,16 +25,22 @@ class TestDecode:
p = [("xkd", 1), ("kcw", 2), ("art", 3), ("hxm", 4),
("qrt", 5), ("pad", 6), ("hoy", 7)]
self.assertEqual(self.loads(s), eval(s))
- self.assertEqual(self.loads(s, object_pairs_hook = lambda x: x), p)
+ self.assertEqual(self.loads(s, object_pairs_hook=lambda x: x), p)
self.assertEqual(self.json.load(StringIO(s),
object_pairs_hook=lambda x: x), p)
- od = self.loads(s, object_pairs_hook = OrderedDict)
+ od = self.loads(s, object_pairs_hook=OrderedDict)
self.assertEqual(od, OrderedDict(p))
self.assertEqual(type(od), OrderedDict)
# the object_pairs_hook takes priority over the object_hook
- self.assertEqual(self.loads(s, object_pairs_hook = OrderedDict,
- object_hook = lambda x: None),
+ self.assertEqual(self.loads(s, object_pairs_hook=OrderedDict,
+ object_hook=lambda x: None),
OrderedDict(p))
+ # check that empty objects literals work (see #17368)
+ self.assertEqual(self.loads('{}', object_pairs_hook=OrderedDict),
+ OrderedDict())
+ self.assertEqual(self.loads('{"empty": {}}',
+ object_pairs_hook=OrderedDict),
+ OrderedDict([('empty', OrderedDict())]))
def test_decoder_optimizations(self):
# Several optimizations were made that skip over calls to
diff --git a/Misc/NEWS b/Misc/NEWS
index fd10f5c..1b561df 100644
--- a/Misc/NEWS
+++ b/Misc/NEWS
@@ -193,6 +193,10 @@ Core and Builtins
Library
-------
+- Issue #17368: Fix an off-by-one error in the Python JSON decoder that caused
+ a failure while decoding empty object literals when object_pairs_hook was
+ specified.
+
- Issue #14645: The email generator classes now produce output using the
specified linesep throughout. Previously if the prolog, epilog, or
body were stored with a different linesep, that linesep was used. This