diff options
author | Mario Corchero <mcorcherojim@bloomberg.net> | 2023-07-06 17:54:45 (GMT) |
---|---|---|
committer | GitHub <noreply@github.com> | 2023-07-06 17:54:45 (GMT) |
commit | 56353b10023ff12c7c8d6288ae4bf7bdcd5d4b6c (patch) | |
tree | 137a57cf721462c57d0380fcfa0f871b2ac0c043 | |
parent | e7cd55753b00d6f7e5c8998bae73ebaa9e86398d (diff) | |
download | cpython-56353b10023ff12c7c8d6288ae4bf7bdcd5d4b6c.zip cpython-56353b10023ff12c7c8d6288ae4bf7bdcd5d4b6c.tar.gz cpython-56353b10023ff12c7c8d6288ae4bf7bdcd5d4b6c.tar.bz2 |
gh-106458: Mark `testthreadingmock.py` with `@requires_working_threading` (GH-106366)
Mark `testthreadingmock.py` with `threading_helper.requires_working_threading`.
Also add longer delays to reduce the change of a race conditions on the tests that validate short timeouts.
-rw-r--r-- | Lib/test/test_unittest/testmock/testthreadingmock.py | 20 |
1 files changed, 11 insertions, 9 deletions
diff --git a/Lib/test/test_unittest/testmock/testthreadingmock.py b/Lib/test/test_unittest/testmock/testthreadingmock.py index 2b4dca3..c6f1794 100644 --- a/Lib/test/test_unittest/testmock/testthreadingmock.py +++ b/Lib/test/test_unittest/testmock/testthreadingmock.py @@ -2,9 +2,13 @@ import time import unittest import concurrent.futures +from test.support import threading_helper from unittest.mock import patch, ThreadingMock, call +threading_helper.requires_working_threading(module=True) + + class Something: def method_1(self): pass @@ -133,11 +137,9 @@ class TestThreadingMock(unittest.TestCase): with patch(f"{__name__}.Something", waitable_mock): something = Something() - self.run_async(something.method_1, delay=0.1) + self.run_async(something.method_1, delay=0.5) with self.assertRaises(AssertionError): something.method_1.wait_until_called(timeout=0.05) - with self.assertRaises(AssertionError): - something.method_1.wait_until_any_call_with(timeout=0.05) def test_wait_success_called_before(self): waitable_mock = self._make_mock() @@ -163,10 +165,10 @@ class TestThreadingMock(unittest.TestCase): with patch(f"{__name__}.Something", waitable_mock): something = Something() - self.run_async(something.method_1, 1, delay=0.1) - self.run_async(something.method_1, 2, delay=0.2) - self.run_async(something.method_1, 3, delay=0.3) + self.run_async(something.method_1, 1, delay=0.2) self.assertNotIn(call(1), something.method_1.mock_calls) + self.run_async(something.method_1, 2, delay=0.5) + self.run_async(something.method_1, 3, delay=0.6) something.method_1.wait_until_any_call_with(1) something.method_1.assert_called_with(1) @@ -182,10 +184,10 @@ class TestThreadingMock(unittest.TestCase): with patch(f"{__name__}.Something", waitable_mock): something = Something() - self.run_async(something.method_1, a=1, delay=0.1) - self.run_async(something.method_1, b=2, delay=0.2) - self.run_async(something.method_1, c=3, delay=0.3) + self.run_async(something.method_1, a=1, delay=0.2) self.assertNotIn(call(a=1), something.method_1.mock_calls) + self.run_async(something.method_1, b=2, delay=0.5) + self.run_async(something.method_1, c=3, delay=0.6) something.method_1.wait_until_any_call_with(a=1) something.method_1.assert_called_with(a=1) |