diff options
author | Miss Islington (bot) <31488909+miss-islington@users.noreply.github.com> | 2019-10-13 12:04:05 (GMT) |
---|---|---|
committer | GitHub <noreply@github.com> | 2019-10-13 12:04:05 (GMT) |
commit | 6da52ac411947d1a7958bbad831fcf8dfc8c95fe (patch) | |
tree | d72f830cb7de4d7b089a3061f1cebd7301b95862 | |
parent | ba44ea6ff8be2b7874c4358f89d5b6f4a558f711 (diff) | |
download | cpython-6da52ac411947d1a7958bbad831fcf8dfc8c95fe.zip cpython-6da52ac411947d1a7958bbad831fcf8dfc8c95fe.tar.gz cpython-6da52ac411947d1a7958bbad831fcf8dfc8c95fe.tar.bz2 |
bpo-38431: Fix __repr__ method of InitVar to work with typing objects. (GH-16702)
(cherry picked from commit 793cb85437299a3da3d74fe65480d720af330cbb)
Co-authored-by: Samuel Colvin <samcolvin@gmail.com>
-rw-r--r-- | Lib/dataclasses.py | 7 | ||||
-rwxr-xr-x | Lib/test/test_dataclasses.py | 2 | ||||
-rw-r--r-- | Misc/NEWS.d/next/Library/2019-10-10-16-53-00.bpo-38431.d5wzNp.rst | 1 |
3 files changed, 9 insertions, 1 deletions
diff --git a/Lib/dataclasses.py b/Lib/dataclasses.py index 2f0e5ff..391f32e 100644 --- a/Lib/dataclasses.py +++ b/Lib/dataclasses.py @@ -210,7 +210,12 @@ class InitVar(metaclass=_InitVarMeta): self.type = type def __repr__(self): - return f'dataclasses.InitVar[{self.type.__name__}]' + if isinstance(self.type, type): + type_name = self.type.__name__ + else: + # typing objects, e.g. List[int] + type_name = repr(self.type) + return f'dataclasses.InitVar[{type_name}]' # Instances of Field are only ever created from within this module, diff --git a/Lib/test/test_dataclasses.py b/Lib/test/test_dataclasses.py index 0885c97..b018133 100755 --- a/Lib/test/test_dataclasses.py +++ b/Lib/test/test_dataclasses.py @@ -1102,6 +1102,8 @@ class TestCase(unittest.TestCase): # Make sure the repr is correct. self.assertEqual(repr(InitVar[int]), 'dataclasses.InitVar[int]') + self.assertEqual(repr(InitVar[List[int]]), + 'dataclasses.InitVar[typing.List[int]]') def test_init_var_inheritance(self): # Note that this deliberately tests that a dataclass need not diff --git a/Misc/NEWS.d/next/Library/2019-10-10-16-53-00.bpo-38431.d5wzNp.rst b/Misc/NEWS.d/next/Library/2019-10-10-16-53-00.bpo-38431.d5wzNp.rst new file mode 100644 index 0000000..c2f860d --- /dev/null +++ b/Misc/NEWS.d/next/Library/2019-10-10-16-53-00.bpo-38431.d5wzNp.rst @@ -0,0 +1 @@ +Fix ``__repr__`` method for :class:`dataclasses.InitVar` to support typing objects, patch by Samuel Colvin. |