summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorBenjamin Peterson <benjamin@python.org>2017-10-06 04:15:14 (GMT)
committerGitHub <noreply@github.com>2017-10-06 04:15:14 (GMT)
commit7faf7e50757dde2cb8583ee08ef31f4b8312e44f (patch)
tree40329c060cb97d0d30919b4ea62ba9ef836b8dc7
parentac317700ce7439e38a8b420218d9a5035bba92ed (diff)
downloadcpython-7faf7e50757dde2cb8583ee08ef31f4b8312e44f.zip
cpython-7faf7e50757dde2cb8583ee08ef31f4b8312e44f.tar.gz
cpython-7faf7e50757dde2cb8583ee08ef31f4b8312e44f.tar.bz2
closes bpo-31696: don't mention GCC in sys.version when building with clang (#3891)
-rw-r--r--Misc/NEWS.d/next/Build/2017-10-04-23-40-32.bpo-31696.Y3_aBV.rst2
-rw-r--r--Python/getcompiler.c15
2 files changed, 9 insertions, 8 deletions
diff --git a/Misc/NEWS.d/next/Build/2017-10-04-23-40-32.bpo-31696.Y3_aBV.rst b/Misc/NEWS.d/next/Build/2017-10-04-23-40-32.bpo-31696.Y3_aBV.rst
new file mode 100644
index 0000000..00aae0b
--- /dev/null
+++ b/Misc/NEWS.d/next/Build/2017-10-04-23-40-32.bpo-31696.Y3_aBV.rst
@@ -0,0 +1,2 @@
+Improve compiler version information in :data:`sys.version` when Python is
+built with Clang.
diff --git a/Python/getcompiler.c b/Python/getcompiler.c
index 9d9c33a..59c0dbf 100644
--- a/Python/getcompiler.c
+++ b/Python/getcompiler.c
@@ -5,15 +5,14 @@
#ifndef COMPILER
-#ifdef __GNUC__
+// Note the __clang__ conditional has to come before the __GNUC__ one because
+// clang pretends to be GCC.
+#if defined(__clang__)
+#define COMPILER "\n[Clang " __clang_version__ "]"
+#elif defined(__GNUC__)
#define COMPILER "\n[GCC " __VERSION__ "]"
-#endif
-
-#endif /* !COMPILER */
-
-#ifndef COMPILER
-
-#ifdef __cplusplus
+// Generic fallbacks.
+#elif defined(__cplusplus)
#define COMPILER "[C++]"
#else
#define COMPILER "[C]"