summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorGreg Price <gnprice@gmail.com>2019-08-21 04:53:59 (GMT)
committerMiss Islington (bot) <31488909+miss-islington@users.noreply.github.com>2019-08-21 04:53:59 (GMT)
commit9ece4a5057d52c42a8a064a6c0c7f923267fb3db (patch)
treeb5966d4146b545743bbe993a6894b197cd5f3d78
parent5b95a1507e349da5adae6d2ab57deac3bdd12f15 (diff)
downloadcpython-9ece4a5057d52c42a8a064a6c0c7f923267fb3db.zip
cpython-9ece4a5057d52c42a8a064a6c0c7f923267fb3db.tar.gz
cpython-9ece4a5057d52c42a8a064a6c0c7f923267fb3db.tar.bz2
Unmark files as executable that can't actually be executed. (GH-15353)
There are plenty of legitimate scripts in the tree that begin with a `#!`, but also a few that seem to be marked executable by mistake. Found them with this command -- it gets executable files known to Git, filters to the ones that don't start with a `#!`, and then unmarks them as executable: $ git ls-files --stage \ | perl -lane 'print $F[3] if (!/^100644/)' \ | while read f; do head -c2 "$f" | grep -qxF '#!' \ || chmod a-x "$f"; \ done Looking at the list by hand confirms that we didn't sweep up any files that should have the executable bit after all. In particular * The `.psd` files are images from Photoshop. * The `.bat` files sure look like things that can be run. But we have lots of other `.bat` files, and they don't have this bit set, so it must not be needed for them. Automerge-Triggered-By: @benjaminp
-rwxr-xr-x.azure-pipelines/posix-deps-apt.sh1
-rw-r--r--[-rwxr-xr-x]Doc/c-api/buffer.rst0
-rw-r--r--[-rwxr-xr-x]Include/cpython/abstract.h0
-rw-r--r--[-rwxr-xr-x]Lib/idlelib/idle.bat0
-rw-r--r--[-rwxr-xr-x]Lib/test/test_buffer.py0
-rw-r--r--[-rwxr-xr-x]Lib/test/test_dataclasses.py0
-rw-r--r--[-rwxr-xr-x]Lib/test/test_importlib/test_abc.py0
-rw-r--r--[-rwxr-xr-x]Lib/turtledemo/two_canvases.py0
-rw-r--r--[-rwxr-xr-x]Mac/Resources/iconsrc/PythonCompiled.psdbin76118 -> 76118 bytes
-rw-r--r--[-rwxr-xr-x]Mac/Resources/iconsrc/PythonIcon.psdbin67236 -> 67236 bytes
-rw-r--r--[-rwxr-xr-x]Mac/Resources/iconsrc/PythonSource.psdbin62075 -> 62075 bytes
-rw-r--r--[-rwxr-xr-x]Misc/NEWS.d/next/Documentation/2019-04-02-19-23-00.bpo-36487.Jg6-MG.rst0
-rw-r--r--[-rwxr-xr-x]Modules/_decimal/tests/runall.bat0
-rw-r--r--[-rwxr-xr-x]Modules/_testcapimodule.c0
-rw-r--r--[-rwxr-xr-x]Modules/socketmodule.c0
-rw-r--r--[-rwxr-xr-x]Modules/socketmodule.h0
16 files changed, 1 insertions, 0 deletions
diff --git a/.azure-pipelines/posix-deps-apt.sh b/.azure-pipelines/posix-deps-apt.sh
index 4f48990..e0f4ca5 100755
--- a/.azure-pipelines/posix-deps-apt.sh
+++ b/.azure-pipelines/posix-deps-apt.sh
@@ -1,3 +1,4 @@
+#!/bin/sh
apt-get update
apt-get -yq install \
diff --git a/Doc/c-api/buffer.rst b/Doc/c-api/buffer.rst
index 2536c74..2536c74 100755..100644
--- a/Doc/c-api/buffer.rst
+++ b/Doc/c-api/buffer.rst
diff --git a/Include/cpython/abstract.h b/Include/cpython/abstract.h
index 04e4a9e..04e4a9e 100755..100644
--- a/Include/cpython/abstract.h
+++ b/Include/cpython/abstract.h
diff --git a/Lib/idlelib/idle.bat b/Lib/idlelib/idle.bat
index e77b96e..e77b96e 100755..100644
--- a/Lib/idlelib/idle.bat
+++ b/Lib/idlelib/idle.bat
diff --git a/Lib/test/test_buffer.py b/Lib/test/test_buffer.py
index 5fa52bf..5fa52bf 100755..100644
--- a/Lib/test/test_buffer.py
+++ b/Lib/test/test_buffer.py
diff --git a/Lib/test/test_dataclasses.py b/Lib/test/test_dataclasses.py
index 037bf4c..037bf4c 100755..100644
--- a/Lib/test/test_dataclasses.py
+++ b/Lib/test/test_dataclasses.py
diff --git a/Lib/test/test_importlib/test_abc.py b/Lib/test/test_importlib/test_abc.py
index 9816b35..9816b35 100755..100644
--- a/Lib/test/test_importlib/test_abc.py
+++ b/Lib/test/test_importlib/test_abc.py
diff --git a/Lib/turtledemo/two_canvases.py b/Lib/turtledemo/two_canvases.py
index d579876..d579876 100755..100644
--- a/Lib/turtledemo/two_canvases.py
+++ b/Lib/turtledemo/two_canvases.py
diff --git a/Mac/Resources/iconsrc/PythonCompiled.psd b/Mac/Resources/iconsrc/PythonCompiled.psd
index 61fc4d1..61fc4d1 100755..100644
--- a/Mac/Resources/iconsrc/PythonCompiled.psd
+++ b/Mac/Resources/iconsrc/PythonCompiled.psd
Binary files differ
diff --git a/Mac/Resources/iconsrc/PythonIcon.psd b/Mac/Resources/iconsrc/PythonIcon.psd
index d818dc6..d818dc6 100755..100644
--- a/Mac/Resources/iconsrc/PythonIcon.psd
+++ b/Mac/Resources/iconsrc/PythonIcon.psd
Binary files differ
diff --git a/Mac/Resources/iconsrc/PythonSource.psd b/Mac/Resources/iconsrc/PythonSource.psd
index eba8f28..eba8f28 100755..100644
--- a/Mac/Resources/iconsrc/PythonSource.psd
+++ b/Mac/Resources/iconsrc/PythonSource.psd
Binary files differ
diff --git a/Misc/NEWS.d/next/Documentation/2019-04-02-19-23-00.bpo-36487.Jg6-MG.rst b/Misc/NEWS.d/next/Documentation/2019-04-02-19-23-00.bpo-36487.Jg6-MG.rst
index c8eb05b..c8eb05b 100755..100644
--- a/Misc/NEWS.d/next/Documentation/2019-04-02-19-23-00.bpo-36487.Jg6-MG.rst
+++ b/Misc/NEWS.d/next/Documentation/2019-04-02-19-23-00.bpo-36487.Jg6-MG.rst
diff --git a/Modules/_decimal/tests/runall.bat b/Modules/_decimal/tests/runall.bat
index 5bc872a..5bc872a 100755..100644
--- a/Modules/_decimal/tests/runall.bat
+++ b/Modules/_decimal/tests/runall.bat
diff --git a/Modules/_testcapimodule.c b/Modules/_testcapimodule.c
index 84f2651..84f2651 100755..100644
--- a/Modules/_testcapimodule.c
+++ b/Modules/_testcapimodule.c
diff --git a/Modules/socketmodule.c b/Modules/socketmodule.c
index d4f2098..d4f2098 100755..100644
--- a/Modules/socketmodule.c
+++ b/Modules/socketmodule.c
diff --git a/Modules/socketmodule.h b/Modules/socketmodule.h
index 3d95fe7..3d95fe7 100755..100644
--- a/Modules/socketmodule.h
+++ b/Modules/socketmodule.h