summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorMiss Islington (bot) <31488909+miss-islington@users.noreply.github.com>2018-05-26 21:57:59 (GMT)
committerGitHub <noreply@github.com>2018-05-26 21:57:59 (GMT)
commitae27dee0f8f364f0bbb170d918a28b87cd0753d9 (patch)
treed989f4606c64fe1f3c28acebe117566e78420a43
parent717204ffcccfe04a34b6c4a52f0e844fde3cdebe (diff)
downloadcpython-ae27dee0f8f364f0bbb170d918a28b87cd0753d9.zip
cpython-ae27dee0f8f364f0bbb170d918a28b87cd0753d9.tar.gz
cpython-ae27dee0f8f364f0bbb170d918a28b87cd0753d9.tar.bz2
bpo-33655: Also ignore test_posix_fallocate failures on BSD platforms (GH-7134)
The failure may be due to the use oF ZFS, a case we already ignore for Solaris-based systems where ZFS is frequently used. (cherry picked from commit 09c4a7dee2eb39b515e5f499f184257cdbe9cb42) Co-authored-by: Ned Deily <nad@python.org>
-rw-r--r--Lib/test/test_posix.py7
-rw-r--r--Misc/NEWS.d/next/Tests/2018-05-26-16-01-40.bpo-33655.Frb4LA.rst2
2 files changed, 8 insertions, 1 deletions
diff --git a/Lib/test/test_posix.py b/Lib/test/test_posix.py
index 296e328..eb3ef84 100644
--- a/Lib/test/test_posix.py
+++ b/Lib/test/test_posix.py
@@ -230,7 +230,12 @@ class PosixTester(unittest.TestCase):
except OSError as inst:
# issue10812, ZFS doesn't appear to support posix_fallocate,
# so skip Solaris-based since they are likely to have ZFS.
- if inst.errno != errno.EINVAL or not sys.platform.startswith("sunos"):
+ # issue33655: Also ignore EINVAL on *BSD since ZFS is also
+ # often used there.
+ if inst.errno == errno.EINVAL and sys.platform.startswith(
+ ('sunos', 'freebsd', 'netbsd', 'openbsd', 'gnukfreebsd')):
+ raise unittest.SkipTest("test may fail on ZFS filesystems")
+ else:
raise
finally:
os.close(fd)
diff --git a/Misc/NEWS.d/next/Tests/2018-05-26-16-01-40.bpo-33655.Frb4LA.rst b/Misc/NEWS.d/next/Tests/2018-05-26-16-01-40.bpo-33655.Frb4LA.rst
new file mode 100644
index 0000000..7ed2ea2
--- /dev/null
+++ b/Misc/NEWS.d/next/Tests/2018-05-26-16-01-40.bpo-33655.Frb4LA.rst
@@ -0,0 +1,2 @@
+Ignore test_posix_fallocate failures on BSD platforms that might be due to
+running on ZFS.