diff options
| author | Michael Felt <aixtools@users.noreply.github.com> | 2019-02-14 18:22:35 (GMT) |
|---|---|---|
| committer | Miss Islington (bot) <31488909+miss-islington@users.noreply.github.com> | 2019-02-14 18:22:35 (GMT) |
| commit | b94d4bed67c60834b1a5a0936b8c13934cf3b872 (patch) | |
| tree | f3e776bba6b1b1bcdedef67cbed2c0916c0a5fda | |
| parent | 8a1657b93469580ef345c7c91738587f3d76e87d (diff) | |
| download | cpython-b94d4bed67c60834b1a5a0936b8c13934cf3b872.zip cpython-b94d4bed67c60834b1a5a0936b8c13934cf3b872.tar.gz cpython-b94d4bed67c60834b1a5a0936b8c13934cf3b872.tar.bz2 | |
bpo-35633: test_lockf() fails with "PermissionError: [Errno 13] Permission denied" on AIX (GH-11424)
[bpo-35633](https://bugs.python.org/issue35633): Fix a test regression introduced with [bpo-35189](https://bugs.python.org/issue35189) (PEP 475: fnctl functions are not retried if interrupted (EINTR)).
Not only a blocking IO error needs to be ignored - permission errors also need to be ignored.
p.s. - iirc as a "test" only correction a NEWS item is not required. If this is not correct - just mention, and I'll add a NEWS blurb.
https://bugs.python.org/issue35633
| -rw-r--r-- | Lib/test/eintrdata/eintr_tester.py | 4 |
1 files changed, 4 insertions, 0 deletions
diff --git a/Lib/test/eintrdata/eintr_tester.py b/Lib/test/eintrdata/eintr_tester.py index 25c169b..5f956b5 100644 --- a/Lib/test/eintrdata/eintr_tester.py +++ b/Lib/test/eintrdata/eintr_tester.py @@ -12,6 +12,7 @@ import contextlib import faulthandler import fcntl import os +import platform import select import signal import socket @@ -518,6 +519,9 @@ class FNTLEINTRTest(EINTRBaseTest): self.stop_alarm() proc.wait() + # Issue 35633: See https://bugs.python.org/issue35633#msg333662 + # skip test rather than accept PermissionError from all platforms + @unittest.skipIf(platform.system() == "AIX", "AIX returns PermissionError") def test_lockf(self): self._lock(fcntl.lockf, "lockf") |