summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorR David Murray <rdmurray@bitdance.com>2013-12-17 17:09:46 (GMT)
committerR David Murray <rdmurray@bitdance.com>2013-12-17 17:09:46 (GMT)
commitea76e87cc26727d6ec8a139b3c9411154212e2ea (patch)
treeef4499346553fd6a572c633148f15e890cc9e74f
parent78ad6583d602625320f345b152b0f4f7233e483c (diff)
downloadcpython-ea76e87cc26727d6ec8a139b3c9411154212e2ea.zip
cpython-ea76e87cc26727d6ec8a139b3c9411154212e2ea.tar.gz
cpython-ea76e87cc26727d6ec8a139b3c9411154212e2ea.tar.bz2
20004: Note that the setter in csv.DictReader is broken.
This is a comment in the code because only someone reading the code would try setting fieldnames to None in the first place...
-rw-r--r--Lib/csv.py4
1 files changed, 4 insertions, 0 deletions
diff --git a/Lib/csv.py b/Lib/csv.py
index fc080cc..c155ada 100644
--- a/Lib/csv.py
+++ b/Lib/csv.py
@@ -93,6 +93,10 @@ class DictReader:
self.line_num = self.reader.line_num
return self._fieldnames
+ # Issue 20004: Because DictReader is a classic class, this setter is
+ # ignored. At this point in 2.7's lifecycle, it is too late to change the
+ # base class for fear of breaking working code. If you want to change
+ # fieldnames without overwriting the getter, set _fieldnames directly.
@fieldnames.setter
def fieldnames(self, value):
self._fieldnames = value