summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorBrad King <brad.king@kitware.com>2023-03-28 12:11:00 (GMT)
committerKitware Robot <kwrobot@kitware.com>2023-03-28 12:11:09 (GMT)
commit0b2b89cd93265ca713ae9ee75398e2ee670a7bc3 (patch)
tree16ea7078c8ee62d6d07cab4478beb2d40683dc85
parent3726584a28db07b4c81e1bba7261525d1b9f50fd (diff)
parenta67cd9c39cc82fa934cc047c719fae8995ff215c (diff)
downloadCMake-0b2b89cd93265ca713ae9ee75398e2ee670a7bc3.zip
CMake-0b2b89cd93265ca713ae9ee75398e2ee670a7bc3.tar.gz
CMake-0b2b89cd93265ca713ae9ee75398e2ee670a7bc3.tar.bz2
Merge topic 'mingw-slashes'
a67cd9c39c Ninja: Restore slash style for MinGW tools when extra languages are enabled Acked-by: Kitware Robot <kwrobot@kitware.com> Acked-by: buildbot <buildbot@kitware.com> Merge-request: !8368
-rw-r--r--Source/cmGlobalNinjaGenerator.cxx10
-rw-r--r--Source/cmGlobalNinjaGenerator.h2
2 files changed, 7 insertions, 5 deletions
diff --git a/Source/cmGlobalNinjaGenerator.cxx b/Source/cmGlobalNinjaGenerator.cxx
index 37856d9..052f2e9 100644
--- a/Source/cmGlobalNinjaGenerator.cxx
+++ b/Source/cmGlobalNinjaGenerator.cxx
@@ -949,8 +949,9 @@ void cmGlobalNinjaGenerator::EnableLanguage(
mf->GetSafeDefinition(cmStrCat("CMAKE_", l, "_SIMULATE_ID"));
std::string const& compilerFrontendVariant = mf->GetSafeDefinition(
cmStrCat("CMAKE_", l, "_COMPILER_FRONTEND_VARIANT"));
- this->SetUsingGCCOnWindows(
- DetectGCCOnWindows(compilerId, simulateId, compilerFrontendVariant));
+ if (DetectGCCOnWindows(compilerId, simulateId, compilerFrontendVariant)) {
+ this->MarkAsGCCOnWindows();
+ }
#endif
}
}
@@ -2843,8 +2844,9 @@ int cmcmd_cmake_ninja_dyndep(std::vector<std::string>::const_iterator argBeg,
cmGlobalNinjaGenerator& gg =
cm::static_reference_cast<cmGlobalNinjaGenerator>(ggd);
# ifdef _WIN32
- gg.SetUsingGCCOnWindows(
- DetectGCCOnWindows(compilerId, simulateId, compilerFrontendVariant));
+ if (DetectGCCOnWindows(compilerId, simulateId, compilerFrontendVariant)) {
+ gg.MarkAsGCCOnWindows();
+ }
# endif
return gg.WriteDyndepFile(dir_top_src, dir_top_bld, dir_cur_src, dir_cur_bld,
arg_dd, arg_ddis, module_dir, linked_target_dirs,
diff --git a/Source/cmGlobalNinjaGenerator.h b/Source/cmGlobalNinjaGenerator.h
index 12c6698..55fdbf0 100644
--- a/Source/cmGlobalNinjaGenerator.h
+++ b/Source/cmGlobalNinjaGenerator.h
@@ -169,7 +169,7 @@ public:
const std::string& comment = "");
bool IsGCCOnWindows() const { return this->UsingGCCOnWindows; }
- void SetUsingGCCOnWindows(bool b) { this->UsingGCCOnWindows = b; }
+ void MarkAsGCCOnWindows() { this->UsingGCCOnWindows = true; }
cmGlobalNinjaGenerator(cmake* cm);