diff options
| author | Sebastian Holtermann <sebholt@xwmw.org> | 2018-12-06 17:19:11 (GMT) |
|---|---|---|
| committer | Brad King <brad.king@kitware.com> | 2018-12-07 12:56:46 (GMT) |
| commit | 187481d4d988f45e05f2f7a6e89df89cd64ecfe9 (patch) | |
| tree | 8a310c65470b7994d460ea4a5b6f1e5a60adbf19 | |
| parent | 62942969062fcc9f24ca057b6983532a973cfad6 (diff) | |
| download | CMake-187481d4d988f45e05f2f7a6e89df89cd64ecfe9.zip CMake-187481d4d988f45e05f2f7a6e89df89cd64ecfe9.tar.gz CMake-187481d4d988f45e05f2f7a6e89df89cd64ecfe9.tar.bz2 | |
Autogen: Revert passing compiler implicit includes to moc
Passing an incomplete list of compiler include directories causes
a regression in the KIO project (and probably others). We need to
disable it until the complete list is available (see #16291).
Fixes: #18669
Issue: #18041
| -rw-r--r-- | Help/release/3.13.rst | 13 | ||||
| -rw-r--r-- | Source/cmQtAutoGenInitializer.cxx | 10 | ||||
| -rw-r--r-- | Tests/QtAutogen/CommonTests.cmake | 7 |
3 files changed, 24 insertions, 6 deletions
diff --git a/Help/release/3.13.rst b/Help/release/3.13.rst index 9f7e61f..68e05c3 100644 --- a/Help/release/3.13.rst +++ b/Help/release/3.13.rst @@ -239,3 +239,16 @@ Other Changes These internal implementation modules are also no longer available to scripts that may have been incorrectly including them, because they should never have been available in the first place. + +Updates +======= + +Changes made since CMake 3.13.0 include the following. + +3.13.2 +------ + +* CMake 3.13.0 included a change to pass compiler implicit include + directories to the ``moc`` tool for :prop_tgt:`AUTOMOC`. This has + been reverted due to regressing existing builds and will need + further investigation before being re-introduced in a later release. diff --git a/Source/cmQtAutoGenInitializer.cxx b/Source/cmQtAutoGenInitializer.cxx index ba7a565..f9c8c7f 100644 --- a/Source/cmQtAutoGenInitializer.cxx +++ b/Source/cmQtAutoGenInitializer.cxx @@ -386,9 +386,13 @@ bool cmQtAutoGenInitializer::InitMoc() // Moc includes { - bool const appendImplicit = (this->QtVersion.Major == 5); - auto GetIncludeDirs = - [this, localGen, appendImplicit](std::string const& cfg) -> std::string { + // We need to disable this until we have all implicit includes available. + // See issue #18669. + // bool const appendImplicit = (this->QtVersion.Major == 5); + + auto GetIncludeDirs = [this, + localGen](std::string const& cfg) -> std::string { + bool const appendImplicit = false; // Get the include dirs for this target, without stripping the implicit // include dirs off, see // https://gitlab.kitware.com/cmake/cmake/issues/13667 diff --git a/Tests/QtAutogen/CommonTests.cmake b/Tests/QtAutogen/CommonTests.cmake index 01ed7e9..ef11ddf 100644 --- a/Tests/QtAutogen/CommonTests.cmake +++ b/Tests/QtAutogen/CommonTests.cmake @@ -23,9 +23,10 @@ endif() if(QT_TEST_ALLOW_QT_MACROS) ADD_AUTOGEN_TEST(MocCMP0071) endif() -if(QT_TEST_VERSION GREATER 4) - ADD_AUTOGEN_TEST(MocOsMacros) -endif() +# Disabled for issue #18669 +#if(QT_TEST_VERSION GREATER 4) +# ADD_AUTOGEN_TEST(MocOsMacros) +#endif() ADD_AUTOGEN_TEST(UicInclude uicInclude) ADD_AUTOGEN_TEST(UicInterface QtAutoUicInterface) ADD_AUTOGEN_TEST(ObjectLibrary someProgram) |