Merge topic 'refactor-features'

e3078aa1 cmLocalGenerator: Implement GetFeature in terms of cmState.
7441fde3 cmLocalGenerator: Convert GetFeature recursion to loop.
ad0b0089 cmLocalGenerator: Simplify GetFeature implementation.
314c9ae3 cmLocalGenerator: Make GetFeature tail-recursive.

1 files changed, 9 insertions, 12 deletions

diff --git a/Source/cmLocalGenerator.cxx b/Source/cmLocalGenerator.cxx
index edb644d..c2d1a7d 100644
--- a/Source/cmLocalGenerator.cxx
+++ b/Source/cmLocalGenerator.cxx
@@ -2368,25 +2368,22 @@ void cmLocalGenerator::AppendFeatureOptions(
 const char* cmLocalGenerator::GetFeature(const std::string& feature,
                                          const std::string& config)
 {
+  std::string featureName = feature;
   // TODO: Define accumulation policy for features (prepend, append, replace).
   // Currently we always replace.
   if(!config.empty())
     {
-    std::string featureConfig = feature;
-    featureConfig += "_";
-    featureConfig += cmSystemTools::UpperCase(config);
-    if(const char* value = this->Makefile->GetProperty(featureConfig))
+    featureName += "_";
+    featureName += cmSystemTools::UpperCase(config);
+    }
+  cmState::Snapshot snp = this->StateSnapshot;
+  while(snp.IsValid())
+    {
+    if(const char* value = snp.GetDirectory().GetProperty(featureName))
       {
       return value;
       }
-    }
-  if(const char* value = this->Makefile->GetProperty(feature))
-    {
-    return value;
-    }
-  if(cmLocalGenerator* parent = this->GetParent())
-    {
-    return parent->GetFeature(feature, config);
+    snp = snp.GetBuildsystemDirectoryParent();
     }
   return 0;
 }