summaryrefslogtreecommitdiffstats
path: root/Help
diff options
context:
space:
mode:
authorBrad King <brad.king@kitware.com>2014-12-23 13:54:01 (GMT)
committerCMake Topic Stage <kwrobot@kitware.com>2014-12-23 13:54:01 (GMT)
commitcca8c3bb60ae156e3b14ca3d158a83b819b30d37 (patch)
tree5a6dedefb4bb6e545385856b142f419b67515ad8 /Help
parent90b015a0bacdbc066670becf0e16843c104cce8c (diff)
parent8d70a91489d74bd6056ba6858d815f5ee47a2e67 (diff)
downloadCMake-cca8c3bb60ae156e3b14ca3d158a83b819b30d37.zip
CMake-cca8c3bb60ae156e3b14ca3d158a83b819b30d37.tar.gz
CMake-cca8c3bb60ae156e3b14ca3d158a83b819b30d37.tar.bz2
Merge topic 'doc-octothorpe-escaping'
8d70a914 Help: Add 3.1 release note about '#' escaping in Makefiles (#15322)
Diffstat (limited to 'Help')
-rw-r--r--Help/release/3.1.0.rst22
1 files changed, 22 insertions, 0 deletions
diff --git a/Help/release/3.1.0.rst b/Help/release/3.1.0.rst
index a5b3e8e..97a63f9 100644
--- a/Help/release/3.1.0.rst
+++ b/Help/release/3.1.0.rst
@@ -353,6 +353,28 @@ Deprecated and Removed Features
CMake 3.1 again requires the quotes for this to work correctly.
+* Prior to CMake 3.1 the Makefile generators did not escape ``#``
+ correctly inside make variable assignments used in generated
+ makefiles, causing them to be treated as comments. This made
+ code like::
+
+ add_compile_options(-Wno-#pragma-messages)
+
+ not work in Makefile generators, but work in other generators.
+ Now it is escaped correctly, making the behavior consistent
+ across generators. However, some projects may have tried to
+ workaround the original bug with code like::
+
+ set(CMAKE_C_FLAGS "${CMAKE_C_FLAGS} -Wno-\\#pragma-messages")
+
+ This added the needed escape for Makefile generators but also
+ caused other generators to pass ``-Wno-\#pragma-messages`` to
+ the shell, which would work only in POSIX shells.
+ Unfortunately the escaping fix could not be made in a compatible
+ way so this platform- and generator-specific workaround no
+ longer works. Project code may test the :variable:`CMAKE_VERSION`
+ variable value to make the workaround version-specific too.
+
* Callbacks established by the :command:`variable_watch` command will no
longer receive the ``ALLOWED_UNKNOWN_READ_ACCESS`` access type when
the undocumented ``CMAKE_ALLOW_UNKNOWN_VARIABLE_READ_ACCESS`` variable is