diff options
| author | Shoaib Meenai <smeenai@fb.com> | 2020-09-23 23:58:39 (GMT) |
|---|---|---|
| committer | Brad King <brad.king@kitware.com> | 2020-09-24 19:37:24 (GMT) |
| commit | f5d3da091b8e5952f8e880afbd09ee2f18e8ea7f (patch) | |
| tree | 6cbe0792ac937cde4ecd40d0a731124028ebe40e /Modules/FindPNG.cmake | |
| parent | 177fc020731bcee747295573c92cd0f7ca200e53 (diff) | |
| download | CMake-f5d3da091b8e5952f8e880afbd09ee2f18e8ea7f.zip CMake-f5d3da091b8e5952f8e880afbd09ee2f18e8ea7f.tar.gz CMake-f5d3da091b8e5952f8e880afbd09ee2f18e8ea7f.tar.bz2 | |
Clang: Look for llvm-lib when using MSVC-like front-end
In commit 55196a1440 (MSVC: Use 'lib' instead of 'link /lib' to create
static libraries, 2020-01-10, v3.18.0-rc1~625^2) we changed CMake to use
lib instead of `link /lib` to create static libraries, but it didn't
search for `llvm-lib`. If you have `llvm-lib` but not `lib` (e.g. when
cross-compiling), when `CMakeFindBinutils` is invoked for the `C` and
`CXX` languages, `CMAKE_AR` is not found. When it's subsequently invoked
for the ASM language, `CMAKE_ASM_SIMULATE_ID` and
`CMAKE_ASM_COMPILER_FRONTEND_VARIANT` are not set (because
`CMakeDetermineASMCompiler` doesn't call `CMAKE_DETERMINE_COMPILER_ID`,
which sets those variables), so we go down the non-MSVC conditional and
set `CMAKE_AR` to a GNU-style `ar`, which of course does not understand
lib flags. Explicitly search for `llvm-lib` to avoid this situation.
Diffstat (limited to 'Modules/FindPNG.cmake')
0 files changed, 0 insertions, 0 deletions