diff options
| author | Daniel Pfeifer <daniel@pfeifer-mail.de> | 2016-05-24 19:24:10 (GMT) |
|---|---|---|
| committer | Daniel Pfeifer <daniel@pfeifer-mail.de> | 2016-05-24 21:22:24 (GMT) |
| commit | 5784747d1b0404a0c1cb0223b15b823476023fba (patch) | |
| tree | 763d07bbde561ad1a2322328764b93b6c1852db2 /Source/CPack/IFW/cmCPackIFWPackage.cxx | |
| parent | 5cec953e6aafd4c132a7b6c0a929d95c1dee79ea (diff) | |
| download | CMake-5784747d1b0404a0c1cb0223b15b823476023fba.zip CMake-5784747d1b0404a0c1cb0223b15b823476023fba.tar.gz CMake-5784747d1b0404a0c1cb0223b15b823476023fba.tar.bz2 | |
Improve string find: prefer character overloads.
Apply fix-its from clang-tidy's performance-faster-string-find checker.
Ignore findings in kwsys.
Diffstat (limited to 'Source/CPack/IFW/cmCPackIFWPackage.cxx')
| -rw-r--r-- | Source/CPack/IFW/cmCPackIFWPackage.cxx | 6 |
1 files changed, 3 insertions, 3 deletions
diff --git a/Source/CPack/IFW/cmCPackIFWPackage.cxx b/Source/CPack/IFW/cmCPackIFWPackage.cxx index df612e5..ad153d1 100644 --- a/Source/CPack/IFW/cmCPackIFWPackage.cxx +++ b/Source/CPack/IFW/cmCPackIFWPackage.cxx @@ -56,13 +56,13 @@ cmCPackIFWPackage::DependenceStruct::DependenceStruct( } else if ((pos = dependence.find(">=")) != std::string::npos) { Compare.Type = CompareGreaterOrEqual; Compare.Value = dependence.substr(pos + 2); - } else if ((pos = dependence.find("<")) != std::string::npos) { + } else if ((pos = dependence.find('<')) != std::string::npos) { Compare.Type = CompareLess; Compare.Value = dependence.substr(pos + 1); - } else if ((pos = dependence.find("=")) != std::string::npos) { + } else if ((pos = dependence.find('=')) != std::string::npos) { Compare.Type = CompareEqual; Compare.Value = dependence.substr(pos + 1); - } else if ((pos = dependence.find(">")) != std::string::npos) { + } else if ((pos = dependence.find('>')) != std::string::npos) { Compare.Type = CompareGreater; Compare.Value = dependence.substr(pos + 1); } |