diff options
| author | Brad King <brad.king@kitware.com> | 2009-07-28 14:47:02 (GMT) |
|---|---|---|
| committer | Brad King <brad.king@kitware.com> | 2009-07-28 14:47:02 (GMT) |
| commit | e9d7ebb3ec751528a422108b20dc3c24fcd39530 (patch) | |
| tree | 07660eabb01ffed7532d15fb915e608d8c6bb3a7 /Source/CPack | |
| parent | 57057ee59550980e19d5c4535d3ec0f4734653a0 (diff) | |
| download | CMake-e9d7ebb3ec751528a422108b20dc3c24fcd39530.zip CMake-e9d7ebb3ec751528a422108b20dc3c24fcd39530.tar.gz CMake-e9d7ebb3ec751528a422108b20dc3c24fcd39530.tar.bz2 | |
BUG: Do not double-initialize local generators
All global generator CreateLocalGenerator methods automatically
initialize the local generator instances with SetGlobalGenerator. In
several places we were calling SetGlobalGenerator again after receiving
the return value from CreateLocalGenerator. The double-initializations
leaked the resources allocated by the first call to SetGlobalGenerator.
This fix removes the unnecessary calls.
Diffstat (limited to 'Source/CPack')
| -rw-r--r-- | Source/CPack/cmCPackGenerator.cxx | 1 |
1 files changed, 0 insertions, 1 deletions
diff --git a/Source/CPack/cmCPackGenerator.cxx b/Source/CPack/cmCPackGenerator.cxx index a8d500c..509fdb9 100644 --- a/Source/CPack/cmCPackGenerator.cxx +++ b/Source/CPack/cmCPackGenerator.cxx @@ -623,7 +623,6 @@ int cmCPackGenerator::InstallProjectViaInstallCMakeProjects( cmGlobalGenerator gg; gg.SetCMakeInstance(&cm); std::auto_ptr<cmLocalGenerator> lg(gg.CreateLocalGenerator()); - lg->SetGlobalGenerator(&gg); cmMakefile *mf = lg->GetMakefile(); std::string realInstallDirectory = tempInstallDirectory; if ( !installSubDirectory.empty() && installSubDirectory != "/" ) |