diff options
| author | Daniel Pfeifer <daniel@pfeifer-mail.de> | 2016-12-10 13:42:49 (GMT) |
|---|---|---|
| committer | Brad King <brad.king@kitware.com> | 2016-12-12 19:04:12 (GMT) |
| commit | 7c9db8f8139b945d4c55d9061e4ef122351b210d (patch) | |
| tree | dd2d523653994aeeb93e949550e3ac4ef27058be /Source/cmAlgorithms.h | |
| parent | b88843d651dc2c500af13c1fe882b389c4949b04 (diff) | |
| download | CMake-7c9db8f8139b945d4c55d9061e4ef122351b210d.zip CMake-7c9db8f8139b945d4c55d9061e4ef122351b210d.tar.gz CMake-7c9db8f8139b945d4c55d9061e4ef122351b210d.tar.bz2 | |
clang-tidy: apply performance-unnecessary-value-param fixes
Diffstat (limited to 'Source/cmAlgorithms.h')
| -rw-r--r-- | Source/cmAlgorithms.h | 8 |
1 files changed, 4 insertions, 4 deletions
diff --git a/Source/cmAlgorithms.h b/Source/cmAlgorithms.h index 22f69fa..7c683ad 100644 --- a/Source/cmAlgorithms.h +++ b/Source/cmAlgorithms.h @@ -242,7 +242,7 @@ std::string cmJoin(Range const& r, const char* delimiter) } template <typename Range> -std::string cmJoin(Range const& r, std::string delimiter) +std::string cmJoin(Range const& r, std::string const& delimiter) { return cmJoin(r, delimiter.c_str()); } @@ -344,13 +344,13 @@ typename Range::const_iterator cmRemoveDuplicates(Range& r) } template <typename Range> -std::string cmWrap(std::string prefix, Range const& r, std::string suffix, - std::string sep) +std::string cmWrap(std::string const& prefix, Range const& r, + std::string const& suffix, std::string const& sep) { if (r.empty()) { return std::string(); } - return prefix + cmJoin(r, (suffix + sep + prefix).c_str()) + suffix; + return prefix + cmJoin(r, suffix + sep + prefix) + suffix; } template <typename Range> |