cmListFileCache: Make cmListFileFunction a shared pointer

Passing cmListFileFunction everywhere by-value involves big overhead.
Now cmListFileFunction stores std::shared_ptr to the underlying data.

1 files changed, 4 insertions, 8 deletions

diff --git a/Source/cmCMakeLanguageCommand.cxx b/Source/cmCMakeLanguageCommand.cxx
index 9277c20..789c78d 100644
--- a/Source/cmCMakeLanguageCommand.cxx
+++ b/Source/cmCMakeLanguageCommand.cxx
@@ -77,18 +77,14 @@ bool cmCMakeLanguageCommandCALL(std::vector<cmListFileArgument> const& args,
   cmMakefile& makefile = status.GetMakefile();
   cmListFileContext context = makefile.GetBacktrace().Top();
 
-  cmListFileFunction func;
-  func.Name = callCommand;
-  func.Line = context.Line;
+  std::vector<cmListFileArgument> funcArgs;
+  funcArgs.reserve(args.size() - startArg);
 
   // The rest of the arguments are passed to the function call above
   for (size_t i = startArg; i < args.size(); ++i) {
-    cmListFileArgument lfarg;
-    lfarg.Delim = args[i].Delim;
-    lfarg.Line = context.Line;
-    lfarg.Value = args[i].Value;
-    func.Arguments.emplace_back(lfarg);
+    funcArgs.emplace_back(args[i].Value, args[i].Delim, context.Line);
   }
+  cmListFileFunction func{ callCommand, context.Line, std::move(funcArgs) };
 
   if (defer) {
     if (defer->Id.empty()) {