diff options
| author | Ben Boeckel <ben.boeckel@kitware.com> | 2014-02-10 05:21:34 (GMT) |
|---|---|---|
| committer | Brad King <brad.king@kitware.com> | 2014-03-08 18:05:35 (GMT) |
| commit | 270eb96df05b93023cdd3d3a186b44b4ece1d655 (patch) | |
| tree | 25d3037b5412b24242c631cccfe36e16a0fa8e1c /Source/cmDefinitions.cxx | |
| parent | 215b1addf09359507281359cd7d478c61c01a9f2 (diff) | |
| download | CMake-270eb96df05b93023cdd3d3a186b44b4ece1d655.zip CMake-270eb96df05b93023cdd3d3a186b44b4ece1d655.tar.gz CMake-270eb96df05b93023cdd3d3a186b44b4ece1d655.tar.bz2 | |
strings: Remove cmStdString references
Casts from std::string -> cmStdString were high on the list of things
taking up time. Avoid such implicit casts across function calls by just
using std::string everywhere.
The comment that the symbol name is too long is no longer relevant since
modern debuggers alias the templates anyways and the size is a
non-issue since the underlying methods are generated since it's
inherited.
Diffstat (limited to 'Source/cmDefinitions.cxx')
| -rw-r--r-- | Source/cmDefinitions.cxx | 20 |
1 files changed, 10 insertions, 10 deletions
diff --git a/Source/cmDefinitions.cxx b/Source/cmDefinitions.cxx index 5fa3877..babf1c4 100644 --- a/Source/cmDefinitions.cxx +++ b/Source/cmDefinitions.cxx @@ -85,9 +85,9 @@ const char* cmDefinitions::Set(const std::string& key, const char* value) } //---------------------------------------------------------------------------- -std::set<cmStdString> cmDefinitions::LocalKeys() const +std::set<std::string> cmDefinitions::LocalKeys() const { - std::set<cmStdString> keys; + std::set<std::string> keys; // Consider local definitions. for(MapType::const_iterator mi = this->Map.begin(); mi != this->Map.end(); ++mi) @@ -110,12 +110,12 @@ cmDefinitions cmDefinitions::Closure() const cmDefinitions::cmDefinitions(ClosureTag const&, cmDefinitions const* root): Up(0) { - std::set<cmStdString> undefined; + std::set<std::string> undefined; this->ClosureImpl(undefined, root); } //---------------------------------------------------------------------------- -void cmDefinitions::ClosureImpl(std::set<cmStdString>& undefined, +void cmDefinitions::ClosureImpl(std::set<std::string>& undefined, cmDefinitions const* defs) { // Consider local definitions. @@ -145,17 +145,17 @@ void cmDefinitions::ClosureImpl(std::set<cmStdString>& undefined, } //---------------------------------------------------------------------------- -std::set<cmStdString> cmDefinitions::ClosureKeys() const +std::set<std::string> cmDefinitions::ClosureKeys() const { - std::set<cmStdString> defined; - std::set<cmStdString> undefined; + std::set<std::string> defined; + std::set<std::string> undefined; this->ClosureKeys(defined, undefined); return defined; } //---------------------------------------------------------------------------- -void cmDefinitions::ClosureKeys(std::set<cmStdString>& defined, - std::set<cmStdString>& undefined) const +void cmDefinitions::ClosureKeys(std::set<std::string>& defined, + std::set<std::string>& undefined) const { // Consider local definitions. for(MapType::const_iterator mi = this->Map.begin(); @@ -165,7 +165,7 @@ void cmDefinitions::ClosureKeys(std::set<cmStdString>& defined, if(defined.find(mi->first) == defined.end() && undefined.find(mi->first) == undefined.end()) { - std::set<cmStdString>& m = mi->second.Exists? defined : undefined; + std::set<std::string>& m = mi->second.Exists? defined : undefined; m.insert(mi->first); } } |