diff options
| author | Ben Boeckel <ben.boeckel@kitware.com> | 2014-04-30 17:12:29 (GMT) |
|---|---|---|
| committer | Ben Boeckel <ben.boeckel@kitware.com> | 2014-06-09 18:45:35 (GMT) |
| commit | 3e7194a215aed5e34acf32ad4b8c6bd948beb15e (patch) | |
| tree | d64f0613579fdf8fda51ce8fd05f6045a3a2142e /Source/cmGeneratorExpression.cxx | |
| parent | 9e8fa1043ce9bfcffdcfa395f618dd7958ef4251 (diff) | |
| download | CMake-3e7194a215aed5e34acf32ad4b8c6bd948beb15e.zip CMake-3e7194a215aed5e34acf32ad4b8c6bd948beb15e.tar.gz CMake-3e7194a215aed5e34acf32ad4b8c6bd948beb15e.tar.bz2 | |
regex: Use static regexs where possible
Rather than declaring and compiling a constant regex every time a chunk
of code is executed, build the regex once.
Diffstat (limited to 'Source/cmGeneratorExpression.cxx')
| -rw-r--r-- | Source/cmGeneratorExpression.cxx | 5 |
1 files changed, 2 insertions, 3 deletions
diff --git a/Source/cmGeneratorExpression.cxx b/Source/cmGeneratorExpression.cxx index 028d229..2b4d955 100644 --- a/Source/cmGeneratorExpression.cxx +++ b/Source/cmGeneratorExpression.cxx @@ -469,12 +469,11 @@ std::string::size_type cmGeneratorExpression::Find(const std::string &input) //---------------------------------------------------------------------------- bool cmGeneratorExpression::IsValidTargetName(const std::string &input) { - cmsys::RegularExpression targetNameValidator; // The ':' is supported to allow use with IMPORTED targets. At least // Qt 4 and 5 IMPORTED targets use ':' as the namespace delimiter. - targetNameValidator.compile("^[A-Za-z0-9_.:+-]+$"); + static cmsys::RegularExpression targetNameValidator("^[A-Za-z0-9_.:+-]+$"); - return targetNameValidator.find(input.c_str()); + return targetNameValidator.find(input); } //---------------------------------------------------------------------------- |