cmList: Fix performance regression in Join / to_string

Refactoring in commit 45f17e5a85 (cmList: Add container conversion to
string, 2023-06-20) accidentally introduced unnecessary string copies
and allocations. Remove unnecessary copies.

1 files changed, 6 insertions, 7 deletions

diff --git a/Source/cmList.h b/Source/cmList.h
index 9ee4a46..dc5850a 100644
--- a/Source/cmList.h
+++ b/Source/cmList.h
@@ -1211,13 +1211,12 @@ private:
 
     const auto sep = std::string{ glue };
 
-    return std::accumulate(
-      std::next(std::begin(r)), std::end(r), cmList::ToString(*std::begin(r)),
-      [&sep](std::string const& a,
-             typename std::iterator_traits<decltype(std::begin(
-               r))>::value_type const& b) -> std::string {
-        return a + sep + cmList::ToString(b);
-      });
+    std::string joined = cmList::ToString(*std::begin(r));
+    for (auto it = std::next(std::begin(r)); it != std::end(r); ++it) {
+      joined += sep + cmList::ToString(*it);
+    }
+
+    return joined;
   }
 
   container_type Values;