Remove barely-used cmMakefile::AddCacheDefinition

The boolean overload of this method was used only to implement option().
We re-implement option() in terms of the main method and removes the
now-unused signature.  This removes some duplicate code that had already
fallen behind on changes (it was not removing the local definition
instead of setting it).

1 files changed, 2 insertions, 4 deletions

diff --git a/Source/cmOptionCommand.cxx b/Source/cmOptionCommand.cxx
index 0c70411..8f2bd66 100644
--- a/Source/cmOptionCommand.cxx
+++ b/Source/cmOptionCommand.cxx
@@ -69,9 +69,7 @@ bool cmOptionCommand
     {
     initialValue = args[2];
     }
-  this->Makefile->AddCacheDefinition(args[0].c_str(),
-    cmSystemTools::IsOn(initialValue.c_str()),
-    args[1].c_str());
-
+  this->Makefile->AddCacheDefinition(args[0].c_str(), initialValue.c_str(),
+                                     args[1].c_str(), cmCacheManager::BOOL);
   return true;
 }