diff options
| author | Brad King <brad.king@kitware.com> | 2017-10-13 18:24:52 (GMT) |
|---|---|---|
| committer | Brad King <brad.king@kitware.com> | 2017-10-13 18:32:14 (GMT) |
| commit | 2de0e0fdfaed1c10d3b38a8fb7ff86698a0308aa (patch) | |
| tree | 780e2267b79622478724bcf6681844eca61735a0 /Tests/InterfaceLibrary | |
| parent | a91eb5e41f486628910f189bf40403568af013c7 (diff) | |
| download | CMake-2de0e0fdfaed1c10d3b38a8fb7ff86698a0308aa.zip CMake-2de0e0fdfaed1c10d3b38a8fb7ff86698a0308aa.tar.gz CMake-2de0e0fdfaed1c10d3b38a8fb7ff86698a0308aa.tar.bz2 | |
Do not initialize NO_SYSTEM_FROM_IMPORTED on INTERFACE libraries
The change in commit v3.8.0-rc1~276^2 (Allow NO_SYSTEM_FROM_IMPORTED on
imported INTERFACE libraries, 2016-11-21) was incorrect. The property
is not meant to be set on imported targets at all. It is meant to be
set on their consumers that compile sources. Since INTERFACE libraries
have no sources to compile, the property is not needed on them.
Revert most of that change. Unfortunately we must still tolerate
project code setting NO_SYSTEM_FROM_IMPORTED on INTERFACE libraries
because they were allowed by CMake 3.8 and 3.9.
Issue: #17348
Diffstat (limited to 'Tests/InterfaceLibrary')
| -rw-r--r-- | Tests/InterfaceLibrary/CMakeLists.txt | 1 |
1 files changed, 0 insertions, 1 deletions
diff --git a/Tests/InterfaceLibrary/CMakeLists.txt b/Tests/InterfaceLibrary/CMakeLists.txt index 33c4b90..3db210a 100644 --- a/Tests/InterfaceLibrary/CMakeLists.txt +++ b/Tests/InterfaceLibrary/CMakeLists.txt @@ -64,7 +64,6 @@ target_link_libraries(iface_whitelist INTERFACE $<$<BOOL:$<TARGET_PROPERTY:CUSTO add_executable(exec_whitelist dummy.cpp) target_link_libraries(exec_whitelist iface_whitelist) -set(CMAKE_NO_SYSTEM_FROM_IMPORTED 1) add_library(iface_imported INTERFACE IMPORTED) set_property(TARGET iface_imported PROPERTY INTERFACE_COMPILE_DEFINITIONS |