diff options
author | Dimitri van Heesch <doxygen@gmail.com> | 2021-04-11 19:22:59 (GMT) |
---|---|---|
committer | Dimitri van Heesch <doxygen@gmail.com> | 2021-04-22 17:34:13 (GMT) |
commit | 592aaa4f17d73ec8c475df0f44efaea8cc4d575c (patch) | |
tree | 3cfd68cec756661045ee25c906a8d8f4bddf7a6a /src/configgen.py | |
parent | 98c67549bc3cd855873e0ef5eeab7c6410699d78 (diff) | |
download | Doxygen-592aaa4f17d73ec8c475df0f44efaea8cc4d575c.zip Doxygen-592aaa4f17d73ec8c475df0f44efaea8cc4d575c.tar.gz Doxygen-592aaa4f17d73ec8c475df0f44efaea8cc4d575c.tar.bz2 |
Refactoring: remove implicit conversion from QCString to const char *
This commit changes the following in relation to string use
- The implicit convert from 'QCString' to 'const char *' is removed
- Strings parameters use 'const QCString &' as much as possible in favor
over 'const char *'
- 'if (s)' where s is a QCString has been replaced by 'if(!s.isEmpty())'
- data() now always returns a valid C-string and not a 0-pointer.
- when passing a string 's' to printf and related functions 'qPrint(s)' is
used instead of 's.data()'
- for empty string arguments 'QCString()' is used instead of '0'
- The copy() operation has been removed
- Where possible 'qstrcmp(a,b)==0' has been replaces by 'a==b' and
'qstrcmp(a,b)<0' has been replaced by 'a<b'
- Parameters of string type that were default initialized with '= 0' are
no initialized with '= QCString()'
Diffstat (limited to 'src/configgen.py')
-rwxr-xr-x | src/configgen.py | 6 |
1 files changed, 3 insertions, 3 deletions
diff --git a/src/configgen.py b/src/configgen.py index 0d18e84..d3b9137 100755 --- a/src/configgen.py +++ b/src/configgen.py @@ -720,7 +720,7 @@ def main(): print(" StringVector ConfigValues::*l;"); print(" } value;"); print(" };"); - print(" const Info *get(const char *tag) const;"); + print(" const Info *get(const QCString &tag) const;"); print(" private:") for n in elem.childNodes: if n.nodeType == Node.ELEMENT_NODE: @@ -738,7 +738,7 @@ def main(): print("#include \"configimpl.h\"") print("#include <unordered_map>") print("") - print("const ConfigValues::Info *ConfigValues::get(const char *tag) const"); + print("const ConfigValues::Info *ConfigValues::get(const QCString &tag) const"); print("{"); print(" static const std::unordered_map< std::string, Info > configMap ="); print(" {"); @@ -747,7 +747,7 @@ def main(): if (n.nodeName == "group"): parseGroupMapInit(n) print(" };"); - print(" auto it = configMap.find(tag);"); + print(" auto it = configMap.find(tag.str());"); print(" return it!=configMap.end() ? &it->second : nullptr;"); print("}"); print("") |