diff options
author | Dimitri van Heesch <doxygen@gmail.com> | 2021-04-11 19:22:59 (GMT) |
---|---|---|
committer | Dimitri van Heesch <doxygen@gmail.com> | 2021-04-22 17:34:13 (GMT) |
commit | 592aaa4f17d73ec8c475df0f44efaea8cc4d575c (patch) | |
tree | 3cfd68cec756661045ee25c906a8d8f4bddf7a6a /src/fileparser.cpp | |
parent | 98c67549bc3cd855873e0ef5eeab7c6410699d78 (diff) | |
download | Doxygen-592aaa4f17d73ec8c475df0f44efaea8cc4d575c.zip Doxygen-592aaa4f17d73ec8c475df0f44efaea8cc4d575c.tar.gz Doxygen-592aaa4f17d73ec8c475df0f44efaea8cc4d575c.tar.bz2 |
Refactoring: remove implicit conversion from QCString to const char *
This commit changes the following in relation to string use
- The implicit convert from 'QCString' to 'const char *' is removed
- Strings parameters use 'const QCString &' as much as possible in favor
over 'const char *'
- 'if (s)' where s is a QCString has been replaced by 'if(!s.isEmpty())'
- data() now always returns a valid C-string and not a 0-pointer.
- when passing a string 's' to printf and related functions 'qPrint(s)' is
used instead of 's.data()'
- for empty string arguments 'QCString()' is used instead of '0'
- The copy() operation has been removed
- Where possible 'qstrcmp(a,b)==0' has been replaces by 'a==b' and
'qstrcmp(a,b)<0' has been replaced by 'a<b'
- Parameters of string type that were default initialized with '= 0' are
no initialized with '= QCString()'
Diffstat (limited to 'src/fileparser.cpp')
-rw-r--r-- | src/fileparser.cpp | 23 |
1 files changed, 13 insertions, 10 deletions
diff --git a/src/fileparser.cpp b/src/fileparser.cpp index 34085dc..33491fc 100644 --- a/src/fileparser.cpp +++ b/src/fileparser.cpp @@ -17,19 +17,19 @@ #include "outputgen.h" void FileCodeParser::parseCode(CodeOutputInterface &codeOutIntf, - const char *, // scopeName + const QCString &, // scopeName const QCString & input, - SrcLangExt, // lang - bool, // isExampleBlock - const char *, // exampleName + SrcLangExt, // lang + bool, // isExampleBlock + const QCString &, // exampleName FileDef * fileDef, int startLine, int endLine, - bool, // inlineFragment - const MemberDef *, // memberDef + bool, // inlineFragment + const MemberDef *, // memberDef bool showLineNumbers, - const Definition *, // searchCtx, - bool // collectXRefs + const Definition *, // searchCtx, + bool // collectXRefs ) { int lineNr = startLine!=-1 ? startLine : 1; @@ -41,8 +41,11 @@ void FileCodeParser::parseCode(CodeOutputInterface &codeOutIntf, while (j<length && input[j]!='\n') j++; QCString lineStr = input.mid(i,j-i); codeOutIntf.startCodeLine(fileDef != 0 && showLineNumbers); - if (fileDef != 0 && showLineNumbers) codeOutIntf.writeLineNumber(0,0,0,lineNr); - if (!lineStr.isEmpty()) codeOutIntf.codify(lineStr); + if (fileDef != 0 && showLineNumbers) + { + codeOutIntf.writeLineNumber(QCString(),QCString(),QCString(),lineNr); + } + if (!lineStr.isEmpty()) codeOutIntf.codify(lineStr.data()); codeOutIntf.endCodeLine(); lineNr++; i=j+1; |