diff options
| author | Nico Weber <nicolasweber@gmx.de> | 2017-10-20 17:10:17 (GMT) |
|---|---|---|
| committer | GitHub <noreply@github.com> | 2017-10-20 17:10:17 (GMT) |
| commit | 0d9bf7866322c9abd4e7e537d64d979af56498d7 (patch) | |
| tree | 8ce839b2822b2bb70bd6d82e9b0d0cab8c465dfa | |
| parent | aa7b69bfa61e05b5255a1454585f9f21bdf4fb6b (diff) | |
| parent | 7c80007b55fd42cdd56b06cb4330fb8ceb468e09 (diff) | |
| download | Ninja-0d9bf7866322c9abd4e7e537d64d979af56498d7.zip Ninja-0d9bf7866322c9abd4e7e537d64d979af56498d7.tar.gz Ninja-0d9bf7866322c9abd4e7e537d64d979af56498d7.tar.bz2 | |
Merge pull request #1344 from loganchien/fix-buf-overrun
Fix potential buffer overrun
| -rw-r--r-- | src/deps_log.cc | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/src/deps_log.cc b/src/deps_log.cc index 89c6023..8734dd7 100644 --- a/src/deps_log.cc +++ b/src/deps_log.cc @@ -209,7 +209,7 @@ bool DepsLog::Load(const string& path, State* state, string* err) { bool is_deps = (size >> 31) != 0; size = size & 0x7FFFFFFF; - if (fread(buf, size, 1, f) < 1 || size > kMaxRecordSize) { + if (size > kMaxRecordSize || fread(buf, size, 1, f) < 1) { read_failed = true; break; } |